From: Christian Brauner <brauner@kernel.org>
To: Miklos Szeredi <miklos@szeredi.hu>, Amir Goldstein <amir73il@gmail.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
linux-unionfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Christian Brauner <brauner@kernel.org>
Subject: [PATCH 3/5] ovl: mark *_cu_creds() as unused temporarily
Date: Fri, 14 Nov 2025 23:45:24 +0100 [thread overview]
Message-ID: <20251114-work-ovl-cred-guard-copyup-v1-3-ea3fb15cf427@kernel.org> (raw)
In-Reply-To: <20251114-work-ovl-cred-guard-copyup-v1-0-ea3fb15cf427@kernel.org>
They will become unused in the next patch and we'll drop them after the
conversion is finished together with the struct. This keeps the changes
small and reviewable.
Signed-off-by: Christian Brauner <brauner@kernel.org>
---
fs/overlayfs/copy_up.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/overlayfs/copy_up.c b/fs/overlayfs/copy_up.c
index 665c5f24e228..9acc1549d46d 100644
--- a/fs/overlayfs/copy_up.c
+++ b/fs/overlayfs/copy_up.c
@@ -732,7 +732,7 @@ struct ovl_cu_creds {
struct cred *new;
};
-static int ovl_prep_cu_creds(struct dentry *dentry, struct ovl_cu_creds *cc)
+static int __maybe_unused ovl_prep_cu_creds(struct dentry *dentry, struct ovl_cu_creds *cc)
{
int err;
@@ -747,7 +747,7 @@ static int ovl_prep_cu_creds(struct dentry *dentry, struct ovl_cu_creds *cc)
return 0;
}
-static void ovl_revert_cu_creds(struct ovl_cu_creds *cc)
+static void __maybe_unused ovl_revert_cu_creds(struct ovl_cu_creds *cc)
{
if (cc->new) {
revert_creds(cc->old);
--
2.47.3
next prev parent reply other threads:[~2025-11-14 22:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-14 22:45 [PATCH 0/5] ovl: convert copyup credential override to cred guard Christian Brauner
2025-11-14 22:45 ` [PATCH 1/5] ovl: add copy up credential guard Christian Brauner
2025-11-14 22:45 ` [PATCH 2/5] ovl: port ovl_copy_up_workdir() to cred guard Christian Brauner
2025-11-14 22:45 ` Christian Brauner [this message]
2025-11-14 22:45 ` [PATCH 4/5] ovl: port ovl_copy_up_tmpfile() " Christian Brauner
2025-11-14 22:45 ` [PATCH 5/5] ovl: remove struct ovl_cu_creds and associated functions Christian Brauner
2025-11-15 8:26 ` [PATCH 0/5] ovl: convert copyup credential override to cred guard Amir Goldstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251114-work-ovl-cred-guard-copyup-v1-3-ea3fb15cf427@kernel.org \
--to=brauner@kernel.org \
--cc=amir73il@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).