From: Christoph Hellwig <hch@lst.de>
To: Al Viro <viro@zeniv.linux.org.uk>
Cc: Christoph Hellwig <hch@lst.de>,
brauner@kernel.org, jack@suse.cz, linux-fsdevel@vger.kernel.org,
Andrey Albershteyn <aalbersh@redhat.com>
Subject: Re: [PATCH] fs: unexport ioctl_getflags
Date: Wed, 19 Nov 2025 06:43:25 +0100 [thread overview]
Message-ID: <20251119054325.GB19925@lst.de> (raw)
In-Reply-To: <20251119003004.GK2441659@ZenIV>
On Wed, Nov 19, 2025 at 12:30:04AM +0000, Al Viro wrote:
> On Tue, Nov 18, 2025 at 08:09:41AM +0100, Christoph Hellwig wrote:
> > No modular users, nor should there be any for a dispatcher like this.
>
> ... and AFAICS there never had been any, so it shouldn't have been
> exported in the first place.
Good question. It looks like Andrey added them when moving to the
code to a new file despite that commit claiming to be pure refactoring.
next prev parent reply other threads:[~2025-11-19 5:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-18 7:09 [PATCH] fs: unexport ioctl_getflags Christoph Hellwig
2025-11-18 10:48 ` Johannes Thumshirn
2025-11-18 15:59 ` Darrick J. Wong
2025-11-19 5:43 ` Christoph Hellwig
2025-11-19 0:30 ` Al Viro
2025-11-19 5:43 ` Christoph Hellwig [this message]
2025-11-19 8:42 ` Christian Brauner
2025-11-19 9:01 ` Christoph Hellwig
2025-11-19 9:53 ` Christian Brauner
2025-11-19 8:45 ` Christian Brauner
2025-11-19 9:03 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251119054325.GB19925@lst.de \
--to=hch@lst.de \
--cc=aalbersh@redhat.com \
--cc=brauner@kernel.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).