From: Christoph Hellwig <hch@lst.de>
To: Christian Brauner <brauner@kernel.org>
Cc: Al Viro <viro@zeniv.linux.org.uk>,
David Sterba <dsterba@suse.com>, Jan Kara <jack@suse.cz>,
Mike Marshall <hubcap@omnibond.com>,
Martin Brandenburg <martin@omnibond.com>,
Carlos Maiolino <cem@kernel.org>, Stefan Roesch <shr@fb.com>,
Jeff Layton <jlayton@kernel.org>,
linux-kernel@vger.kernel.org, linux-btrfs@vger.kernel.org,
linux-fsdevel@vger.kernel.org, gfs2@lists.linux.dev,
io-uring@vger.kernel.org, devel@lists.orangefs.org,
linux-unionfs@vger.kernel.org, linux-mtd@lists.infradead.org,
linux-xfs@vger.kernel.org, linux-nfs@vger.kernel.org
Subject: [PATCH 04/16] btrfs: use vfs_utimes to update file timestamps
Date: Thu, 20 Nov 2025 07:47:25 +0100 [thread overview]
Message-ID: <20251120064859.2911749-5-hch@lst.de> (raw)
In-Reply-To: <20251120064859.2911749-1-hch@lst.de>
Btrfs updates the device node timestamps for block device special files
when it stop using the device.
Commit 8f96a5bfa150 ("btrfs: update the bdev time directly when closing")
switch that update from the correct layering to directly call the
low-level helper on the bdev inode. This is wrong and got fixed in
commit 54fde91f52f5 ("btrfs: update device path inode time instead of
bd_inode") by updating the file system inode instead of the bdev inode,
but this kept the incorrect bypassing of the VFS interfaces and file
system ->update_times method. Fix this by using the propet vfs_utimes
interface.
Fixes: 8f96a5bfa150 ("btrfs: update the bdev time directly when closing")
Fixes: 54fde91f52f5 ("btrfs: update device path inode time instead of bd_inode")
Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Jeff Layton <jlayton@kernel.org>
---
fs/btrfs/volumes.c | 11 ++++-------
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c
index 2bec544d8ba3..259e8b0496df 100644
--- a/fs/btrfs/volumes.c
+++ b/fs/btrfs/volumes.c
@@ -2002,14 +2002,11 @@ static int btrfs_add_dev_item(struct btrfs_trans_handle *trans,
static void update_dev_time(const char *device_path)
{
struct path path;
- int ret;
- ret = kern_path(device_path, LOOKUP_FOLLOW, &path);
- if (ret)
- return;
-
- inode_update_time(d_inode(path.dentry), S_MTIME | S_CTIME | S_VERSION);
- path_put(&path);
+ if (!kern_path(device_path, LOOKUP_FOLLOW, &path)) {
+ vfs_utimes(&path, NULL);
+ path_put(&path);
+ }
}
static int btrfs_rm_dev_item(struct btrfs_trans_handle *trans,
--
2.47.3
next prev parent reply other threads:[~2025-11-20 6:49 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-20 6:47 re-enable IOCB_NOWAIT writes to files v2 Christoph Hellwig
2025-11-20 6:47 ` [PATCH 01/16] fs: refactor file timestamp update logic Christoph Hellwig
2025-11-20 6:47 ` [PATCH 02/16] fs: lift the FMODE_NOCMTIME check into file_update_time_flags Christoph Hellwig
2025-11-20 6:47 ` [PATCH 03/16] fs: export vfs_utimes Christoph Hellwig
2025-11-20 6:47 ` Christoph Hellwig [this message]
2025-11-20 6:47 ` [PATCH 05/16] btrfs: fix the comment on btrfs_update_time Christoph Hellwig
2025-11-20 6:47 ` [PATCH 06/16] orangefs: use inode_update_timestamps directly Christoph Hellwig
2025-11-20 6:47 ` [PATCH 07/16] fs: remove inode_update_time Christoph Hellwig
2025-11-20 6:47 ` [PATCH 08/16] fs: allow error returns from generic_update_time Christoph Hellwig
2025-11-20 6:47 ` [PATCH 09/16] fs: exit early in generic_update_time when there is no work Christoph Hellwig
2025-11-20 13:32 ` Jeff Layton
2025-11-20 6:47 ` [PATCH 10/16] fs: factor out a mark_inode_dirty_time helper Christoph Hellwig
2025-11-20 6:47 ` [PATCH 11/16] fs: allow error returns from inode_update_timestamps Christoph Hellwig
2025-11-20 14:01 ` Jeff Layton
2025-11-20 6:47 ` [PATCH 12/16] fs: factor out a sync_lazytime helper Christoph Hellwig
2025-11-20 6:47 ` [PATCH 13/16] fs: add a ->sync_lazytime method Christoph Hellwig
2025-11-20 6:47 ` [PATCH 14/16] fs: add support for non-blocking timestamp updates Christoph Hellwig
2025-11-20 6:47 ` [PATCH 15/16] xfs: implement ->sync_lazytime Christoph Hellwig
2025-11-20 6:47 ` [PATCH 16/16] xfs: enable non-blocking timestamp updates Christoph Hellwig
2025-11-20 14:16 ` Jeff Layton
2025-11-25 9:18 ` re-enable IOCB_NOWAIT writes to files v2 Christian Brauner
2025-11-25 11:14 ` Christoph Hellwig
2025-11-26 13:51 ` (subset) " Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251120064859.2911749-5-hch@lst.de \
--to=hch@lst.de \
--cc=brauner@kernel.org \
--cc=cem@kernel.org \
--cc=devel@lists.orangefs.org \
--cc=dsterba@suse.com \
--cc=gfs2@lists.linux.dev \
--cc=hubcap@omnibond.com \
--cc=io-uring@vger.kernel.org \
--cc=jack@suse.cz \
--cc=jlayton@kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=martin@omnibond.com \
--cc=shr@fb.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).