From: Christoph Hellwig <hch@lst.de>
To: Christian Brauner <brauner@kernel.org>
Cc: Al Viro <viro@zeniv.linux.org.uk>,
David Sterba <dsterba@suse.com>, Jan Kara <jack@suse.cz>,
Mike Marshall <hubcap@omnibond.com>,
Martin Brandenburg <martin@omnibond.com>,
Carlos Maiolino <cem@kernel.org>, Stefan Roesch <shr@fb.com>,
Jeff Layton <jlayton@kernel.org>,
linux-kernel@vger.kernel.org, linux-btrfs@vger.kernel.org,
linux-fsdevel@vger.kernel.org, gfs2@lists.linux.dev,
io-uring@vger.kernel.org, devel@lists.orangefs.org,
linux-unionfs@vger.kernel.org, linux-mtd@lists.infradead.org,
linux-xfs@vger.kernel.org, linux-nfs@vger.kernel.org,
Chaitanya Kulkarni <kch@nvidia.com>
Subject: [PATCH 07/16] fs: remove inode_update_time
Date: Thu, 20 Nov 2025 07:47:28 +0100 [thread overview]
Message-ID: <20251120064859.2911749-8-hch@lst.de> (raw)
In-Reply-To: <20251120064859.2911749-1-hch@lst.de>
The only external user is gone now, open code it in the two VFS
callers.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
Reviewed-by: Jeff Layton <jlayton@kernel.org>
---
fs/inode.c | 23 ++++++++---------------
include/linux/fs.h | 1 -
2 files changed, 8 insertions(+), 16 deletions(-)
diff --git a/fs/inode.c b/fs/inode.c
index 2c55ec49b023..6e7e42915376 100644
--- a/fs/inode.c
+++ b/fs/inode.c
@@ -2119,19 +2119,6 @@ int generic_update_time(struct inode *inode, int flags)
}
EXPORT_SYMBOL(generic_update_time);
-/*
- * This does the actual work of updating an inodes time or version. Must have
- * had called mnt_want_write() before calling this.
- */
-int inode_update_time(struct inode *inode, int flags)
-{
- if (inode->i_op->update_time)
- return inode->i_op->update_time(inode, flags);
- generic_update_time(inode, flags);
- return 0;
-}
-EXPORT_SYMBOL(inode_update_time);
-
/**
* atime_needs_update - update the access time
* @path: the &struct path to update
@@ -2199,7 +2186,10 @@ void touch_atime(const struct path *path)
* We may also fail on filesystems that have the ability to make parts
* of the fs read only, e.g. subvolumes in Btrfs.
*/
- inode_update_time(inode, S_ATIME);
+ if (inode->i_op->update_time)
+ inode->i_op->update_time(inode, S_ATIME);
+ else
+ generic_update_time(inode, S_ATIME);
mnt_put_write_access(mnt);
skip_update:
sb_end_write(inode->i_sb);
@@ -2354,7 +2344,10 @@ static int file_update_time_flags(struct file *file, unsigned int flags)
if (mnt_get_write_access_file(file))
return 0;
- ret = inode_update_time(inode, sync_mode);
+ if (inode->i_op->update_time)
+ ret = inode->i_op->update_time(inode, sync_mode);
+ else
+ ret = generic_update_time(inode, sync_mode);
mnt_put_write_access_file(file);
return ret;
}
diff --git a/include/linux/fs.h b/include/linux/fs.h
index dd3b57cfadee..b54d300285b0 100644
--- a/include/linux/fs.h
+++ b/include/linux/fs.h
@@ -2665,7 +2665,6 @@ enum file_time_flags {
extern bool atime_needs_update(const struct path *, struct inode *);
extern void touch_atime(const struct path *);
-int inode_update_time(struct inode *inode, int flags);
static inline void file_accessed(struct file *file)
{
--
2.47.3
next prev parent reply other threads:[~2025-11-20 6:50 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-20 6:47 re-enable IOCB_NOWAIT writes to files v2 Christoph Hellwig
2025-11-20 6:47 ` [PATCH 01/16] fs: refactor file timestamp update logic Christoph Hellwig
2025-11-20 6:47 ` [PATCH 02/16] fs: lift the FMODE_NOCMTIME check into file_update_time_flags Christoph Hellwig
2025-11-20 6:47 ` [PATCH 03/16] fs: export vfs_utimes Christoph Hellwig
2025-11-20 6:47 ` [PATCH 04/16] btrfs: use vfs_utimes to update file timestamps Christoph Hellwig
2025-11-20 6:47 ` [PATCH 05/16] btrfs: fix the comment on btrfs_update_time Christoph Hellwig
2025-11-20 6:47 ` [PATCH 06/16] orangefs: use inode_update_timestamps directly Christoph Hellwig
2025-11-20 6:47 ` Christoph Hellwig [this message]
2025-11-20 6:47 ` [PATCH 08/16] fs: allow error returns from generic_update_time Christoph Hellwig
2025-11-20 6:47 ` [PATCH 09/16] fs: exit early in generic_update_time when there is no work Christoph Hellwig
2025-11-20 13:32 ` Jeff Layton
2025-11-20 6:47 ` [PATCH 10/16] fs: factor out a mark_inode_dirty_time helper Christoph Hellwig
2025-11-20 6:47 ` [PATCH 11/16] fs: allow error returns from inode_update_timestamps Christoph Hellwig
2025-11-20 14:01 ` Jeff Layton
2025-11-20 6:47 ` [PATCH 12/16] fs: factor out a sync_lazytime helper Christoph Hellwig
2025-11-20 6:47 ` [PATCH 13/16] fs: add a ->sync_lazytime method Christoph Hellwig
2025-11-20 6:47 ` [PATCH 14/16] fs: add support for non-blocking timestamp updates Christoph Hellwig
2025-11-20 6:47 ` [PATCH 15/16] xfs: implement ->sync_lazytime Christoph Hellwig
2025-11-20 6:47 ` [PATCH 16/16] xfs: enable non-blocking timestamp updates Christoph Hellwig
2025-11-20 14:16 ` Jeff Layton
2025-11-25 9:18 ` re-enable IOCB_NOWAIT writes to files v2 Christian Brauner
2025-11-25 11:14 ` Christoph Hellwig
2025-11-26 13:51 ` (subset) " Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251120064859.2911749-8-hch@lst.de \
--to=hch@lst.de \
--cc=brauner@kernel.org \
--cc=cem@kernel.org \
--cc=devel@lists.orangefs.org \
--cc=dsterba@suse.com \
--cc=gfs2@lists.linux.dev \
--cc=hubcap@omnibond.com \
--cc=io-uring@vger.kernel.org \
--cc=jack@suse.cz \
--cc=jlayton@kernel.org \
--cc=kch@nvidia.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=martin@omnibond.com \
--cc=shr@fb.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).