linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Chuck Lever <chuck.lever@oracle.com>
Cc: Christoph Hellwig <hch@lst.de>, Dai Ngo <dai.ngo@oracle.com>,
	jlayton@kernel.org, neilb@ownmail.net, okorniev@redhat.com,
	tom@talpey.com, alex.aring@gmail.com, viro@zeniv.linux.org.uk,
	brauner@kernel.org, jack@suse.cz, linux-fsdevel@vger.kernel.org,
	linux-nfs@vger.kernel.org
Subject: Re: [PATCH v4 3/3] FSD: Fix NFS server hang when there are multiple layout conflicts
Date: Thu, 20 Nov 2025 07:59:40 +0100	[thread overview]
Message-ID: <20251120065940.GA30524@lst.de> (raw)
In-Reply-To: <dc1e0443-5112-4a5d-9b3c-294e32ab7ed4@oracle.com>

On Wed, Nov 19, 2025 at 09:09:04AM -0500, Chuck Lever wrote:
> On 11/19/25 5:05 AM, Christoph Hellwig wrote:
> > On Mon, Nov 17, 2025 at 11:40:22AM -0800, Dai Ngo wrote:
> >>> If a .fence_client callback is optional for a layout to provide,
> >>> timeouts for such layout types won't trigger any fencing action. I'm not
> >>> certain yet that's good behavior.
> >>
> >> Some layout implementation is in experimental state such as block
> >> layout and should not be used in production environment. I don't
> >> know what should we do for that case. Does adding a trace point to
> >> warn the user sufficient?
> > 
> > The block layout isn't really experimental, but really a broken protocol
> > because there is no way to even fence a client except when there is
> > a side channel mapping between the client identities for NFS and the
> > storage protocol.
> 
> Is the protocol broken, or just incomplete, assuming that other
> (unspecified) protocols are necessary to be provided?

I guess it depends on your definition.  There is no shared client
identify between NFS and the storage protocol.  So you need a side
channel communication protocol such as sneakernet to register the
client identities on the server.  And that even assumes you have
a fencing method at that level, which often might not be the case.


  parent reply	other threads:[~2025-11-20  6:59 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-15 19:16 [Patch v4 0/3] NFSD: Fix server hang when there are multiple layout conflicts Dai Ngo
2025-11-15 19:16 ` [PATCH v4 1/3] locks: Introduce lm_breaker_timedout operation to lease_manager_operations Dai Ngo
2025-11-17 15:39   ` Chuck Lever
2025-11-17 19:17     ` Dai Ngo
2025-11-17 18:02   ` Jeff Layton
2025-11-17 19:41     ` Dai Ngo
2025-11-19 13:52       ` Jeff Layton
2025-11-19 16:32         ` Dai Ngo
2025-11-19  9:54   ` Christoph Hellwig
2025-11-19 14:04     ` Chuck Lever
2025-11-15 19:16 ` [PATCH v4 2/3] locks: Threads with layout conflict must wait until client was fenced Dai Ngo
2025-11-17 15:47   ` Chuck Lever
2025-11-17 19:21     ` Dai Ngo
2025-11-17 18:21   ` Jeff Layton
2025-11-17 19:49     ` Dai Ngo
2025-11-19  9:53     ` Christoph Hellwig
2025-11-15 19:16 ` [PATCH v4 3/3] FSD: Fix NFS server hang when there are multiple layout conflicts Dai Ngo
2025-11-15 19:44   ` Chuck Lever
2025-11-15 20:20     ` Dai Ngo
2025-11-19  9:56       ` Christoph Hellwig
2025-11-19 16:35         ` Dai Ngo
2025-11-17 15:55   ` Chuck Lever
2025-11-17 19:40     ` Dai Ngo
2025-11-17 21:13       ` Benjamin Coddington
2025-11-17 22:00         ` Dai Ngo
2025-11-19 10:08           ` Christoph Hellwig
2025-11-19 16:52             ` Dai Ngo
2025-11-20  6:50               ` Christoph Hellwig
2025-11-19 10:05       ` Christoph Hellwig
2025-11-19 14:04         ` Benjamin Coddington
2025-11-19 14:09         ` Chuck Lever
2025-11-19 14:12           ` Jeff Layton
2025-11-19 17:06           ` Dai Ngo
2025-11-20  6:52             ` Christoph Hellwig
2025-11-20  6:59           ` Christoph Hellwig [this message]
2025-11-19  9:57     ` Christoph Hellwig
2025-11-19 10:08   ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251120065940.GA30524@lst.de \
    --to=hch@lst.de \
    --cc=alex.aring@gmail.com \
    --cc=brauner@kernel.org \
    --cc=chuck.lever@oracle.com \
    --cc=dai.ngo@oracle.com \
    --cc=jack@suse.cz \
    --cc=jlayton@kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=neilb@ownmail.net \
    --cc=okorniev@redhat.com \
    --cc=tom@talpey.com \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).