From: Christoph Hellwig <hch@lst.de>
To: Eric Biggers <ebiggers@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>,
"Theodore Y. Ts'o" <tytso@mit.edu>,
Jaegeuk Kim <jaegeuk@kernel.org>,
Andreas Dilger <adilger.kernel@dilger.ca>,
Chao Yu <chao@kernel.org>, Christian Brauner <brauner@kernel.org>,
"Darrick J. Wong" <djwong@kernel.org>,
linux-fscrypt@vger.kernel.org, linux-ext4@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 04/11] fscrypt: pass a byte offset to fscrypt_mergeable_bio
Date: Mon, 24 Nov 2025 15:16:21 +0100 [thread overview]
Message-ID: <20251124141621.GC14417@lst.de> (raw)
In-Reply-To: <20251122181717.GA1626@quark>
On Sat, Nov 22, 2025 at 10:17:17AM -0800, Eric Biggers wrote:
> On Tue, Nov 18, 2025 at 07:21:47AM +0100, Christoph Hellwig wrote:
> > diff --git a/fs/crypto/inline_crypt.c b/fs/crypto/inline_crypt.c
> > index 1773dd7ea7cf..aba830e0827d 100644
> > --- a/fs/crypto/inline_crypt.c
> > +++ b/fs/crypto/inline_crypt.c
> > @@ -361,7 +361,7 @@ EXPORT_SYMBOL_GPL(fscrypt_set_bio_crypt_ctx_bh);
> > * fscrypt_mergeable_bio() - test whether data can be added to a bio
> > * @bio: the bio being built up
> > * @inode: the inode for the next part of the I/O
> > - * @next_lblk: the next file logical block number in the I/O
> > + * @pos: the next file logical offset (in bytes) in the I/O
>
> In comments, maybe call it a "file position" instead of "file logical
> offset" to match the variable name?
Doing a quick grep, "file offset" seems to be a bit more than twice
as common as "file position" in the kernel. Logical offset, even
without file is barely used. So I think "file offset' might be best
here, but if you prefer "file position" I can switch to that as well.
next prev parent reply other threads:[~2025-11-24 14:16 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-18 6:21 fscrypt API cleanups Christoph Hellwig
2025-11-18 6:21 ` [PATCH 01/11] fscrypt: pass a real sector_t to fscrypt_zeroout_range_inline_crypt Christoph Hellwig
2025-11-18 6:21 ` [PATCH 02/11] fscrypt: keep multiple bios in flight in fscrypt_zeroout_range_inline_crypt Christoph Hellwig
2025-11-18 6:21 ` [PATCH 03/11] fscrypt: pass a byte offset to fscrypt_generate_dun Christoph Hellwig
2025-11-18 6:21 ` [PATCH 04/11] fscrypt: pass a byte offset to fscrypt_mergeable_bio Christoph Hellwig
2025-11-22 18:17 ` Eric Biggers
2025-11-24 14:16 ` Christoph Hellwig [this message]
2025-11-18 6:21 ` [PATCH 05/11] fscrypt: pass a byte offset to fscrypt_set_bio_crypt_ctx Christoph Hellwig
2025-11-18 6:21 ` [PATCH 06/11] fscrypt: pass a byte offset to fscrypt_zeroout_range_inline_crypt Christoph Hellwig
2025-11-18 6:21 ` [PATCH 07/11] fscrypt: pass a byte length " Christoph Hellwig
2025-11-18 6:21 ` [PATCH 08/11] fscrypt: return a byte offset from bh_get_inode_and_lblk_num Christoph Hellwig
2025-11-22 18:19 ` Eric Biggers
2025-11-18 6:21 ` [PATCH 09/11] fscrypt: pass a byte offset to fscrypt_zeroout_range Christoph Hellwig
2025-11-18 6:21 ` [PATCH 10/11] fscrypt: pass a byte length " Christoph Hellwig
2025-11-22 18:29 ` Eric Biggers
2025-11-24 14:17 ` Christoph Hellwig
2025-11-18 6:21 ` [PATCH 11/11] fscrypt: pass a real sector_t " Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251124141621.GC14417@lst.de \
--to=hch@lst.de \
--cc=adilger.kernel@dilger.ca \
--cc=brauner@kernel.org \
--cc=chao@kernel.org \
--cc=djwong@kernel.org \
--cc=ebiggers@kernel.org \
--cc=jaegeuk@kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fscrypt@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).