From: Christoph Hellwig <hch@lst.de>
To: Eric Biggers <ebiggers@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>,
"Theodore Y. Ts'o" <tytso@mit.edu>,
Jaegeuk Kim <jaegeuk@kernel.org>,
Andreas Dilger <adilger.kernel@dilger.ca>,
Chao Yu <chao@kernel.org>, Christian Brauner <brauner@kernel.org>,
"Darrick J. Wong" <djwong@kernel.org>,
linux-fscrypt@vger.kernel.org, linux-ext4@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 10/11] fscrypt: pass a byte length to fscrypt_zeroout_range
Date: Mon, 24 Nov 2025 15:17:50 +0100 [thread overview]
Message-ID: <20251124141750.GD14417@lst.de> (raw)
In-Reply-To: <20251122182926.GC1626@quark>
On Sat, Nov 22, 2025 at 10:29:26AM -0800, Eric Biggers wrote:
> The type of 'len' is still unsigned int, so this reduces the maximum
> length accepted by fscrypt_zeroout_range() from UINT32_MAX blocks to
> UINT32_MAX bytes. Is that really okay?
Linus has limited Linux's read/write I/O sizes to a signed integer,
even if size_t/ssize_t could be larger. We have internal support
to do a few things larger, so there would be precedence to support a
64-bit value and I'd be happy siwtch over to that.
next prev parent reply other threads:[~2025-11-24 14:17 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-18 6:21 fscrypt API cleanups Christoph Hellwig
2025-11-18 6:21 ` [PATCH 01/11] fscrypt: pass a real sector_t to fscrypt_zeroout_range_inline_crypt Christoph Hellwig
2025-11-18 6:21 ` [PATCH 02/11] fscrypt: keep multiple bios in flight in fscrypt_zeroout_range_inline_crypt Christoph Hellwig
2025-11-18 6:21 ` [PATCH 03/11] fscrypt: pass a byte offset to fscrypt_generate_dun Christoph Hellwig
2025-11-18 6:21 ` [PATCH 04/11] fscrypt: pass a byte offset to fscrypt_mergeable_bio Christoph Hellwig
2025-11-22 18:17 ` Eric Biggers
2025-11-24 14:16 ` Christoph Hellwig
2025-11-18 6:21 ` [PATCH 05/11] fscrypt: pass a byte offset to fscrypt_set_bio_crypt_ctx Christoph Hellwig
2025-11-18 6:21 ` [PATCH 06/11] fscrypt: pass a byte offset to fscrypt_zeroout_range_inline_crypt Christoph Hellwig
2025-11-18 6:21 ` [PATCH 07/11] fscrypt: pass a byte length " Christoph Hellwig
2025-11-18 6:21 ` [PATCH 08/11] fscrypt: return a byte offset from bh_get_inode_and_lblk_num Christoph Hellwig
2025-11-22 18:19 ` Eric Biggers
2025-11-18 6:21 ` [PATCH 09/11] fscrypt: pass a byte offset to fscrypt_zeroout_range Christoph Hellwig
2025-11-18 6:21 ` [PATCH 10/11] fscrypt: pass a byte length " Christoph Hellwig
2025-11-22 18:29 ` Eric Biggers
2025-11-24 14:17 ` Christoph Hellwig [this message]
2025-11-18 6:21 ` [PATCH 11/11] fscrypt: pass a real sector_t " Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251124141750.GD14417@lst.de \
--to=hch@lst.de \
--cc=adilger.kernel@dilger.ca \
--cc=brauner@kernel.org \
--cc=chao@kernel.org \
--cc=djwong@kernel.org \
--cc=ebiggers@kernel.org \
--cc=jaegeuk@kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fscrypt@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).