From: Zhang Yi <yi.zhang@huaweicloud.com>
To: linux-ext4@vger.kernel.org
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
tytso@mit.edu, adilger.kernel@dilger.ca, jack@suse.cz,
ojaswin@linux.ibm.com, yi.zhang@huawei.com,
yi.zhang@huaweicloud.com, yizhang089@gmail.com,
libaokun1@huawei.com, yangerkun@huawei.com
Subject: [PATCH v3 09/14] ext4: cleanup useless out label in __es_remove_extent()
Date: Sat, 29 Nov 2025 18:32:41 +0800 [thread overview]
Message-ID: <20251129103247.686136-10-yi.zhang@huaweicloud.com> (raw)
In-Reply-To: <20251129103247.686136-1-yi.zhang@huaweicloud.com>
From: Zhang Yi <yi.zhang@huawei.com>
The out label in __es_remove_extent() is just return err value, we can
return it directly if something bad happens. Therefore, remove the
useless out label and rename out_get_reserved to out.
Signed-off-by: Zhang Yi <yi.zhang@huawei.com>
Reviewed-by: Jan Kara <jack@suse.cz>
Reviewed-by: Ojaswin Mujoo <ojaswin@linux.ibm.com>
Reviewed-by: Baokun Li <libaokun1@huawei.com>
---
fs/ext4/extents_status.c | 15 +++++++--------
1 file changed, 7 insertions(+), 8 deletions(-)
diff --git a/fs/ext4/extents_status.c b/fs/ext4/extents_status.c
index e04fbf10fe4f..04d56f8f6c0c 100644
--- a/fs/ext4/extents_status.c
+++ b/fs/ext4/extents_status.c
@@ -1434,7 +1434,7 @@ static int __es_remove_extent(struct inode *inode, ext4_lblk_t lblk,
struct extent_status orig_es;
ext4_lblk_t len1, len2;
ext4_fsblk_t block;
- int err = 0;
+ int err;
bool count_reserved = true;
struct rsvd_count rc;
@@ -1443,9 +1443,9 @@ static int __es_remove_extent(struct inode *inode, ext4_lblk_t lblk,
es = __es_tree_search(&tree->root, lblk);
if (!es)
- goto out;
+ return 0;
if (es->es_lblk > end)
- goto out;
+ return 0;
/* Simply invalidate cache_es. */
tree->cache_es = NULL;
@@ -1480,7 +1480,7 @@ static int __es_remove_extent(struct inode *inode, ext4_lblk_t lblk,
es->es_lblk = orig_es.es_lblk;
es->es_len = orig_es.es_len;
- goto out;
+ return err;
}
} else {
es->es_lblk = end + 1;
@@ -1494,7 +1494,7 @@ static int __es_remove_extent(struct inode *inode, ext4_lblk_t lblk,
if (count_reserved)
count_rsvd(inode, orig_es.es_lblk + len1,
orig_es.es_len - len1 - len2, &orig_es, &rc);
- goto out_get_reserved;
+ goto out;
}
if (len1 > 0) {
@@ -1536,11 +1536,10 @@ static int __es_remove_extent(struct inode *inode, ext4_lblk_t lblk,
}
}
-out_get_reserved:
+out:
if (count_reserved)
*reserved = get_rsvd(inode, end, es, &rc);
-out:
- return err;
+ return 0;
}
/*
--
2.46.1
next prev parent reply other threads:[~2025-11-29 10:35 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-29 10:32 [PATCH v3 00/14] ext4: replace ext4_es_insert_extent() when caching on-disk extents Zhang Yi
2025-11-29 10:32 ` [PATCH v3 01/14] ext4: subdivide EXT4_EXT_DATA_VALID1 Zhang Yi
2025-11-29 10:32 ` [PATCH v3 02/14] ext4: don't zero the entire extent if EXT4_EXT_DATA_PARTIAL_VALID1 Zhang Yi
2025-11-29 10:32 ` [PATCH v3 03/14] ext4: don't set EXT4_GET_BLOCKS_CONVERT when splitting before submitting I/O Zhang Yi
2025-11-29 10:32 ` [PATCH v3 04/14] ext4: correct the mapping status if the extent has been zeroed Zhang Yi
2025-11-29 10:32 ` [PATCH v3 05/14] ext4: don't cache extent during splitting extent Zhang Yi
2025-11-29 10:32 ` [PATCH v3 06/14] ext4: drop extent cache after doing PARTIAL_VALID1 zeroout Zhang Yi
2025-11-29 17:33 ` Ojaswin Mujoo
2025-11-29 10:32 ` [PATCH v3 07/14] ext4: drop extent cache when splitting extent fails Zhang Yi
2025-11-29 17:34 ` Ojaswin Mujoo
2025-11-29 10:32 ` [PATCH v3 08/14] ext4: cleanup zeroout in ext4_split_extent_at() Zhang Yi
2025-11-29 10:32 ` Zhang Yi [this message]
2025-11-29 10:32 ` [PATCH v3 10/14] ext4: make __es_remove_extent() check extent status Zhang Yi
2025-11-29 10:32 ` [PATCH v3 11/14] ext4: make ext4_es_cache_extent() support overwrite existing extents Zhang Yi
2025-11-29 10:32 ` [PATCH v3 12/14] ext4: adjust the debug info in ext4_es_cache_extent() Zhang Yi
2025-11-29 10:32 ` [PATCH v3 13/14] ext4: replace ext4_es_insert_extent() when caching on-disk extents Zhang Yi
2025-11-29 10:32 ` [PATCH v3 14/14] ext4: drop the TODO comment in ext4_es_insert_extent() Zhang Yi
2025-12-01 16:23 ` [PATCH v3 00/14] ext4: replace ext4_es_insert_extent() when caching on-disk extents Theodore Ts'o
2025-12-01 16:42 ` Theodore Tso
2025-12-02 1:15 ` Zhang Yi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251129103247.686136-10-yi.zhang@huaweicloud.com \
--to=yi.zhang@huaweicloud.com \
--cc=adilger.kernel@dilger.ca \
--cc=jack@suse.cz \
--cc=libaokun1@huawei.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ojaswin@linux.ibm.com \
--cc=tytso@mit.edu \
--cc=yangerkun@huawei.com \
--cc=yi.zhang@huawei.com \
--cc=yizhang089@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).