From: Christian Brauner <brauner@kernel.org>
To: syzbot+40f42779048f7476e2e0@syzkaller.appspotmail.com,
Edward Adam Davis <eadavis@qq.com>
Cc: Christian Brauner <brauner@kernel.org>,
jack@suse.cz, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com,
viro@zeniv.linux.org.uk
Subject: Re: [PATCH] mqueue: correct the type of ro to int
Date: Fri, 5 Dec 2025 09:55:28 +0100 [thread overview]
Message-ID: <20251205-abberufen-rabiat-4288544a76ad@brauner> (raw)
In-Reply-To: <tencent_369728EA76ED36CD98793A6D942C956C4C0A@qq.com>
On Thu, 04 Dec 2025 21:16:22 +0800, Edward Adam Davis wrote:
> The ro variable, being of type bool, caused the -EROFS return value from
> mnt_want_write() to be implicitly converted to 1. This prevented the file
> from being correctly acquired, thus triggering the issue reported by
> syzbot [1].
>
> Changing the type of ro to int allows the system to correctly identify
> the reason for the file open failure.
>
> [...]
Applied to the vfs.fixes branch of the vfs/vfs.git tree.
Patches in the vfs.fixes branch should appear in linux-next soon.
Please report any outstanding bugs that were missed during review in a
new review to the original patch series allowing us to drop it.
It's encouraged to provide Acked-bys and Reviewed-bys even though the
patch has now been applied. If possible patch trailers will be updated.
Note that commit hashes shown below are subject to change due to rebase,
trailer updates or similar. If in doubt, please check the listed branch.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
branch: vfs.fixes
[1/1] mqueue: correct the type of ro to int
https://git.kernel.org/vfs/vfs/c/1d98eeadbc10
prev parent reply other threads:[~2025-12-05 8:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-04 9:49 [syzbot] [fs?] general protection fault in fd_install syzbot
2025-12-04 13:16 ` [PATCH] mqueue: correct the type of ro to int Edward Adam Davis
2025-12-04 14:07 ` Jan Kara
2025-12-05 8:55 ` Christian Brauner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251205-abberufen-rabiat-4288544a76ad@brauner \
--to=brauner@kernel.org \
--cc=eadavis@qq.com \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=syzbot+40f42779048f7476e2e0@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).