* [PATCH] xfstests: hfs/hfsplus don't support metadata journaling
@ 2026-01-06 23:35 Viacheslav Dubeyko
2026-01-18 18:05 ` Zorro Lang
0 siblings, 1 reply; 2+ messages in thread
From: Viacheslav Dubeyko @ 2026-01-06 23:35 UTC (permalink / raw)
To: glaubitz, linux-fsdevel, frank.li, fstests, zlang
Cc: Slava.Dubeyko, Viacheslav Dubeyko
HFS file system doesn't support metadata journaling.
This patch marks HFS file system as not supporting
metadata journaling in _has_metadata_journaling()
of common/rc.
Technically speaking, HFS+ is journaling file system.
However, current Linux kernel implementation doesn't
support even journal replay. This patch marks HFS+ file
system as not supporting metadata journaling in
_has_metadata_journaling() of common/rc. If journaling
support functionality in HFS+ will be implemented,
then HFS+ could be deleted from _has_metadata_journaling()
in the future.
Signed-off-by: Viacheslav Dubeyko <slava@dubeyko.com>
---
common/rc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/common/rc b/common/rc
index c3cdc220..82491935 100644
--- a/common/rc
+++ b/common/rc
@@ -4267,7 +4267,7 @@ _has_metadata_journaling()
fi
case "$FSTYP" in
- ext2|vfat|msdos|udf|exfat|tmpfs)
+ ext2|vfat|msdos|udf|exfat|tmpfs|hfs|hfsplus)
echo "$FSTYP does not support metadata journaling"
return 1
;;
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] xfstests: hfs/hfsplus don't support metadata journaling
2026-01-06 23:35 [PATCH] xfstests: hfs/hfsplus don't support metadata journaling Viacheslav Dubeyko
@ 2026-01-18 18:05 ` Zorro Lang
0 siblings, 0 replies; 2+ messages in thread
From: Zorro Lang @ 2026-01-18 18:05 UTC (permalink / raw)
To: Viacheslav Dubeyko
Cc: glaubitz, linux-fsdevel, frank.li, fstests, zlang, Slava.Dubeyko
On Tue, Jan 06, 2026 at 03:35:56PM -0800, Viacheslav Dubeyko wrote:
> HFS file system doesn't support metadata journaling.
> This patch marks HFS file system as not supporting
> metadata journaling in _has_metadata_journaling()
> of common/rc.
>
> Technically speaking, HFS+ is journaling file system.
> However, current Linux kernel implementation doesn't
> support even journal replay. This patch marks HFS+ file
> system as not supporting metadata journaling in
> _has_metadata_journaling() of common/rc. If journaling
> support functionality in HFS+ will be implemented,
> then HFS+ could be deleted from _has_metadata_journaling()
> in the future.
>
> Signed-off-by: Viacheslav Dubeyko <slava@dubeyko.com>
> ---
Good to me.
Reviewed-by: Zorro Lang <zlang@redhat.com>
> common/rc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/common/rc b/common/rc
> index c3cdc220..82491935 100644
> --- a/common/rc
> +++ b/common/rc
> @@ -4267,7 +4267,7 @@ _has_metadata_journaling()
> fi
>
> case "$FSTYP" in
> - ext2|vfat|msdos|udf|exfat|tmpfs)
> + ext2|vfat|msdos|udf|exfat|tmpfs|hfs|hfsplus)
> echo "$FSTYP does not support metadata journaling"
> return 1
> ;;
> --
> 2.43.0
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-01-18 18:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-06 23:35 [PATCH] xfstests: hfs/hfsplus don't support metadata journaling Viacheslav Dubeyko
2026-01-18 18:05 ` Zorro Lang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox