From: Al Viro <viro@zeniv.linux.org.uk>
To: Chuck Lever <cel@kernel.org>
Cc: NeilBrown <neil@brown.name>, Jeff Layton <jlayton@kernel.org>,
Olga Kornievskaia <okorniev@redhat.com>,
Dai Ngo <dai.ngo@oracle.com>, Tom Talpey <tom@talpey.com>,
linux-nfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Chuck Lever <chuck.lever@oracle.com>
Subject: Re: [PATCH v2 4/6] fs: invoke group_pin_kill() during mount teardown
Date: Sat, 10 Jan 2026 16:49:46 +0000 [thread overview]
Message-ID: <20260110164946.GD3634291@ZenIV> (raw)
In-Reply-To: <50610e1c-7f09-4840-b2b2-f211dd6cdd5f@app.fastmail.com>
On Fri, Jan 09, 2026 at 11:04:49AM -0500, Chuck Lever wrote:
> Jeff mentioned to me privately that the fs_pin API may be deprecated,
> with its sole current consumer (BSD process accounting) destined for
> removal. I'm waiting for VFS maintainer review for confirmation on
> that before deciding how to address your comment. If fs_pin is indeed
> going away, building new NFSD infrastructure on top of it would be
> unwise, and we'll have to consider a shift in direction.
FWIW, fs_pin had never been a good API and experiments with using it
for core stuff had failed - we ended up with dput_to_list() and teaching
shrink lists to DTRT with mixed-fs lists instead.
TBH, I'd rather not see it growing more users. Said that, more serious
problem is that you are mixing per-mount and per-fs things here.
Could you go over the objects you need to deal with? What needs to be
hidden from the normal "mount busy" logics and revoked when a mount goes
away?
Opened files are obvious, but what about e.g. write count?
next prev parent reply other threads:[~2026-01-10 16:48 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-08 0:40 [PATCH v2 0/6] Automatic NFSv4 state revocation on filesystem unmount Chuck Lever
2026-01-08 0:40 ` [PATCH v2 1/6] nfsd: cancel async COPY operations when admin revokes filesystem state Chuck Lever
2026-01-08 0:40 ` [PATCH v2 2/6] fs: export pin_insert and pin_remove for modular filesystems Chuck Lever
2026-01-08 0:40 ` [PATCH v2 3/6] fs: add pin_insert_sb() for superblock-only pins Chuck Lever
2026-01-08 0:40 ` [PATCH v2 4/6] fs: invoke group_pin_kill() during mount teardown Chuck Lever
2026-01-09 8:38 ` NeilBrown
2026-01-09 16:04 ` Chuck Lever
2026-01-10 16:49 ` Al Viro [this message]
2026-01-10 20:07 ` Chuck Lever
2026-01-10 21:52 ` NeilBrown
2026-01-10 22:08 ` Al Viro
2026-01-10 22:31 ` Chuck Lever
2026-01-08 0:40 ` [PATCH v2 5/6] nfsd: revoke NFSv4 state when filesystem is unmounted Chuck Lever
2026-01-09 9:06 ` NeilBrown
2026-01-08 0:40 ` [PATCH v2 6/6] nfsd: close cached files on filesystem unmount Chuck Lever
2026-01-09 16:25 ` [PATCH v2 0/6] Automatic NFSv4 state revocation " Jeff Layton
2026-01-12 9:16 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260110164946.GD3634291@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=cel@kernel.org \
--cc=chuck.lever@oracle.com \
--cc=dai.ngo@oracle.com \
--cc=jlayton@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=neil@brown.name \
--cc=okorniev@redhat.com \
--cc=tom@talpey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox