Re: [PATCH v2 12/22] xfs: introduce XFS_FSVERITY_CONSTRUCTION inode flag

["Darrick J. Wong" <djwong@kernel.org>]

On Mon, Jan 12, 2026 at 03:51:16PM +0100, Andrey Albershteyn wrote:
> Add new flag meaning that merkle tree is being build on the inode.
> 
> Signed-off-by: Andrey Albershteyn <aalbersh@kernel.org>

Seems fine to me, with one nit below
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>

--D

> ---
>  fs/xfs/xfs_inode.h | 6 ++++++
>  1 file changed, 6 insertions(+), 0 deletions(-)
> 
> diff --git a/fs/xfs/xfs_inode.h b/fs/xfs/xfs_inode.h
> index f149cb1eb5..9373bf146a 100644
> --- a/fs/xfs/xfs_inode.h
> +++ b/fs/xfs/xfs_inode.h
> @@ -420,6 +420,12 @@
>   */
>  #define XFS_IREMAPPING		(1U << 15)
>  
> +/*
> + * fs-verity's Merkle tree is under construction. The file is read-only, the
> + * only writes happening is the ones with Merkle tree blocks.

"..the only writes happening are for the fsverity metadata."

since fsverity could in theory someday write more than just a merkle
tree and a descriptor.

--D

> + */
> +#define XFS_VERITY_CONSTRUCTION	(1U << 16)
> +
>  /* All inode state flags related to inode reclaim. */
>  #define XFS_ALL_IRECLAIM_FLAGS	(XFS_IRECLAIMABLE | \
>  				 XFS_IRECLAIM | \
> 
> -- 
> - Andrey
> 
>