public inbox for linux-fsdevel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Darrick J. Wong" <djwong@kernel.org>
To: Chuck Lever <cel@kernel.org>
Cc: vira@web.codeaurora.org, Christian Brauner <brauner@kernel.org>,
	Jan Kara <jack@suse.cz>,
	linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org,
	linux-xfs@vger.kernel.org, linux-cifs@vger.kernel.org,
	linux-nfs@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net,
	hirofumi@mail.parknet.co.jp, linkinjeon@kernel.org,
	sj1557.seo@samsung.com, yuezhang.mo@sony.com,
	almaz.alexandrovich@paragon-software.com, slava@dubeyko.com,
	glaubitz@physik.fu-berlin.de, frank.li@vivo.com, tytso@mit.edu,
	adilger.kernel@dilger.ca, cem@kernel.org, sfrench@samba.org,
	pc@manguebit.org, ronniesahlberg@gmail.com,
	sprasad@microsoft.com, trondmy@kernel.org, anna@kernel.org,
	jaegeuk@kernel.org, chao@kernel.org, hansg@kernel.org,
	senozhatsky@chromium.org, Chuck Lever <chuck.lever@oracle.com>,
	Neal Gompa <neal@gompa.dev>
Subject: Re: [PATCH v3 08/16] xfs: Report case sensitivity in fileattr_get
Date: Tue, 13 Jan 2026 08:02:23 -0800	[thread overview]
Message-ID: <20260113160223.GA15522@frogsfrogsfrogs> (raw)
In-Reply-To: <20260112174629.3729358-9-cel@kernel.org>

On Mon, Jan 12, 2026 at 12:46:21PM -0500, Chuck Lever wrote:
> From: Chuck Lever <chuck.lever@oracle.com>
> 
> Upper layers such as NFSD need to query whether a filesystem is
> case-sensitive. Populate the case_insensitive and case_preserving
> fields in xfs_fileattr_get(). XFS always preserves case. XFS is
> case-sensitive by default, but supports ASCII case-insensitive
> lookups when formatted with the ASCIICI feature flag.
> 
> Signed-off-by: Chuck Lever <chuck.lever@oracle.com>

Well as a pure binary statement of xfs' capabilities, this is correct so:
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>

[add ngompa]

But the next obvious question I would have as a userspace programmer is
"case insensitive how, exactly?", which was the topic of the previous
revision.  Somewhere out there there's a program / emulation layer that
will want to know the exact transformation when doing a non-memcmp
lookup.  Probably Winderz casefolding has behaved differently every
release since the start of NTFS, etc.

I don't know how to solve that, other than the fs compiles its
case-flattening code into a bpf program and exports that where someone
can read() it and run/analyze/reverse engineer it.  But ugh, Linus is
right that this area is a mess. :/

--D

> ---
>  fs/xfs/xfs_ioctl.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/fs/xfs/xfs_ioctl.c b/fs/xfs/xfs_ioctl.c
> index 59eaad774371..97314fcb7732 100644
> --- a/fs/xfs/xfs_ioctl.c
> +++ b/fs/xfs/xfs_ioctl.c
> @@ -516,6 +516,13 @@ xfs_fileattr_get(
>  	xfs_fill_fsxattr(ip, XFS_DATA_FORK, fa);
>  	xfs_iunlock(ip, XFS_ILOCK_SHARED);
>  
> +	/*
> +	 * XFS is case-sensitive by default, but can be formatted with
> +	 * ASCII case-insensitive mode enabled.
> +	 */
> +	fa->case_insensitive = xfs_has_asciici(ip->i_mount);
> +	fa->case_preserving = true;
> +
>  	return 0;
>  }
>  
> -- 
> 2.52.0
> 
> 

  reply	other threads:[~2026-01-13 16:02 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-12 17:46 [PATCH v3 00/16] Exposing case folding behavior Chuck Lever
2026-01-12 17:46 ` [PATCH v3 01/16] fs: Add case sensitivity info to file_kattr Chuck Lever
2026-01-13 15:21   ` Christoph Hellwig
2026-01-12 17:46 ` [PATCH v3 02/16] fat: Implement fileattr_get for case sensitivity Chuck Lever
2026-01-13 15:23   ` Christoph Hellwig
2026-01-12 17:46 ` [PATCH v3 03/16] exfat: " Chuck Lever
2026-01-14  0:45   ` Namjae Jeon
2026-01-12 17:46 ` [PATCH v3 04/16] ntfs3: " Chuck Lever
2026-01-12 17:46 ` [PATCH v3 05/16] hfs: " Chuck Lever
2026-01-13 17:35   ` Viacheslav Dubeyko
2026-01-12 17:46 ` [PATCH v3 06/16] hfsplus: Report case sensitivity in fileattr_get Chuck Lever
2026-01-13 17:36   ` Viacheslav Dubeyko
2026-01-12 17:46 ` [PATCH v3 07/16] ext4: " Chuck Lever
2026-01-13 11:50   ` Jan Kara
2026-01-12 17:46 ` [PATCH v3 08/16] xfs: " Chuck Lever
2026-01-13 16:02   ` Darrick J. Wong [this message]
2026-01-13 16:43     ` Neal Gompa
2026-01-12 17:46 ` [PATCH v3 09/16] cifs: Implement fileattr_get for case sensitivity Chuck Lever
2026-01-12 17:46 ` [PATCH v3 10/16] nfs: " Chuck Lever
2026-01-12 17:46 ` [PATCH v3 11/16] f2fs: Add case sensitivity reporting to fileattr_get Chuck Lever
2026-01-14  0:50   ` Chao Yu
2026-01-12 17:46 ` [PATCH v3 12/16] vboxsf: Implement fileattr_get for case sensitivity Chuck Lever
2026-01-12 17:46 ` [PATCH v3 13/16] isofs: " Chuck Lever
2026-01-13 11:50   ` Jan Kara
2026-01-12 17:46 ` [PATCH v3 14/16] nfsd: Report export case-folding via NFSv3 PATHCONF Chuck Lever
2026-01-12 17:46 ` [PATCH v3 15/16] nfsd: Implement NFSv4 FATTR4_CASE_INSENSITIVE and FATTR4_CASE_PRESERVING Chuck Lever
2026-01-12 17:46 ` [PATCH v3 16/16] ksmbd: Report filesystem case sensitivity via FS_ATTRIBUTE_INFORMATION Chuck Lever
2026-01-14  0:46   ` Namjae Jeon
2026-01-13  9:04 ` [PATCH v3 00/16] Exposing case folding behavior Christian Brauner
2026-01-13 13:58   ` Chuck Lever

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260113160223.GA15522@frogsfrogsfrogs \
    --to=djwong@kernel.org \
    --cc=adilger.kernel@dilger.ca \
    --cc=almaz.alexandrovich@paragon-software.com \
    --cc=anna@kernel.org \
    --cc=brauner@kernel.org \
    --cc=cel@kernel.org \
    --cc=cem@kernel.org \
    --cc=chao@kernel.org \
    --cc=chuck.lever@oracle.com \
    --cc=frank.li@vivo.com \
    --cc=glaubitz@physik.fu-berlin.de \
    --cc=hansg@kernel.org \
    --cc=hirofumi@mail.parknet.co.jp \
    --cc=jack@suse.cz \
    --cc=jaegeuk@kernel.org \
    --cc=linkinjeon@kernel.org \
    --cc=linux-cifs@vger.kernel.org \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=neal@gompa.dev \
    --cc=pc@manguebit.org \
    --cc=ronniesahlberg@gmail.com \
    --cc=senozhatsky@chromium.org \
    --cc=sfrench@samba.org \
    --cc=sj1557.seo@samsung.com \
    --cc=slava@dubeyko.com \
    --cc=sprasad@microsoft.com \
    --cc=trondmy@kernel.org \
    --cc=tytso@mit.edu \
    --cc=vira@web.codeaurora.org \
    --cc=yuezhang.mo@sony.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox