public inbox for linux-fsdevel@vger.kernel.org
 help / color / mirror / Atom feed
From: david.laight.linux@gmail.com
To: Christian Brauner <brauner@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Miklos Szeredi <miklos@szeredi.hu>,
	Mark Brown <broonie@kernel.org>,
	linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	Alexander Viro <viro@zeniv.linux.org.uk>,
	Andreas Dilger <adilger.kernel@dilger.ca>,
	Kees Cook <kees@kernel.org>,
	OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>,
	Theodore Ts'o <tytso@mit.edu>, Brian Masney <bmasney@redhat.com>
Cc: David Laight <david.laight.linux@gmail.com>
Subject: [PATCH next] fuse: Fix 'min: signedness error' in fuse_wr_pages()
Date: Tue, 13 Jan 2026 19:22:43 +0000	[thread overview]
Message-ID: <20260113192243.73983-1-david.laight.linux@gmail.com> (raw)

From: David Laight <david.laight.linux@gmail.com>

On 32bit systems 'pos' is s64 and everything else is 32bit so the
first argument to min() is signed - generating a warning.
On 64bit systems 'len' is 64bit unsigned forcing everything to unsigned.

Fix by reworking the exprssion to completely avoid 64bit maths on 32bit.
Use DIV_ROUND_UP() instead of open-coding something equivalent.

Note that the 32bit 'len' cannot overflow because the syscall interface
limits read/write (etc) to (INT_MAX - PAGE_SIZE) bytes (even on 64bit).

Fixes: 0f5bb0cfb0b4 ("fs: use min() or umin() instead of min_t()")
Signed-off-by: David Laight <david.laight.linux@gmail.com>
---
 fs/fuse/file.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/fuse/file.c b/fs/fuse/file.c
index 2595b6b4922b..ff823b0545ed 100644
--- a/fs/fuse/file.c
+++ b/fs/fuse/file.c
@@ -1323,8 +1323,8 @@ static ssize_t fuse_fill_write_pages(struct fuse_io_args *ia,
 static inline unsigned int fuse_wr_pages(loff_t pos, size_t len,
 				     unsigned int max_pages)
 {
-	return min(((pos + len - 1) >> PAGE_SHIFT) - (pos >> PAGE_SHIFT) + 1,
-		   max_pages);
+	len += pos % PAGE_SIZE;
+	return min(DIV_ROUND_UP(len, PAGE_SIZE), max_pages);
 }
 
 static ssize_t fuse_perform_write(struct kiocb *iocb, struct iov_iter *ii)
-- 
2.39.5


             reply	other threads:[~2026-01-13 19:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-13 19:22 david.laight.linux [this message]
2026-01-13 20:23 ` [PATCH next] fuse: Fix 'min: signedness error' in fuse_wr_pages() Brian Masney
2026-02-03  1:05 ` Nathan Chancellor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260113192243.73983-1-david.laight.linux@gmail.com \
    --to=david.laight.linux@gmail.com \
    --cc=adilger.kernel@dilger.ca \
    --cc=akpm@linux-foundation.org \
    --cc=bmasney@redhat.com \
    --cc=brauner@kernel.org \
    --cc=broonie@kernel.org \
    --cc=hirofumi@mail.parknet.co.jp \
    --cc=kees@kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=miklos@szeredi.hu \
    --cc=tytso@mit.edu \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox