From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f51.google.com (mail-ej1-f51.google.com [209.85.218.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CAA71261B9F for ; Fri, 16 Jan 2026 00:28:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768523294; cv=none; b=XRewfu42DwQFOsaDKBX163IZfXMR15lbZUqW5SMPjTx7bUIS5/CQVUCK6BycHJjF5bm+rH0EY7DgIj11ntp5xGyc/DfQWxnXRpgPJjMa/RTzPIl7wkZJpiXWMNur2I5fx4kN4vzK7C3QXgcJBkI8aq7G3RiPjoCunjLd4+6yeys= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768523294; c=relaxed/simple; bh=wyZTSNaahlwJAh0cMf67fv0LFlau0J3pldiB0gJ7Ut0=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=ZbGuEoN6MBfQp6MBdKMuuNtHb6hpG6BjmnrWPyzp774MDA8Ms5FijpaxOedTyyS+AJBb08XAAmrd8FMeqBTc6lWYlXcTCoSWYyxxujU6QGJdwxYbLohPvk8u9otLybGGy59VGTrrlZTgQaHbWYcy1OBb/YQkAi0RWRl1fHsw3Sc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hLLjZa6J; arc=none smtp.client-ip=209.85.218.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hLLjZa6J" Received: by mail-ej1-f51.google.com with SMTP id a640c23a62f3a-b8765b7f4c0so250085666b.0 for ; Thu, 15 Jan 2026 16:28:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768523291; x=1769128091; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=LuYXJTx9p8g5I9PbL+x4hBzLoIE63ueUkinqkyb6yNs=; b=hLLjZa6JbWmfotEx6HjcqCkzUaw7dLCiW1VISKEAL+ijRMH5fzpwEGbRsH4MQkOU2+ Jr7horaekn+Gr/lSiDYBwtExnIIMb6L7hyU+BJ8Ks2b4qhp5WnFZT+ylpJrqRRRb04Jb /Rn8iHgKA/TRMDaqb3IIF6UvMU+owlTIGRSNVBawA3mfKgYbDEJfxCqnvDV3JfuOT98T I9DRJs73SCISJjrKP9slxhGu+MI4g5yl8FjW8HaeA1VYcvs/gI5NqA2N66U2vmePglG+ EzHYfSLptjNh7lrnZ6g6LUbd0GSJ+kzC/5zW8pnTNnqYz+lY1jBUELkIgJIlnLpgEv/J xyIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768523291; x=1769128091; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=LuYXJTx9p8g5I9PbL+x4hBzLoIE63ueUkinqkyb6yNs=; b=SjwRCTeVUqlMashYiF6MrOXHW5WsLtVy077/xF2CnqaW2axLyI5dACC43/sMTCKmEL G9JxL3JIQAtyY5E/9Ud7MMlSkyoOYobXxruZ9wLHcE/xjSdMQTfO0+iRqOgSr2EmJhIN PiMjFN5i7RrVo28MKr170hEc0uGXTZuXislE1LzGWL/+jsauAtHa16U8asyDKGzyQfw9 onPDd1gqdJKdwB5qjC2UoLFnFuCHIRjP3ctxMaMkAxAH+gpH4zF1v7VtbHXDJ8m64QwG MNMlg7e5P5b7kKsmWHNkobWV0+sqztKicD7VTHy3Sq6HuyXdhdqZHYhOLQ52xmpvWTgq D1Ug== X-Forwarded-Encrypted: i=1; AJvYcCVZZUoQR8MOGW7cVQ7l0Dat7MlDJ0GYC+lWg0Xbvc14MOO6PHsr8bHa8g8FQ7r4piuTxsDLnlenfnSh5tCC@vger.kernel.org X-Gm-Message-State: AOJu0YwMzl667/6d01OUDoiEM7s+hb1DD/lMogLfs8OyPC2eqi+nFFfX tEBDNsrfExadWFPqvmXZm95XUWntExJs5jtdSu4nzyFoa8SCBez1SBsK X-Gm-Gg: AY/fxX6DInzcG8S8WuBswYczKTZOTweN4nRtS5AXR//iEMrWiP7rC3TEFzdNrl9TiXx EYLNV9nrqJEZ5ubqfdckKJzVee7fud40oc6ZU6O/oDvcz3mi5Oe7Od8Yqk2dVseEIckYuwNg+ij OEXnRfyWlYWFQbm2jcs+M7fa3y08DZyVIR9eDqPrAh//7Kx48b+hxMcbUKdYtJ1MxqZ3Q1eAKLM qBNg3k/uA1dF5h1T0kv76NbskBjDB8xFmqhMTohJo7a6IuCsLjp1D3YGU9wVk9yQJoGflF6fXQy mKP1mngvfsmvKqi/c4Au1iE93h6E8Hfpz+ZZWDHIGG53cdT6Q29B0enqS5o63MtTIMFlenA4SV/ plWpOvk87cNUNBevPVqNJb+bcYfPTcvlkxR8M4X6cD1eey37UT8ymJfU6WJg1SJMkZWV+LzTbJ+ U6bylnRS7YQAj27NqO71MGnyjGpCvyK8gcbjwYGHl51hs5bnSqfaVp X-Received: by 2002:a05:600d:8445:10b0:480:1a22:fce8 with SMTP id 5b1f17b1804b1-4801e3494acmr11682565e9.26.1768516821247; Thu, 15 Jan 2026 14:40:21 -0800 (PST) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4356996dad0sm1443737f8f.27.2026.01.15.14.40.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Jan 2026 14:40:20 -0800 (PST) Date: Thu, 15 Jan 2026 22:40:18 +0000 From: David Laight To: "Chuck Lever" Cc: "Dave Chinner" , "Amir Goldstein" , "Jeff Layton" , "Christian Brauner" , "Alexander Viro" , "Chuck Lever" , NeilBrown , "Olga Kornievskaia" , "Dai Ngo" , "Tom Talpey" , "Hugh Dickins" , "Baolin Wang" , "Andrew Morton" , "Theodore Tso" , "Andreas Dilger" , "Jan Kara" , "Gao Xiang" , "Chao Yu" , "Yue Hu" , "Jeffle Xu" , "Sandeep Dhavale" , "Hongbo Li" , "Chunhai Guo" , "Carlos Maiolino" , "Ilya Dryomov" , "Alex Markuze" , "Viacheslav Dubeyko" , "Chris Mason" , "David Sterba" , "Luis de Bethencourt" , "Salah Triki" , "Phillip Lougher" , "Steve French" , "Paulo Alcantara" , "Ronnie Sahlberg" , "Shyam Prasad N" , "Bharath SM" , "Miklos Szeredi" , "Mike Marshall" , "Martin Brandenburg" , "Mark Fasheh" , "Joel Becker" , "Joseph Qi" , "Konstantin Komarov" , "Ryusuke Konishi" , "Trond Myklebust" , "Anna Schumaker" , "Dave Kleikamp" , "David Woodhouse" , "Richard Weinberger" , "Jan Kara" , "Andreas Gruenbacher" , "OGAWA Hirofumi" , "Jaegeuk Kim" , "Christoph Hellwig" , linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-ext4@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-xfs@vger.kernel.org, ceph-devel@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-unionfs@vger.kernel.org, devel@lists.orangefs.org, ocfs2-devel@lists.linux.dev, ntfs3@lists.linux.dev, linux-nilfs@vger.kernel.org, jfs-discussion@lists.sourceforge.net, linux-mtd@lists.infradead.org, gfs2@lists.linux.dev, linux-f2fs-devel@lists.sourceforge.net Subject: Re: [PATCH 00/29] fs: require filesystems to explicitly opt-in to nfsd export support Message-ID: <20260115224018.2988ca25@pumpkin> In-Reply-To: <06dcc4b6-7457-4094-a1c6-586ce518020f@app.fastmail.com> References: <20260115-exportfs-nfsd-v1-0-8e80160e3c0c@kernel.org> <4d9967cc-a454-46cf-909b-b8ab2d18358d@kernel.org> <06dcc4b6-7457-4094-a1c6-586ce518020f@app.fastmail.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Thu, 15 Jan 2026 16:37:27 -0500 "Chuck Lever" wrote: > On Thu, Jan 15, 2026, at 4:09 PM, Dave Chinner wrote: > > On Thu, Jan 15, 2026 at 02:37:09PM -0500, Chuck Lever wrote: =20 > >> On 1/15/26 2:14 PM, Amir Goldstein wrote: =20 > >> > On Thu, Jan 15, 2026 at 7:32=E2=80=AFPM Chuck Lever = wrote: =20 > >> >> > >> >> > >> >> > >> >> On Thu, Jan 15, 2026, at 1:17 PM, Amir Goldstein wrote: =20 > >> >>> On Thu, Jan 15, 2026 at 6:48=E2=80=AFPM Jeff Layton wrote: =20 > >> >>>> > >> >>>> In recent years, a number of filesystems that can't present stable > >> >>>> filehandles have grown struct export_operations. They've mostly d= one > >> >>>> this for local use-cases (enabling open_by_handle_at() and the li= ke). > >> >>>> Unfortunately, having export_operations is generally sufficient t= o make > >> >>>> a filesystem be considered exportable via nfsd, but that requires= that > >> >>>> the server present stable filehandles. =20 > >> >>> > >> >>> Where does the term "stable file handles" come from? and what does= it mean? > >> >>> Why not "persistent handles", which is described in NFS and SMB sp= ecs? > >> >>> > >> >>> Not to mention that EXPORT_OP_PERSISTENT_HANDLES was Acked > >> >>> by both Christoph and Christian: > >> >>> > >> >>> https://lore.kernel.org/linux-fsdevel/20260115-rundgang-leihgabe-1= 2018e93c00c@brauner/ > >> >>> > >> >>> Am I missing anything? =20 > >> >> > >> >> PERSISTENT generally implies that the file handle is saved on > >> >> persistent storage. This is not true of tmpfs. =20 > >> >=20 > >> > That's one way of interpreting "persistent". > >> > Another way is "continuing to exist or occur over a prolonged period= ." > >> > which works well for tmpfs that is mounted for a long time. =20 > >>=20 > >> I think we can be a lot more precise about the guarantee: The file > >> handle does not change for the life of the inode it represents. It =20 > > > > > > > > File handles most definitely change over the life of a /physical/ > > inode. Unlinking a file does not require ending the life of the > > physical object that provides the persistent data store for the > > file. > > > > e.g. XFS dynamically allocates physical inodes might in a life cycle > > that looks somewhat life this: > > > > allocate physical inode > > insert record into allocated inode index > > mark inode as free > > > > while (don't need to free physical inode) { > > ... > > allocate inode for a new file > > update persistent inode metadata to generate new filehandle > > mark inode in use > > ... > > unlink file > > mark inode free > > } > > > > remove inode from allocated inode index > > free physical inode > > > > i.e. a free inode is still an -allocated, indexed inode- in the > > filesystem, and until we physically remove it from the filesystem > > the inode life cycle has not ended. > > > > IOWs, the physical (persistent) inode lifetime can span the lifetime > > of -many- files. However, the filesystem guarantees that the handle > > generated for that inode is different for each file it represents > > over the whole inode life time. > > > > Hence I think that file handle stability/persistence needs to be > > defined in terms of -file lifetimes-, not the lifetimes of the > > filesystem objects implement the file's persistent data store. =20 >=20 > Fair enough, "inode" is the wrong term to use here. Usually there is 'generation number' changes when the inode is used for a new file. IIRC the original nfs file handle was the major/minor for the disk partitio= n, the index into the 'on-disk inode table' (the inode number) and the 'generation number' (but I'm sure the length was a power of 2...). It's not surprising Unix uses inode number and file handles. K&R would have used RSM-11/M where 'file directory lookup' was a userspace operation and the kernel only supported 'open by file handle'. Although that got lost between there and ntfs. (Windows IO is definitely based on RSM-11/M though.) David