From: Joanne Koong <joannelkoong@gmail.com>
To: miklos@szeredi.hu
Cc: linux-fsdevel@vger.kernel.org, jefflexu@linux.alibaba.com
Subject: [PATCH v1 1/3] fuse: use DIV_ROUND_UP() for page count calculations
Date: Fri, 16 Jan 2026 15:56:04 -0800 [thread overview]
Message-ID: <20260116235606.2205801-2-joannelkoong@gmail.com> (raw)
In-Reply-To: <20260116235606.2205801-1-joannelkoong@gmail.com>
Use DIV_ROUND_UP() instead of manually computing round-up division
calculations.
Signed-off-by: Joanne Koong <joannelkoong@gmail.com>
---
fs/fuse/dev.c | 6 +++---
fs/fuse/file.c | 2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/fs/fuse/dev.c b/fs/fuse/dev.c
index 6d59cbc877c6..698289b5539e 100644
--- a/fs/fuse/dev.c
+++ b/fs/fuse/dev.c
@@ -1814,7 +1814,7 @@ static int fuse_notify_store(struct fuse_conn *fc, unsigned int size,
folio_offset = ((index - folio->index) << PAGE_SHIFT) + offset;
nr_bytes = min_t(unsigned, num, folio_size(folio) - folio_offset);
- nr_pages = (offset + nr_bytes + PAGE_SIZE - 1) >> PAGE_SHIFT;
+ nr_pages = DIV_ROUND_UP(offset + nr_bytes, PAGE_SIZE);
err = fuse_copy_folio(cs, &folio, folio_offset, nr_bytes, 0);
if (!folio_test_uptodate(folio) && !err && offset == 0 &&
@@ -1883,7 +1883,7 @@ static int fuse_retrieve(struct fuse_mount *fm, struct inode *inode,
else if (outarg->offset + num > file_size)
num = file_size - outarg->offset;
- num_pages = (num + offset + PAGE_SIZE - 1) >> PAGE_SHIFT;
+ num_pages = DIV_ROUND_UP(num + offset, PAGE_SIZE);
num_pages = min(num_pages, fc->max_pages);
num = min(num, num_pages << PAGE_SHIFT);
@@ -1918,7 +1918,7 @@ static int fuse_retrieve(struct fuse_mount *fm, struct inode *inode,
folio_offset = ((index - folio->index) << PAGE_SHIFT) + offset;
nr_bytes = min(folio_size(folio) - folio_offset, num);
- nr_pages = (offset + nr_bytes + PAGE_SIZE - 1) >> PAGE_SHIFT;
+ nr_pages = DIV_ROUND_UP(offset + nr_bytes, PAGE_SIZE);
ap->folios[ap->num_folios] = folio;
ap->descs[ap->num_folios].offset = folio_offset;
diff --git a/fs/fuse/file.c b/fs/fuse/file.c
index eba70ebf6e77..a4342b269cb9 100644
--- a/fs/fuse/file.c
+++ b/fs/fuse/file.c
@@ -2170,7 +2170,7 @@ static bool fuse_folios_need_send(struct fuse_conn *fc, loff_t pos,
WARN_ON(!ap->num_folios);
/* Reached max pages */
- if ((bytes + PAGE_SIZE - 1) >> PAGE_SHIFT > fc->max_pages)
+ if (DIV_ROUND_UP(bytes, PAGE_SIZE) > fc->max_pages)
return true;
if (bytes > max_bytes)
--
2.47.3
next prev parent reply other threads:[~2026-01-16 23:56 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-16 23:56 [PATCH v1 0/3] fuse: clean up offset and page count calculations Joanne Koong
2026-01-16 23:56 ` Joanne Koong [this message]
2026-01-19 2:12 ` [PATCH v1 1/3] fuse: use DIV_ROUND_UP() for " Jingbo Xu
2026-01-20 19:10 ` Joanne Koong
2026-01-20 20:06 ` Joanne Koong
2026-01-21 3:21 ` Jingbo Xu
2026-01-21 21:59 ` Joanne Koong
2026-01-22 1:49 ` Jingbo Xu
2026-01-16 23:56 ` [PATCH v1 2/3] fuse: use offset_in_folio() for large folio offset calculations Joanne Koong
2026-01-19 4:41 ` Chunsheng Luo
2026-01-20 18:59 ` Joanne Koong
2026-01-19 6:24 ` Chunsheng Luo
2026-01-16 23:56 ` [PATCH v1 3/3] fuse: use offset_in_page() for page " Joanne Koong
2026-01-17 5:03 ` [PATCH v1 0/3] fuse: clean up offset and page count calculations Darrick J. Wong
2026-01-20 19:05 ` Joanne Koong
2026-01-17 7:51 ` Horst Birthelmer
2026-01-20 20:06 ` Joanne Koong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260116235606.2205801-2-joannelkoong@gmail.com \
--to=joannelkoong@gmail.com \
--cc=jefflexu@linux.alibaba.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=miklos@szeredi.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox