Re: [PATCH v1 2/4] nfsd: Add a key for signing filehandles

[kernel test robot <lkp@intel.com>]

Hi Benjamin,

kernel test robot noticed the following build warnings:

[auto build test WARNING on bfd453acb5637b5df881cef4b21803344aa9e7ac]

url:    https://github.com/intel-lab-lkp/linux/commits/Benjamin-Coddington/nfsd-Convert-export-flags-to-use-BIT-macro/20260116-223927
base:   bfd453acb5637b5df881cef4b21803344aa9e7ac
patch link:    https://lore.kernel.org/r/c49d28aade36c044f0533d03b564ff65e00d9e05.1768573690.git.bcodding%40hammerspace.com
patch subject: [PATCH v1 2/4] nfsd: Add a key for signing filehandles
config: x86_64-kexec (https://download.01.org/0day-ci/archive/20260117/202601170520.GITVT8Iy-lkp@intel.com/config)
compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260117/202601170520.GITVT8Iy-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202601170520.GITVT8Iy-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> fs/nfsd/nfsctl.c:2282:50: warning: variable 'ret' is uninitialized when used here [-Wuninitialized]
    2282 |         trace_nfsd_ctl_fh_key_set((const char *)fh_key, ret);
         |                                                         ^~~
   fs/nfsd/nfsctl.c:2260:9: note: initialize the variable 'ret' to silence this warning
    2260 |         int ret;
         |                ^
         |                 = 0
   1 warning generated.


vim +/ret +2282 fs/nfsd/nfsctl.c

  2254	
  2255	int nfsd_nl_fh_key_set_doit(struct sk_buff *skb, struct genl_info *info)
  2256	{
  2257		siphash_key_t *fh_key;
  2258		struct nfsd_net *nn;
  2259		int fh_key_len;
  2260		int ret;
  2261	
  2262		if (GENL_REQ_ATTR_CHECK(info, NFSD_A_SERVER_FH_KEY))
  2263			return -EINVAL;
  2264	
  2265		fh_key_len = nla_len(info->attrs[NFSD_A_SERVER_FH_KEY]);
  2266		if (fh_key_len != sizeof(siphash_key_t))
  2267			return -EINVAL;
  2268	
  2269		/* Is the key already set? */
  2270		nn = net_generic(genl_info_net(info), nfsd_net_id);
  2271		if (nn->fh_key)
  2272			return -EEXIST;
  2273	
  2274		fh_key = kmalloc(sizeof(siphash_key_t), GFP_KERNEL);
  2275		if (!fh_key)
  2276			return -ENOMEM;
  2277	
  2278		memcpy(fh_key, nla_data(info->attrs[NFSD_A_SERVER_FH_KEY]), sizeof(siphash_key_t));
  2279		nn = net_generic(genl_info_net(info), nfsd_net_id);
  2280		nn->fh_key = fh_key;
  2281	
> 2282		trace_nfsd_ctl_fh_key_set((const char *)fh_key, ret);
  2283		return ret;
  2284	}
  2285	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki