Re: [PATCH v1 4/4] NFSD: Sign filehandles

[kernel test robot <lkp@intel.com>]

Hi Benjamin,

kernel test robot noticed the following build warnings:

[auto build test WARNING on bfd453acb5637b5df881cef4b21803344aa9e7ac]

url:    https://github.com/intel-lab-lkp/linux/commits/Benjamin-Coddington/nfsd-Convert-export-flags-to-use-BIT-macro/20260116-223927
base:   bfd453acb5637b5df881cef4b21803344aa9e7ac
patch link:    https://lore.kernel.org/r/9c9cd6131574a45f2603c9248ba205a79b00fea3.1768573690.git.bcodding%40hammerspace.com
patch subject: [PATCH v1 4/4] NFSD: Sign filehandles
config: hexagon-allmodconfig (https://download.01.org/0day-ci/archive/20260117/202601170612.qqi8Q8Xx-lkp@intel.com/config)
compiler: clang version 17.0.6 (https://github.com/llvm/llvm-project 6009708b4367171ccdbf4b5905cb6a803753fe18)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260117/202601170612.qqi8Q8Xx-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202601170612.qqi8Q8Xx-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> fs/nfsd/nfsfh.c:162:30: warning: format specifies type 'unsigned long' but the argument has type 'unsigned int' [-Wformat]
     161 |                 pr_warn("NFSD: unable to sign filehandles, fh_size %lu would be greater"
         |                                                                    ~~~
         |                                                                    %u
     162 |                         " than fh_maxsize %d.\n", fh->fh_size + sizeof(hash), fhp->fh_maxsize);
         |                                                   ^~~~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/printk.h:565:37: note: expanded from macro 'pr_warn'
     565 |         printk(KERN_WARNING pr_fmt(fmt), ##__VA_ARGS__)
         |                                    ~~~     ^~~~~~~~~~~
   include/linux/printk.h:512:60: note: expanded from macro 'printk'
     512 | #define printk(fmt, ...) printk_index_wrap(_printk, fmt, ##__VA_ARGS__)
         |                                                     ~~~    ^~~~~~~~~~~
   include/linux/printk.h:484:19: note: expanded from macro 'printk_index_wrap'
     484 |                 _p_func(_fmt, ##__VA_ARGS__);                           \
         |                         ~~~~    ^~~~~~~~~~~
   1 warning generated.


vim +162 fs/nfsd/nfsfh.c

   140	
   141	/*
   142	 * Intended to be called when encoding, appends an 8-byte MAC
   143	 * to the filehandle hashed from the server's fh_key:
   144	 */
   145	int fh_append_mac(struct svc_fh *fhp, struct net *net)
   146	{
   147		struct nfsd_net *nn = net_generic(net, nfsd_net_id);
   148		struct knfsd_fh *fh = &fhp->fh_handle;
   149		siphash_key_t *fh_key = nn->fh_key;
   150		u64 hash;
   151	
   152		if (!(fhp->fh_export->ex_flags & NFSEXP_SIGN_FH))
   153			return 0;
   154	
   155		if (!fh_key) {
   156			pr_warn("NFSD: unable to sign filehandles, fh_key not set.\n");
   157			return -EINVAL;
   158		}
   159	
   160		if (fh->fh_size + sizeof(hash) > fhp->fh_maxsize) {
   161			pr_warn("NFSD: unable to sign filehandles, fh_size %lu would be greater"
 > 162				" than fh_maxsize %d.\n", fh->fh_size + sizeof(hash), fhp->fh_maxsize);
   163			return -EINVAL;
   164		}
   165	
   166		fh->fh_auth_type = FH_AT_MAC;
   167		hash = siphash(&fh->fh_raw, fh->fh_size, fh_key);
   168		memcpy(&fh->fh_raw[fh->fh_size], &hash, sizeof(hash));
   169		fh->fh_size += sizeof(hash);
   170	
   171		return 0;
   172	}
   173	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki