From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Christian Brauner <brauner@kernel.org>,
Petr Mladek <pmladek@suse.com>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Cc: Al Viro <viro@zeniv.linux.org.uk>, Jan Kara <jack@suse.cz>,
Steven Rostedt <rostedt@goodmis.org>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Sergey Senozhatsky <senozhatsky@chromium.org>,
Andrew Morton <akpm@linux-foundation.org>,
David Disseldorp <ddiss@suse.de>
Subject: [PATCH v1 2/4] initramfs: Refactor to use hex2bin() instead of custom approach
Date: Mon, 19 Jan 2026 21:38:39 +0100 [thread overview]
Message-ID: <20260119204151.1447503-3-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <20260119204151.1447503-1-andriy.shevchenko@linux.intel.com>
There is a simple_strntoul() function used solely as a shortcut
for hex2bin() with proper endianess conversions. Replace that
and drop the unneeded function in the next changes.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
init/initramfs.c | 36 ++++++++++++++++++++----------------
1 file changed, 20 insertions(+), 16 deletions(-)
diff --git a/init/initramfs.c b/init/initramfs.c
index 750f126e19a0..8d931ad4d239 100644
--- a/init/initramfs.c
+++ b/init/initramfs.c
@@ -6,6 +6,7 @@
#include <linux/fcntl.h>
#include <linux/file.h>
#include <linux/fs.h>
+#include <linux/hex.h>
#include <linux/init.h>
#include <linux/init_syscalls.h>
#include <linux/kstrtox.h>
@@ -21,6 +22,8 @@
#include <linux/umh.h>
#include <linux/utime.h>
+#include <asm/byteorder.h>
+
#include "do_mounts.h"
#include "initramfs_internal.h"
@@ -192,24 +195,25 @@ static __initdata u32 hdr_csum;
static void __init parse_header(char *s)
{
- unsigned long parsed[13];
- int i;
+ __be32 header[13];
+ int ret;
- for (i = 0, s += 6; i < 13; i++, s += 8)
- parsed[i] = simple_strntoul(s, NULL, 16, 8);
+ ret = hex2bin((u8 *)header, s + 6, sizeof(header));
+ if (ret)
+ error("damaged header");
- ino = parsed[0];
- mode = parsed[1];
- uid = parsed[2];
- gid = parsed[3];
- nlink = parsed[4];
- mtime = parsed[5]; /* breaks in y2106 */
- body_len = parsed[6];
- major = parsed[7];
- minor = parsed[8];
- rdev = new_encode_dev(MKDEV(parsed[9], parsed[10]));
- name_len = parsed[11];
- hdr_csum = parsed[12];
+ ino = be32_to_cpu(header[0]);
+ mode = be32_to_cpu(header[1]);
+ uid = be32_to_cpu(header[2]);
+ gid = be32_to_cpu(header[3]);
+ nlink = be32_to_cpu(header[4]);
+ mtime = be32_to_cpu(header[5]); /* breaks in y2106 */
+ body_len = be32_to_cpu(header[6]);
+ major = be32_to_cpu(header[7]);
+ minor = be32_to_cpu(header[8]);
+ rdev = new_encode_dev(MKDEV(be32_to_cpu(header[9]), be32_to_cpu(header[10])));
+ name_len = be32_to_cpu(header[11]);
+ hdr_csum = be32_to_cpu(header[12]);
}
/* FSM */
--
2.50.1
next prev parent reply other threads:[~2026-01-19 20:41 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-19 20:38 [PATCH v1 0/4] initramfs: get rid of custom hex2bin() Andy Shevchenko
2026-01-19 20:38 ` [PATCH v1 1/4] initramfs: Sort headers alphabetically Andy Shevchenko
2026-01-19 20:38 ` Andy Shevchenko [this message]
2026-01-20 20:12 ` [PATCH v1 2/4] initramfs: Refactor to use hex2bin() instead of custom approach David Disseldorp
2026-01-20 20:34 ` Andy Shevchenko
2026-01-20 21:00 ` David Disseldorp
2026-01-20 21:17 ` Andy Shevchenko
2026-01-27 22:08 ` H. Peter Anvin
2026-01-19 20:38 ` [PATCH v1 3/4] vsprintf: Revert "add simple_strntoul" Andy Shevchenko
2026-01-19 20:38 ` [PATCH v1 4/4] kstrtox: Drop extern keyword in the simple_strtox() declarations Andy Shevchenko
2026-01-20 11:20 ` [PATCH v1 0/4] initramfs: get rid of custom hex2bin() Christian Brauner
2026-01-20 12:46 ` Andy Shevchenko
2026-01-23 12:22 ` Christian Brauner
2026-01-23 14:12 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260119204151.1447503-3-andriy.shevchenko@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=brauner@kernel.org \
--cc=ddiss@suse.de \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=senozhatsky@chromium.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox