Re: [PATCH v2 1/3] NFSD: Add a key for signing filehandles

[Eric Biggers <ebiggers@kernel.org>]

On Wed, Jan 21, 2026 at 03:24:16PM -0500, Benjamin Coddington wrote:
> +		sip_fh_key = kmalloc(sizeof(siphash_key_t), GFP_KERNEL);
> +		if (!sip_fh_key) {
> +			ret = -ENOMEM;
> +			goto out;
> +		}
> +
> +		memcpy(sip_fh_key, &uuid_fh_key, sizeof(siphash_key_t));

Note that siphash_key_t consists of a pair of native-endian u64's:

    typedef struct {
            u64 key[2];
    } siphash_key_t;

If you copy a byte array into it, the result will differ on little
endian vs. big endian CPUs.

You may want to do le64_to_cpus() on each u64, like what
fscrypt_derive_siphash_key() does.

- Eric