From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 282553DF5B7; Thu, 22 Jan 2026 16:19:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.176.79.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769098753; cv=none; b=BbUE5T8yJlp86omEDd0OnFdorJv85aXmgWYw6rQMVQ0P2Bl2fI+4MLts53KcxiFFusm+4bVG2/udoc5b2Tv9Fv2IC6Iw9Ybd+yvbVrp22XtRai2/SpDoA1WXcM/n9qeuDeJ5QxoUb4w/0quvDE02xwzA3Tqub6xQ7xui9YrnCmE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769098753; c=relaxed/simple; bh=549/Lu3vnoiN39xkcX5qsjpXarxe/ftZqZXk2SAuQ9c=; h=Date:From:To:CC:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=ld507gf8ScmXVQuW+LTm9XQI6svJZtPo6OkxrN1kHlBUzIS8T6w5DGrmPIPHt+oZ5jNWrT4Iqz/zQ0ot7CgtE+gZwev1E7Bq3deE3LNCCQxpIn/a4TwjDw1L1if063C6gRsMj2Lc+qjqZ8q2JRwSUXSbrITXvHWSsBcRXUJV4iI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=185.176.79.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.18.224.107]) by frasgout.his.huawei.com (SkyGuard) with ESMTPS id 4dxmSx3BCRzHnH66; Fri, 23 Jan 2026 00:18:25 +0800 (CST) Received: from dubpeml500005.china.huawei.com (unknown [7.214.145.207]) by mail.maildlp.com (Postfix) with ESMTPS id 6845B40584; Fri, 23 Jan 2026 00:19:01 +0800 (CST) Received: from localhost (10.203.177.15) by dubpeml500005.china.huawei.com (7.214.145.207) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Thu, 22 Jan 2026 16:18:59 +0000 Date: Thu, 22 Jan 2026 16:18:58 +0000 From: Jonathan Cameron To: Smita Koralahalli CC: , , , , , Ard Biesheuvel , "Alison Schofield" , Vishal Verma , Ira Weiny , Dan Williams , Yazen Ghannam , "Dave Jiang" , Davidlohr Bueso , "Matthew Wilcox" , Jan Kara , "Rafael J . Wysocki" , Len Brown , Pavel Machek , Li Ming , Jeff Johnson , Ying Huang , Yao Xingtao , "Peter Zijlstra" , Greg Kroah-Hartman , Nathan Fontenot , Terry Bowman , Robert Richter , Benjamin Cheatham , Zhijian Li , Borislav Petkov , Tomasz Wolski Subject: Re: [PATCH v5 3/7] cxl/region: Skip decoder reset on detach for autodiscovered regions Message-ID: <20260122161858.00004b0c@huawei.com> In-Reply-To: <20260122045543.218194-4-Smita.KoralahalliChannabasappa@amd.com> References: <20260122045543.218194-1-Smita.KoralahalliChannabasappa@amd.com> <20260122045543.218194-4-Smita.KoralahalliChannabasappa@amd.com> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.42; x86_64-w64-mingw32) Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: lhrpeml500009.china.huawei.com (7.191.174.84) To dubpeml500005.china.huawei.com (7.214.145.207) On Thu, 22 Jan 2026 04:55:39 +0000 Smita Koralahalli wrote: > __cxl_decoder_detach() currently resets decoder programming whenever a > region is detached if cxl_config_state is beyond CXL_CONFIG_ACTIVE. For > autodiscovered regions, this can incorrectly tear down decoder state > that may be relied upon by other consumers or by subsequent ownership > decisions. > > Skip cxl_region_decode_reset() during detach when CXL_REGION_F_AUTO is > set. > > Signed-off-by: Smita Koralahalli Reviewed-by: Jonathan Cameron purely on basis we should probably not undo things we didn't do in the first place. J