From: Christoph Hellwig <hch@lst.de>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>,
t@magnolia.djwong.org, Eric Biggers <ebiggers@kernel.org>,
Al Viro <viro@zeniv.linux.org.uk>,
Christian Brauner <brauner@kernel.org>, Jan Kara <jack@suse.cz>,
David Sterba <dsterba@suse.com>, Theodore Ts'o <tytso@mit.edu>,
Jaegeuk Kim <jaegeuk@kernel.org>, Chao Yu <chao@kernel.org>,
Andrey Albershteyn <aalbersh@redhat.com>,
"Matthew Wilcox (Oracle)" <willy@infradead.org>,
linux-fsdevel@vger.kernel.org, linux-btrfs@vger.kernel.org,
linux-ext4@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net, fsverity@lists.linux.dev
Subject: Re: [PATCH 04/11] fsverity: start consolidating pagecache code
Date: Fri, 23 Jan 2026 06:12:16 +0100 [thread overview]
Message-ID: <20260123051216.GA24123@lst.de> (raw)
In-Reply-To: <20260122212700.GD5910@frogsfrogsfrogs>
On Thu, Jan 22, 2026 at 01:27:00PM -0800, Darrick J. Wong wrote:
> Nice hoist, though I wonder -- as an exported fs function, should we be
> checking that the returned folio doesn't cover EOF? Not that any of the
> users actually check that returned merkle tree folios fit that
> criterion.
As in past i_size because this is verity metadata? I think per the
last discussion that's only guranteed to be true, not the folio. It
might be useful to assert this, but it might be better for combine
this with the work to use different on-disk vs in-memory offset
and to consolidate all the offset magic. Which is worthwhile,
but І don't really want to add that in this series.
next prev parent reply other threads:[~2026-01-23 5:12 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-22 8:21 fsverity cleanups, speedup and memory usage optimization v2 Christoph Hellwig
2026-01-22 8:21 ` [PATCH 01/11] fs,fsverity: reject size changes on fsverity files in setattr_prepare Christoph Hellwig
2026-01-22 9:12 ` Jan Kara
2026-01-22 21:21 ` Darrick J. Wong
2026-01-22 8:21 ` [PATCH 02/11] fs,fsverity: clear out fsverity_info from common code Christoph Hellwig
2026-01-22 9:15 ` Jan Kara
2026-01-22 21:22 ` Darrick J. Wong
2026-01-22 8:21 ` [PATCH 03/11] fsverity: pass struct file to ->write_merkle_tree_block Christoph Hellwig
2026-01-22 10:04 ` Andrey Albershteyn
2026-01-22 21:23 ` Darrick J. Wong
2026-01-22 8:22 ` [PATCH 04/11] fsverity: start consolidating pagecache code Christoph Hellwig
2026-01-22 9:18 ` Jan Kara
2026-01-22 10:12 ` Andrey Albershteyn
2026-01-22 21:27 ` Darrick J. Wong
2026-01-23 5:12 ` Christoph Hellwig [this message]
2026-01-23 7:21 ` Darrick J. Wong
2026-01-24 19:27 ` Eric Biggers
2026-01-26 4:27 ` Christoph Hellwig
2026-01-22 8:22 ` [PATCH 05/11] fsverity: kick off hash readahead at data I/O submission time Christoph Hellwig
2026-01-22 21:42 ` Darrick J. Wong
2026-01-23 5:14 ` Christoph Hellwig
2026-01-23 7:22 ` Darrick J. Wong
2026-01-24 20:53 ` Eric Biggers
2026-01-26 4:30 ` Christoph Hellwig
2026-01-22 8:22 ` [PATCH 06/11] fsverity: push out fsverity_info lookup Christoph Hellwig
2026-01-22 21:45 ` Darrick J. Wong
2026-01-24 21:19 ` Eric Biggers
2026-01-26 4:33 ` Christoph Hellwig
2026-01-22 8:22 ` [PATCH 07/11] fs: consolidate fsverity_info lookup in buffer.c Christoph Hellwig
2026-01-22 21:49 ` Darrick J. Wong
2026-01-23 5:15 ` Christoph Hellwig
2026-01-23 7:23 ` Darrick J. Wong
2026-01-23 7:24 ` Christoph Hellwig
2026-01-22 8:22 ` [PATCH 08/11] ext4: consolidate fsverity_info lookup Christoph Hellwig
2026-01-22 21:54 ` Darrick J. Wong
2026-01-23 5:18 ` Christoph Hellwig
2026-01-23 7:25 ` Darrick J. Wong
2026-01-22 8:22 ` [PATCH 09/11] f2fs: " Christoph Hellwig
2026-01-22 8:22 ` [PATCH 10/11] btrfs: " Christoph Hellwig
2026-01-22 8:22 ` [PATCH 11/11] fsverity: use a hashtable to find the fsverity_info Christoph Hellwig
2026-01-22 22:04 ` Darrick J. Wong
2026-01-23 5:27 ` Christoph Hellwig
2026-01-23 7:27 ` Darrick J. Wong
2026-01-23 7:30 ` Christoph Hellwig
2026-01-25 1:31 ` Eric Biggers
2026-01-25 21:48 ` Matthew Wilcox
2026-01-26 4:44 ` Christoph Hellwig
2026-01-26 20:12 ` Eric Biggers
2026-01-28 21:38 ` Matthew Wilcox
2026-01-28 22:14 ` Eric Biggers
2026-01-26 4:43 ` Christoph Hellwig
2026-01-22 15:42 ` fsverity cleanups, speedup and memory usage optimization v2 David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260123051216.GA24123@lst.de \
--to=hch@lst.de \
--cc=aalbersh@redhat.com \
--cc=brauner@kernel.org \
--cc=chao@kernel.org \
--cc=djwong@kernel.org \
--cc=dsterba@suse.com \
--cc=ebiggers@kernel.org \
--cc=fsverity@lists.linux.dev \
--cc=jack@suse.cz \
--cc=jaegeuk@kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=t@magnolia.djwong.org \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox