From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CBD76308F2E; Fri, 23 Jan 2026 07:47:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769154469; cv=none; b=htKTN3wJW7iqRpx6j5+C5e/jKOjwpkXfZT0CxpMgQ3wCeDbt3RaP7ecKfYFY+DPadVvpDuSCoL/JuvTJdlDa9nPOaAPGs1bhccm0B20luWseEh1kwMXjnpT1xqX0OzJ9MTfH3K/hfnnwbwV/UjVRHvwi622Iz7ZqAE9cRfHqj4M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769154469; c=relaxed/simple; bh=qZcCh8YaN75BaHxJI3n8DUClBttDVVefL2TarE8x2cs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=lJsHFDrNLxQcn9mmJ0cV3XPS2T4Vd3l92YJIpk9Pgkk0W0skCQlV4my1lzyoeGCr3b4Vn8SIRgWnYA8xbLmPWo/jwFGpGzbe9AnuxVIlkkpSC4U3+yHF9xzJgLhJh8rFTXVaWu3oT0xOIExg6wiI4RkJBcW9/VO8yq2StIYGNKc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Dhz6ArAn; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Dhz6ArAn" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1D6FAC2BC86; Fri, 23 Jan 2026 07:47:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1769154469; bh=qZcCh8YaN75BaHxJI3n8DUClBttDVVefL2TarE8x2cs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Dhz6ArAnF4mrMgD2V9gaW0IOdAyt0UWHdcwmUQgrPBIWvnoaDzJtzmzMJxVck5gv+ zEZgJOeFD/IJQzx2Up99SCKmemnDSbXrWZlm1SAK7ny61M8KuplDc84jbfdlgQwQR6 +8Rb9fJ2j1Dh4UnsHETHjtBawHKcytU2E3ai7JjVMGK0KGDMhhcMz8n/3MAGSNlsTJ lel+3wVzQK3+jEYSZdvY/T5wo14jtYZ5i4jErLaZOvUngMzlLTTOeS1t4am1xi1tfP GskVtQYN+cTM93xV5bjb1azN9mPAsYErt+ynoEzLMYagl5talCo4C2ogUWa2ojcK07 lGuDTmdB4UMCw== Date: Thu, 22 Jan 2026 23:47:48 -0800 From: "Darrick J. Wong" To: Lorenzo Stoakes Cc: Andrew Morton , Jarkko Sakkinen , Dave Hansen , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H . Peter Anvin" , Arnd Bergmann , Greg Kroah-Hartman , Dan Williams , Vishal Verma , Dave Jiang , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , Christian Koenig , Huang Rui , Matthew Auld , Matthew Brost , Alexander Viro , Christian Brauner , Jan Kara , Benjamin LaHaise , Gao Xiang , Chao Yu , Yue Hu , Jeffle Xu , Sandeep Dhavale , Hongbo Li , Chunhai Guo , Theodore Ts'o , Andreas Dilger , Muchun Song , Oscar Salvador , David Hildenbrand , Konstantin Komarov , Mike Marshall , Martin Brandenburg , Tony Luck , Reinette Chatre , Dave Martin , James Morse , Babu Moger , Carlos Maiolino , Damien Le Moal , Naohiro Aota , Johannes Thumshirn , Matthew Wilcox , "Liam R . Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Hugh Dickins , Baolin Wang , Zi Yan , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Lance Yang , Jann Horn , Pedro Falcato , David Howells , Paul Moore , James Morris , "Serge E . Hallyn" , Yury Norov , Rasmus Villemoes , linux-sgx@vger.kernel.org, linux-kernel@vger.kernel.org, nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org, dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, linux-fsdevel@vger.kernel.org, linux-aio@kvack.org, linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, linux-mm@kvack.org, ntfs3@lists.linux.dev, devel@lists.orangefs.org, linux-xfs@vger.kernel.org, keyrings@vger.kernel.org, linux-security-module@vger.kernel.org, Jason Gunthorpe Subject: Re: [PATCH v2 09/13] mm: update all remaining mmap_prepare users to use vma_flags_t Message-ID: <20260123074748.GX5945@frogsfrogsfrogs> References: Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, Jan 22, 2026 at 04:06:18PM +0000, Lorenzo Stoakes wrote: > We will be shortly removing the vm_flags_t field from vm_area_desc so we > need to update all mmap_prepare users to only use the dessc->vma_flags > field. > > This patch achieves that and makes all ancillary changes required to make > this possible. > > This lays the groundwork for future work to eliminate the use of vm_flags_t > in vm_area_desc altogether and more broadly throughout the kernel. > > While we're here, we take the opportunity to replace VM_REMAP_FLAGS with > VMA_REMAP_FLAGS, the vma_flags_t equivalent. > > No functional changes intended. > > Signed-off-by: Lorenzo Stoakes > --- > drivers/char/mem.c | 6 +++--- > drivers/dax/device.c | 10 +++++----- > fs/aio.c | 2 +- > fs/erofs/data.c | 5 +++-- > fs/ext4/file.c | 4 ++-- > fs/ntfs3/file.c | 2 +- > fs/orangefs/file.c | 4 ++-- > fs/ramfs/file-nommu.c | 2 +- > fs/resctrl/pseudo_lock.c | 2 +- > fs/romfs/mmap-nommu.c | 2 +- > fs/xfs/xfs_file.c | 4 ++-- > fs/zonefs/file.c | 3 ++- > include/linux/dax.h | 8 ++++---- > include/linux/mm.h | 24 +++++++++++++++++++----- > kernel/relay.c | 2 +- > mm/memory.c | 17 ++++++++--------- > 16 files changed, 56 insertions(+), 41 deletions(-) > > diff --git a/fs/xfs/xfs_file.c b/fs/xfs/xfs_file.c > index 7874cf745af3..1238ec018bc7 100644 > --- a/fs/xfs/xfs_file.c > +++ b/fs/xfs/xfs_file.c > @@ -1974,14 +1974,14 @@ xfs_file_mmap_prepare( > * We don't support synchronous mappings for non-DAX files and > * for DAX files if underneath dax_device is not synchronous. > */ > - if (!daxdev_mapping_supported(desc->vm_flags, file_inode(file), > + if (!daxdev_mapping_supported(desc, file_inode(file), > target->bt_daxdev)) > return -EOPNOTSUPP; > > file_accessed(file); > desc->vm_ops = &xfs_file_vm_ops; > if (IS_DAX(inode)) > - desc->vm_flags |= VM_HUGEPAGE; > + vma_desc_set_flags(desc, VMA_HUGEPAGE_BIT); Looks good to me, Acked-by: "Darrick J. Wong" --D > return 0; > } >