From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0915F280CFC; Mon, 26 Jan 2026 19:27:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769455648; cv=none; b=XUT62hhwriwmoJVZ51rRl6osIdklRYwXL4DqCVpNRwM9FyOQtkbFG9ow4SlzVE7ggPbNUAmyKJLimJ7K3PAZmAu+R+bri/Pu4WQCBFICbUmi2NAghKkAu4enD+kNwbPJYFPwRuwt7DJ/qmhlXzl5/X5QZMEEX/87OPDxhPqmGRk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769455648; c=relaxed/simple; bh=B97NDNpfhzx+raKmzXpG52g4oCZeRJj9GnaEPfjhhd8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=WTxAucrvRAFXoft+0GNxkqM3L/1iQ1K9ilRGzGQWyDLwmbkKFRaXSMP8XWUvm12LRcD1SURcPZguIamyouoEvIUYob+Bp4/QVNm4b8z3Bj+1VsyxrB/gb03FEzKMiuN4MxriYXrM6ZbLx817QmufpK7pj5fPmYkyN4OK2d2Fzhg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=AHtXgoK2; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="AHtXgoK2" Received: by smtp.kernel.org (Postfix) with ESMTPSA id CE570C116C6; Mon, 26 Jan 2026 19:27:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1769455647; bh=B97NDNpfhzx+raKmzXpG52g4oCZeRJj9GnaEPfjhhd8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=AHtXgoK2gPjRUGkA0HqK2KIejrq3Aq8re/nXm3uRUlZ3hRBeLtmbsRcyi6AvcjaA7 FTmsU80LMIIole/9N86INzLK+MOdlltfI1f1jHK+qIkFlQ9jUAJa6M3Lv4xHcBR/XI ++iI4Te0IBDdFDn7eTxZ/O9DBFGv6Tp3joNj1jKSo/bk2ktywxwv5IqX5R50dXqQh8 FKNtc0bEw/ReWy70buaXLvtX7aTVlJzWqppLxk7g5+4Lz+Hd6iz84xGp0eHCmRHjuw NxwKKcDQRMtORKZAz/A6auuRnmGjU3oZjmHGdjiTpkURb8cVbf+Y+sGWerpAo3n5nm 6zzCpud4chRFQ== Date: Mon, 26 Jan 2026 11:27:27 -0800 From: "Darrick J. Wong" To: Christoph Hellwig Cc: Eric Biggers , Al Viro , Christian Brauner , Jan Kara , David Sterba , Theodore Ts'o , Jaegeuk Kim , Chao Yu , Andrey Albershteyn , Matthew Wilcox , linux-fsdevel@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, fsverity@lists.linux.dev Subject: Re: [PATCH 03/16] ext4: don't build the fsverity work handler for !CONFIG_FS_VERITY Message-ID: <20260126192727.GT5910@frogsfrogsfrogs> References: <20260126045212.1381843-1-hch@lst.de> <20260126045212.1381843-4-hch@lst.de> Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260126045212.1381843-4-hch@lst.de> On Mon, Jan 26, 2026 at 05:50:49AM +0100, Christoph Hellwig wrote: > Use IS_ENABLED to disable this code, leading to a slight size reduction: > > text data bss dec hex filename > 4121 376 16 4513 11a1 fs/ext4/readpage.o.old > 4030 328 16 4374 1116 fs/ext4/readpage.o > > Signed-off-by: Christoph Hellwig Fine with me Reviewed-by: "Darrick J. Wong" --D > --- > fs/ext4/readpage.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/fs/ext4/readpage.c b/fs/ext4/readpage.c > index e7f2350c725b..267594ef0b2c 100644 > --- a/fs/ext4/readpage.c > +++ b/fs/ext4/readpage.c > @@ -130,7 +130,8 @@ static void bio_post_read_processing(struct bio_post_read_ctx *ctx) > ctx->cur_step++; > fallthrough; > case STEP_VERITY: > - if (ctx->enabled_steps & (1 << STEP_VERITY)) { > + if (IS_ENABLED(CONFIG_FS_VERITY) && > + ctx->enabled_steps & (1 << STEP_VERITY)) { > INIT_WORK(&ctx->work, verity_work); > fsverity_enqueue_verify_work(&ctx->work); > return; > -- > 2.47.3 > >