From: Eric Biggers <ebiggers@kernel.org>
To: Amir Goldstein <amir73il@gmail.com>
Cc: Miklos Szeredi <miklos@szeredi.hu>,
Christian Brauner <brauner@kernel.org>,
Qing Wang <wangqing7171@gmail.com>,
linux-fsdevel@vger.kernel.org, linux-unionfs@vger.kernel.org
Subject: Re: [PATCH 3/3] ovl: use name_is_dot* helpers in readdir code
Date: Wed, 28 Jan 2026 16:14:43 -0800 [thread overview]
Message-ID: <20260129001443.GE2024@quark> (raw)
In-Reply-To: <20260128132406.23768-4-amir73il@gmail.com>
On Wed, Jan 28, 2026 at 02:24:06PM +0100, Amir Goldstein wrote:
> + if (name_is_dot_dotdot(p->name, p->len)) {
> + goto del_entry;
> }
[...]
> + if (name_is_dot_dotdot(p->name, p->len)) {
> + continue;
> }
Should drop the braces in the above two places, as noted by checkpatch.
- Eric
next prev parent reply other threads:[~2026-01-29 0:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-28 13:24 [PATCH 0/3] name_is_dot* cleanup Amir Goldstein
2026-01-28 13:24 ` [PATCH 1/3] ovl: Fix uninit-value in ovl_fill_real Amir Goldstein
2026-01-29 8:44 ` Miklos Szeredi
2026-01-28 13:24 ` [PATCH 2/3] fs: add helpers name_is_dot{,dot,_dotdot} Amir Goldstein
2026-01-28 13:24 ` [PATCH 3/3] ovl: use name_is_dot* helpers in readdir code Amir Goldstein
2026-01-29 0:14 ` Eric Biggers [this message]
2026-01-29 8:38 ` Christian Brauner
2026-01-29 0:16 ` [PATCH 0/3] name_is_dot* cleanup Eric Biggers
2026-01-29 9:09 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260129001443.GE2024@quark \
--to=ebiggers@kernel.org \
--cc=amir73il@gmail.com \
--cc=brauner@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=wangqing7171@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox