[viro-vfs:for-wsamuel2 40/40] drivers/usb/gadget/function/f_fs.c:660:17: error: implicit declaration of function 'ffs_data_reset'; did you mean 'ffs_data_get'?

[viro-vfs:for-wsamuel2 40/40] drivers/usb/gadget/function/f_fs.c:660:17: error: implicit declaration of function 'ffs_data_reset'; did you mean 'ffs_data_get'?

[kernel test robot]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git for-wsamuel2
head:   9a8dd89bd5c65c4189f2bf6291f0f9a3d0df31c5
commit: 9a8dd89bd5c65c4189f2bf6291f0f9a3d0df31c5 [40/40] serialize ffs_ep0_open() on ffs->mutex, this time without ffs_data_reset() under ->mutex
config: s390-randconfig-001-20260201 (https://download.01.org/0day-ci/archive/20260201/202602011622.nYyDo3kh-lkp@intel.com/config)
compiler: s390-linux-gcc (GCC) 13.4.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260201/202602011622.nYyDo3kh-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202602011622.nYyDo3kh-lkp@intel.com/

All error/warnings (new ones prefixed by >>):

   drivers/usb/gadget/function/f_fs.c: In function 'ffs_ep0_open':
>> drivers/usb/gadget/function/f_fs.c:660:17: error: implicit declaration of function 'ffs_data_reset'; did you mean 'ffs_data_get'? [-Werror=implicit-function-declaration]
     660 |                 ffs_data_reset(ffs);
         |                 ^~~~~~~~~~~~~~
         |                 ffs_data_get
   drivers/usb/gadget/function/f_fs.c: At top level:
>> drivers/usb/gadget/function/f_fs.c:2089:13: warning: conflicting types for 'ffs_data_reset'; have 'void(struct ffs_data *)'
    2089 | static void ffs_data_reset(struct ffs_data *ffs);
         |             ^~~~~~~~~~~~~~
>> drivers/usb/gadget/function/f_fs.c:2089:13: error: static declaration of 'ffs_data_reset' follows non-static declaration
   drivers/usb/gadget/function/f_fs.c:660:17: note: previous implicit declaration of 'ffs_data_reset' with type 'void(struct ffs_data *)'
     660 |                 ffs_data_reset(ffs);
         |                 ^~~~~~~~~~~~~~
   cc1: some warnings being treated as errors


vim +660 drivers/usb/gadget/function/f_fs.c

   640	
   641	static int ffs_ep0_open(struct inode *inode, struct file *file)
   642	{
   643		struct ffs_data *ffs = inode->i_sb->s_fs_info;
   644		int ret;
   645	
   646		/* Acquire mutex */
   647		ret = ffs_mutex_lock(&ffs->mutex, file->f_flags & O_NONBLOCK);
   648		if (ret < 0)
   649			return ret;
   650	
   651		if (ffs->state == FFS_CLOSING) {
   652			mutex_unlock(&ffs->mutex);
   653			return -EBUSY;
   654		}
   655	
   656		if (atomic_add_return(1, &ffs->opened) == 1 &&
   657				ffs->state == FFS_DEACTIVATED) {
   658			ffs->state = FFS_CLOSING;
   659			mutex_unlock(&ffs->mutex);
 > 660			ffs_data_reset(ffs);
   661		} else {
   662			mutex_unlock(&ffs->mutex);
   663		}
   664		file->private_data = ffs;
   665	
   666		return stream_open(inode, file);
   667	}
   668	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki