public inbox for linux-fsdevel@vger.kernel.org
 help / color / mirror / Atom feed
* [viro-vfs:for-wsamuel2 40/40] drivers/usb/gadget/function/f_fs.c:660:3: error: call to undeclared function 'ffs_data_reset'; ISO C99 and later do not support implicit function declarations
@ 2026-02-01 10:16 kernel test robot
  0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2026-02-01 10:16 UTC (permalink / raw)
  To: Al Viro; +Cc: llvm, oe-kbuild-all, linux-fsdevel

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git for-wsamuel2
head:   9a8dd89bd5c65c4189f2bf6291f0f9a3d0df31c5
commit: 9a8dd89bd5c65c4189f2bf6291f0f9a3d0df31c5 [40/40] serialize ffs_ep0_open() on ffs->mutex, this time without ffs_data_reset() under ->mutex
config: x86_64-randconfig-013-20260201 (https://download.01.org/0day-ci/archive/20260201/202602011830.yKVSsQTY-lkp@intel.com/config)
compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260201/202602011830.yKVSsQTY-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202602011830.yKVSsQTY-lkp@intel.com/

All errors (new ones prefixed by >>):

>> drivers/usb/gadget/function/f_fs.c:660:3: error: call to undeclared function 'ffs_data_reset'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
     660 |                 ffs_data_reset(ffs);
         |                 ^
   drivers/usb/gadget/function/f_fs.c:660:3: note: did you mean 'ffs_data_get'?
   drivers/usb/gadget/function/f_fs.c:55:13: note: 'ffs_data_get' declared here
      55 | static void ffs_data_get(struct ffs_data *ffs);
         |             ^
   drivers/usb/gadget/function/f_fs.c:2089:13: error: static declaration of 'ffs_data_reset' follows non-static declaration
    2089 | static void ffs_data_reset(struct ffs_data *ffs);
         |             ^
   drivers/usb/gadget/function/f_fs.c:660:3: note: previous implicit declaration is here
     660 |                 ffs_data_reset(ffs);
         |                 ^
   2 errors generated.


vim +/ffs_data_reset +660 drivers/usb/gadget/function/f_fs.c

   640	
   641	static int ffs_ep0_open(struct inode *inode, struct file *file)
   642	{
   643		struct ffs_data *ffs = inode->i_sb->s_fs_info;
   644		int ret;
   645	
   646		/* Acquire mutex */
   647		ret = ffs_mutex_lock(&ffs->mutex, file->f_flags & O_NONBLOCK);
   648		if (ret < 0)
   649			return ret;
   650	
   651		if (ffs->state == FFS_CLOSING) {
   652			mutex_unlock(&ffs->mutex);
   653			return -EBUSY;
   654		}
   655	
   656		if (atomic_add_return(1, &ffs->opened) == 1 &&
   657				ffs->state == FFS_DEACTIVATED) {
   658			ffs->state = FFS_CLOSING;
   659			mutex_unlock(&ffs->mutex);
 > 660			ffs_data_reset(ffs);
   661		} else {
   662			mutex_unlock(&ffs->mutex);
   663		}
   664		file->private_data = ffs;
   665	
   666		return stream_open(inode, file);
   667	}
   668	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2026-02-01 10:17 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-02-01 10:16 [viro-vfs:for-wsamuel2 40/40] drivers/usb/gadget/function/f_fs.c:660:3: error: call to undeclared function 'ffs_data_reset'; ISO C99 and later do not support implicit function declarations kernel test robot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox