From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from zeniv.linux.org.uk (zeniv.linux.org.uk [62.89.141.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8916521146C; Tue, 3 Feb 2026 04:36:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=62.89.141.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770093373; cv=none; b=hSohTlFmQGKePS/GeOYV+c/j24v1Fu4gFFBcnb7Rh9GieWtIDnz7aT7bDb4BdL4ERnWHBYGLmlzB8ZLVR5nAUcPy9eME69WnHE+/N1Vm2SW4HToQ8/EMI+PACSxEiE63jTXy9kKL7NNAq+NRdr1js77Tl1kL07xiXZE9n72hOPk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770093373; c=relaxed/simple; bh=yiJG4EjQQZFqFqXjwnZEimHyL2LjmICFdrgXgZ/8RBo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=LC1ukd76/SODWLlPjbPXGJPIgK2qeM2CYaPNi4emdsEnTv1MuOj4eNfkkQuBKYuDl0PUoxaQ5ohnTuW4qYFZ+NlpLWAxmDX7TBMMpUYA2WcRs1EGEsHNwzadKhvEqBvG3Z8xO5sxriCDUQOPYodEYwPs71ojTd/VxT8khZxvJiE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=zeniv.linux.org.uk; spf=none smtp.mailfrom=ftp.linux.org.uk; dkim=pass (2048-bit key) header.d=linux.org.uk header.i=@linux.org.uk header.b=YUCJCIX+; arc=none smtp.client-ip=62.89.141.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=zeniv.linux.org.uk Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=ftp.linux.org.uk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linux.org.uk header.i=@linux.org.uk header.b="YUCJCIX+" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=linux.org.uk; s=zeniv-20220401; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=cC/gnzDITw0jWfBHsul9GIfuHlfa//WvbBRB1wNvZ5Q=; b=YUCJCIX+DTdnAE0wv7j6Ws5Khe YmqEPS/ipChFih31va2p3dHy2gmk91PEwFAjpzDW1Oun67ig5vFq/L5nfHFcH1gzlhN0+yktbjnKB aEhZkPf9lusgpSEgIVx/knmL535K4Eu/pu5pTjshJSrN5C/KqG0ccApKp9NgxBUVC740Ljdxe8ayU pJcrab1b5/d9QJeAO0Bj89aKjUYx8JG14Kj10qglfneTjC7wpcJfWUedpU2E4stlOM+OOB1hW20Ri ZWNTr5i7kQNnaPp1FODcggTCAfmq7fbA8qQEzOZiiP994IWq6dTuot2TAMviS0O1gXwzVbzOVNEbH OwwYjHSQ==; Received: from viro by zeniv.linux.org.uk with local (Exim 4.99.1 #2 (Red Hat Linux)) id 1vn8Aw-0000000Eprp-0XUO; Tue, 03 Feb 2026 04:38:06 +0000 Date: Tue, 3 Feb 2026 04:38:06 +0000 From: Al Viro To: Viacheslav Dubeyko Cc: "glaubitz@physik.fu-berlin.de" , "shardulsb08@gmail.com" , "slava@dubeyko.com" , "frank.li@vivo.com" , "linux-kernel@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" , "shardul.b@mpiricsoftware.com" , "jack@suse.cz" , "janak@mpiricsoftware.com" , "brauner@kernel.org" , "syzbot+99f6ed51479b86ac4c41@syzkaller.appspotmail.com" Subject: Re: [PATCH v2] hfsplus: fix s_fs_info leak on mount setup failure Message-ID: <20260203043806.GF3183987@ZenIV> References: <20260201131229.4009115-1-shardul.b@mpiricsoftware.com> Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: Al Viro On Mon, Feb 02, 2026 at 05:53:57PM +0000, Viacheslav Dubeyko wrote: > > out_unload_nls: > > - unload_nls(sbi->nls); ^^^^^^^^^^^^^^^^^^^^ > > unload_nls(nls); > > - kfree(sbi); > The patch [1] fixes the issue and it in HFS/HFS+ tree already. AFAICS, [1] lacks this removal of unload_nls() on failure exit. IOW, the variant in your tree does unload_nls(sbi->nls) twice...