From: Al Viro <viro@zeniv.linux.org.uk>
To: Viacheslav Dubeyko <Slava.Dubeyko@ibm.com>
Cc: "shardulsb08@gmail.com" <shardulsb08@gmail.com>,
"jack@suse.cz" <jack@suse.cz>,
"frank.li@vivo.com" <frank.li@vivo.com>,
"brauner@kernel.org" <brauner@kernel.org>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"slava@dubeyko.com" <slava@dubeyko.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"shardul.b@mpiricsoftware.com" <shardul.b@mpiricsoftware.com>,
"glaubitz@physik.fu-berlin.de" <glaubitz@physik.fu-berlin.de>,
"janak@mpiricsoftware.com" <janak@mpiricsoftware.com>,
"syzbot+99f6ed51479b86ac4c41@syzkaller.appspotmail.com"
<syzbot+99f6ed51479b86ac4c41@syzkaller.appspotmail.com>
Subject: Re: [PATCH v2] hfsplus: fix s_fs_info leak on mount setup failure
Date: Wed, 4 Feb 2026 17:52:57 +0000 [thread overview]
Message-ID: <20260204175257.GN3183987@ZenIV> (raw)
In-Reply-To: <20260204174047.GM3183987@ZenIV>
On Wed, Feb 04, 2026 at 05:40:47PM +0000, Al Viro wrote:
> On Wed, Feb 04, 2026 at 05:30:29PM +0000, Al Viro wrote:
>
> > While we are at it, this
> > kfree(sbi->s_vhdr_buf);
> > kfree(sbi->s_backup_vhdr_buf);
> > might as well go into ->kill_sb(). That would result in the (untested)
> > delta below and IMO it's easier to follow that way...
>
> AFAICS once you've got ->s_root set, you can just return an error and
> be done with that - regular cleanup should take care of those parts
> (note that iput(NULL) is explicitly a no-op and the same goes for
> cancel_delayed_work_sync() on something that has never been through
> queue_delayed_work()).
Scratch the last one - you'd get nls leak that way, thanks to the
trickery in there... Depending on how much do you dislike cleanup.h
stuff, there might be a way to deal with that, though...
next prev parent reply other threads:[~2026-02-04 17:50 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-01 13:12 [PATCH v2] hfsplus: fix s_fs_info leak on mount setup failure Shardul Bankar
2026-02-02 17:53 ` Viacheslav Dubeyko
2026-02-03 4:38 ` Al Viro
2026-02-03 23:35 ` Viacheslav Dubeyko
2026-02-04 4:19 ` Shardul Bankar
2026-02-04 17:04 ` [PATCH] hfsplus: avoid double unload_nls() on mount failure Shardul Bankar
2026-02-05 23:08 ` Viacheslav Dubeyko
2026-02-04 17:30 ` [PATCH v2] hfsplus: fix s_fs_info leak on mount setup failure Al Viro
2026-02-04 17:40 ` Al Viro
2026-02-04 17:52 ` Al Viro [this message]
2026-02-04 18:25 ` Al Viro
2026-02-04 23:04 ` Viacheslav Dubeyko
2026-02-06 22:22 ` Viacheslav Dubeyko
2026-02-11 2:03 ` Al Viro
2026-02-11 23:49 ` Viacheslav Dubeyko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260204175257.GN3183987@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=Slava.Dubeyko@ibm.com \
--cc=brauner@kernel.org \
--cc=frank.li@vivo.com \
--cc=glaubitz@physik.fu-berlin.de \
--cc=jack@suse.cz \
--cc=janak@mpiricsoftware.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shardul.b@mpiricsoftware.com \
--cc=shardulsb08@gmail.com \
--cc=slava@dubeyko.com \
--cc=syzbot+99f6ed51479b86ac4c41@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox