From: Christoph Hellwig <hch@lst.de>
To: Dai Ngo <dai.ngo@oracle.com>
Cc: chuck.lever@oracle.com, jlayton@kernel.org, neil@brown.name,
okorniev@redhat.com, tom@talpey.com, hch@lst.de,
alex.aring@gmail.com, viro@zeniv.linux.org.uk,
brauner@kernel.org, jack@suse.cz, linux-fsdevel@vger.kernel.org,
linux-nfs@vger.kernel.org
Subject: Re: [PATCH v5 1/1] NFSD: Enforce timeout on layout recall and integrate lease manager fencing
Date: Fri, 6 Feb 2026 07:16:17 +0100 [thread overview]
Message-ID: <20260206061617.GA25655@lst.de> (raw)
In-Reply-To: <20260205202929.879846-1-dai.ngo@oracle.com>
Most of this is over my head (but I'll still try to come up with good
comments if I can find some time to learn/relearn the lease code), but
one thing I noticed is that this mixes up VFS and nfsd code. You
probably want to split this into a core infrastructure and a nfsd patch.
next prev parent reply other threads:[~2026-02-06 6:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-05 20:29 [PATCH v5 1/1] NFSD: Enforce timeout on layout recall and integrate lease manager fencing Dai Ngo
2026-02-06 6:16 ` Christoph Hellwig [this message]
2026-02-06 18:28 ` Dai Ngo
2026-02-06 14:28 ` Jeff Layton
2026-02-06 18:17 ` Dai Ngo
2026-02-06 19:40 ` Jeff Layton
2026-02-06 23:33 ` Dai Ngo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260206061617.GA25655@lst.de \
--to=hch@lst.de \
--cc=alex.aring@gmail.com \
--cc=brauner@kernel.org \
--cc=chuck.lever@oracle.com \
--cc=dai.ngo@oracle.com \
--cc=jack@suse.cz \
--cc=jlayton@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=neil@brown.name \
--cc=okorniev@redhat.com \
--cc=tom@talpey.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox