public inbox for linux-fsdevel@vger.kernel.org
 help / color / mirror / Atom feed
From: Nathan Chancellor <nathan@kernel.org>
To: Christian Brauner <brauner@kernel.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [GIT PULL 12/12 for v7.0] vfs misc
Date: Fri, 6 Feb 2026 23:11:14 -0600	[thread overview]
Message-ID: <20260207051114.GA2289557@ax162> (raw)
In-Reply-To: <20260206-vfs-misc-v70-be6f713f9fa9@brauner>

On Fri, Feb 06, 2026 at 05:50:08PM +0100, Christian Brauner wrote:
> David Laight (1):
>       fs: use min() or umin() instead of min_t()

This needs a fix up for 32-bit builds:

  https://lore.kernel.org/20260113192243.73983-1-david.laight.linux@gmail.com/

  $ make -skj"$(nproc)" ARCH=arm CROSS_COMPILE=arm-linux-gnueabi- mrproper allmodconfig fs/fuse/file.o
  In file included from <command-line>:
  In function 'fuse_wr_pages',
      inlined from 'fuse_perform_write' at fs/fuse/file.c:1347:27:
  include/linux/compiler_types.h:705:45: error: call to '__compiletime_assert_508' declared with attribute error: min(((pos + len - 1) >> 12) - (pos >> 12) + 1, max_pages) signedness error
    705 |         _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
        |                                             ^
  include/linux/compiler_types.h:686:25: note: in definition of macro '__compiletime_assert'
    686 |                         prefix ## suffix();                             \
        |                         ^~~~~~
  include/linux/compiler_types.h:705:9: note: in expansion of macro '_compiletime_assert'
    705 |         _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
        |         ^~~~~~~~~~~~~~~~~~~
  include/linux/build_bug.h:39:37: note: in expansion of macro 'compiletime_assert'
     39 | #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg)
        |                                     ^~~~~~~~~~~~~~~~~~
  include/linux/minmax.h:93:9: note: in expansion of macro 'BUILD_BUG_ON_MSG'
     93 |         BUILD_BUG_ON_MSG(!__types_ok(ux, uy),           \
        |         ^~~~~~~~~~~~~~~~
  include/linux/minmax.h:98:9: note: in expansion of macro '__careful_cmp_once'
     98 |         __careful_cmp_once(op, x, y, __UNIQUE_ID(x_), __UNIQUE_ID(y_))
        |         ^~~~~~~~~~~~~~~~~~
  include/linux/minmax.h:105:25: note: in expansion of macro '__careful_cmp'
    105 | #define min(x, y)       __careful_cmp(min, x, y)
        |                         ^~~~~~~~~~~~~
  fs/fuse/file.c:1326:16: note: in expansion of macro 'min'
   1326 |         return min(((pos + len - 1) >> PAGE_SHIFT) - (pos >> PAGE_SHIFT) + 1,
        |                ^~~

David sent another patch before that one (though it does not look like
you were explicitly sent that one). Arnd also sent one.

  https://lore.kernel.org/20251216141647.13911-1-david.laight.linux@gmail.com/
  https://lore.kernel.org/20251223215442.720828-1-arnd@kernel.org/

Cheers,
Nathan

  reply	other threads:[~2026-02-07  5:11 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-06 16:49 [GIT PULL 00/12 for v7.0] v7.0 Christian Brauner
2026-02-06 16:49 ` [GIT PULL 01/12 for v7.0] vfs rust Christian Brauner
2026-02-10  0:50   ` pr-tracker-bot
2026-02-06 16:49 ` [GIT PULL 02/12 for v7.0] vfs initrd Christian Brauner
2026-02-10  0:50   ` pr-tracker-bot
2026-02-06 16:49 ` [GIT PULL 03/12 for v7.0] vfs nonblocking_timestamps Christian Brauner
2026-02-10  0:50   ` pr-tracker-bot
2026-02-06 16:50 ` [GIT PULL 04/12 for v7.0] vfs leases Christian Brauner
2026-02-10  0:50   ` pr-tracker-bot
2026-02-06 16:50 ` [GIT PULL 05/12 for v7.0] vfs fserror Christian Brauner
2026-02-10  0:50   ` pr-tracker-bot
2026-02-06 16:50 ` [GIT PULL 06/12 for v7.0] vfs btrfs Christian Brauner
2026-02-10  0:50   ` pr-tracker-bot
2026-02-06 16:50 ` [GIT PULL 07/12 for v7.0] vfs minix Christian Brauner
2026-02-10  0:50   ` pr-tracker-bot
2026-02-06 16:50 ` [GIT PULL 08/12 for v7.0] vfs nullfs Christian Brauner
2026-02-10  0:50   ` pr-tracker-bot
2026-02-06 16:50 ` [GIT PULL 09/12 for v7.0] vfs atomic_open Christian Brauner
2026-02-10  0:50   ` pr-tracker-bot
2026-02-06 16:50 ` [GIT PULL 10/12 for v7.0] vfs namespace Christian Brauner
2026-02-10  0:50   ` pr-tracker-bot
2026-02-06 16:50 ` [GIT PULL 11/12 for v7.0] vfs iomap Christian Brauner
2026-02-10  0:50   ` pr-tracker-bot
2026-02-06 16:50 ` [GIT PULL 12/12 for v7.0] vfs misc Christian Brauner
2026-02-07  5:11   ` Nathan Chancellor [this message]
2026-02-09  9:31     ` Christian Brauner
2026-02-10  0:50   ` pr-tracker-bot
2026-02-16 12:29 ` [GIT PULL 13/12 for v7.0] kernel misc Christian Brauner
2026-02-16 22:11   ` pr-tracker-bot
2026-02-16 12:55 ` [GIT PULL 14/12 for v7.0] vfs misc 2 Christian Brauner
2026-02-16 22:11   ` pr-tracker-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260207051114.GA2289557@ax162 \
    --to=nathan@kernel.org \
    --cc=brauner@kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox