Re: [PATCH v3 28/35] xfs: add fs-verity support

[Christoph Hellwig <hch@lst.de>]

On Wed, Feb 18, 2026 at 10:57:35AM +0100, Andrey Albershteyn wrote:
> > > +static int
> > > +xfs_fsverity_drop_descriptor_page(
> > > +	struct inode	*inode,
> > > +	u64		offset)
> > > +{
> > > +	pgoff_t index = offset >> PAGE_SHIFT;
> > > +
> > > +	return invalidate_inode_pages2_range(inode->i_mapping, index, index);
> > > +}
> > 
> > What is the rationale for this?  Why do ext4 and f2fs get away without
> > it?
> 
> They don't skip blocks full of zero hashes and then synthesize them.
> XFS has holes in the tree and this is handling for the case
> fs block size < PAGE_SIZE when these tree holes are in one folio
> with descriptor. Iomap can not fill them without getting descriptor
> first.

Should we just simply not create tree holes for that case?  Anything
involving page cache validation is a pain, so if we have an easy
enough way to avoid it I'd rather do that.