Re: [PATCH 3/4] fs: remove fsparam_path / fs_param_is_path

["Darrick J. Wong" <djwong@kernel.org>]

On Thu, Feb 19, 2026 at 07:50:03AM +0100, Christoph Hellwig wrote:
> These are not used anywhere even after the fs_context conversion is
> finished, so remove them.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
>  Documentation/filesystems/mount_api.rst | 2 --
>  fs/fs_parser.c                          | 7 -------
>  include/linux/fs_parser.h               | 3 +--
>  3 files changed, 1 insertion(+), 11 deletions(-)
> 
> diff --git a/Documentation/filesystems/mount_api.rst b/Documentation/filesystems/mount_api.rst
> index b4a0f23914a6..e8b94357b4df 100644
> --- a/Documentation/filesystems/mount_api.rst
> +++ b/Documentation/filesystems/mount_api.rst
> @@ -648,7 +648,6 @@ The members are as follows:
>  	fs_param_is_enum	Enum value name 	result->uint_32
>  	fs_param_is_string	Arbitrary string	param->string
>  	fs_param_is_blockdev	Blockdev path		* Needs lookup

Unrelated: should xfs be using fsparam_bdev for its logdev/rtdev mount
options?

Or, more crazily, should it grow logfd/rtfd options that use fsparam_fd?

This patch looks ok,
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>

--D


> -	fs_param_is_path	Path			* Needs lookup
>  	fs_param_is_fd		File descriptor		result->int_32
>  	fs_param_is_uid		User ID (u32)           result->uid
>  	fs_param_is_gid		Group ID (u32)          result->gid
> @@ -681,7 +680,6 @@ The members are as follows:
>  	fsparam_enum()		fs_param_is_enum
>  	fsparam_string()	fs_param_is_string
>  	fsparam_bdev()		fs_param_is_blockdev
> -	fsparam_path()		fs_param_is_path
>  	fsparam_fd()		fs_param_is_fd
>  	fsparam_uid()		fs_param_is_uid
>  	fsparam_gid()		fs_param_is_gid
> diff --git a/fs/fs_parser.c b/fs/fs_parser.c
> index 79e8fe9176fa..b4cc4cce518a 100644
> --- a/fs/fs_parser.c
> +++ b/fs/fs_parser.c
> @@ -361,13 +361,6 @@ int fs_param_is_blockdev(struct p_log *log, const struct fs_parameter_spec *p,
>  }
>  EXPORT_SYMBOL(fs_param_is_blockdev);
>  
> -int fs_param_is_path(struct p_log *log, const struct fs_parameter_spec *p,
> -		     struct fs_parameter *param, struct fs_parse_result *result)
> -{
> -	return 0;
> -}
> -EXPORT_SYMBOL(fs_param_is_path);
> -
>  #ifdef CONFIG_VALIDATE_FS_PARSER
>  /**
>   * fs_validate_description - Validate a parameter specification array
> diff --git a/include/linux/fs_parser.h b/include/linux/fs_parser.h
> index 961562b101c5..98b83708f92b 100644
> --- a/include/linux/fs_parser.h
> +++ b/include/linux/fs_parser.h
> @@ -28,7 +28,7 @@ typedef int fs_param_type(struct p_log *,
>   */
>  fs_param_type fs_param_is_bool, fs_param_is_u32, fs_param_is_s32, fs_param_is_u64,
>  	fs_param_is_enum, fs_param_is_string, fs_param_is_blockdev,
> -	fs_param_is_path, fs_param_is_fd, fs_param_is_uid, fs_param_is_gid,
> +	fs_param_is_fd, fs_param_is_uid, fs_param_is_gid,
>  	fs_param_is_file_or_string;
>  
>  /*
> @@ -126,7 +126,6 @@ static inline bool fs_validate_description(const char *name,
>  #define fsparam_string(NAME, OPT) \
>  				__fsparam(fs_param_is_string, NAME, OPT, 0, NULL)
>  #define fsparam_bdev(NAME, OPT)	__fsparam(fs_param_is_blockdev, NAME, OPT, 0, NULL)
> -#define fsparam_path(NAME, OPT)	__fsparam(fs_param_is_path, NAME, OPT, 0, NULL)
>  #define fsparam_fd(NAME, OPT)	__fsparam(fs_param_is_fd, NAME, OPT, 0, NULL)
>  #define fsparam_file_or_string(NAME, OPT) \
>  				__fsparam(fs_param_is_file_or_string, NAME, OPT, 0, NULL)
> -- 
> 2.47.3
> 
>