From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CF2DD301002 for ; Fri, 20 Feb 2026 18:21:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771611697; cv=none; b=qHVJK3eLX/NQZUCh/mWdUzY13CRNi0kkK4SvlZhtdi2BS0vsVfWR2v7ipr3wPyP8S4dKD8D/F9Kz/Wq0lVRoEiiRNNfKQ484jTS4LFIigFy+RhKBS+tFYKHv1BdQKaJn2TY5tggzwG83/YXnRez2Ojj92NIdsUsno0GY6FbekTM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771611697; c=relaxed/simple; bh=3+4VEzQbuRsWa2hjECT4rwyg5W11G7wHh2/Q6b9BRuw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=jp5YpJNEmEfe+U/OIOKJ/maDl4n6NmhS6yq+lhqY47X2A9wkvb0GcfACu/kO2/JyFnQIZ0ziqtnBqbQxx34jM+YSzREJA1Oitxwds2+BszFJEbwQXXydSHYv9sOreVuhLHQcSv9rn4+P2HXhgSWMl7TfTEoMjX/O6Vb6qQT5FZI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=r4eEyLm9; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="r4eEyLm9" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 63315C116C6; Fri, 20 Feb 2026 18:21:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1771611697; bh=3+4VEzQbuRsWa2hjECT4rwyg5W11G7wHh2/Q6b9BRuw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=r4eEyLm9ZTaJZ/Zx0Fdc2VsKF0qr92Qq0KdD0wNylk5YSbFlHmBKC+gwGixdDHj+E mO1hc3BFM6t2jSWiykOooqpfQuqeyew/lr7nFItZozu6pDy2O3smfU+7wb/B6hRrqx 0Myuw/xJxPL57qyW8FangascxOSfz3kSJVbuBGkjTs+HDyxO40TcARAAcpmc5ZGZJR ZNsuklt8Eq140vO8IKzSSuzquwMzu6XVPaFwL2hDBmpZjMFHHHsf4yCMdAZTjxyaSG fhk0QiLV3E1eRoquEZ6C6ouB00QZ4wsTWSu87B58OipQ+w2imq1HKobDc2uL84RuUl f5T9Mzs2OiCFA== Date: Fri, 20 Feb 2026 10:21:36 -0800 From: "Darrick J. Wong" To: Christoph Hellwig Cc: Alexander Viro , Christian Brauner , Jan Kara , linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 3/4] fs: remove fsparam_path / fs_param_is_path Message-ID: <20260220182136.GS6467@frogsfrogsfrogs> References: <20260219065014.3550402-1-hch@lst.de> <20260219065014.3550402-4-hch@lst.de> <20260219160428.GQ6467@frogsfrogsfrogs> <20260220152402.GB14300@lst.de> Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260220152402.GB14300@lst.de> On Fri, Feb 20, 2026 at 04:24:02PM +0100, Christoph Hellwig wrote: > On Thu, Feb 19, 2026 at 08:04:28AM -0800, Darrick J. Wong wrote: > > > diff --git a/Documentation/filesystems/mount_api.rst b/Documentation/filesystems/mount_api.rst > > > index b4a0f23914a6..e8b94357b4df 100644 > > > --- a/Documentation/filesystems/mount_api.rst > > > +++ b/Documentation/filesystems/mount_api.rst > > > @@ -648,7 +648,6 @@ The members are as follows: > > > fs_param_is_enum Enum value name result->uint_32 > > > fs_param_is_string Arbitrary string param->string > > > fs_param_is_blockdev Blockdev path * Needs lookup > > > > Unrelated: should xfs be using fsparam_bdev for its logdev/rtdev mount > > options? > > Not sure what the point is in having separate string helpers with meaning, > but maybe I'm missing something/ I'm not sure either -- it'd be one thing if the fsconfig code could supply us with an open struct file to an O_EXCL bdev, but looking at the sole user ext4, all it does is sample i_rdev and pass it to bdev_file_open_by_dev. > > Or, more crazily, should it grow logfd/rtfd options that use fsparam_fd? > > What would the use case be for that? I've no idea, I guess if we had mount helper magic then it would be useful. --D