From: Chuck Lever <cel@kernel.org>
To: NeilBrown <neilb@ownmail.net>, Jeff Layton <jlayton@kernel.org>,
Olga Kornievskaia <okorniev@redhat.com>,
Dai Ngo <dai.ngo@oracle.com>, Tom Talpey <tom@talpey.com>
Cc: linux-nfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Chuck Lever <chuck.lever@oracle.com>
Subject: [PATCH v3 0/3] Automatic NFSv4 state revocation on filesystem unmount
Date: Tue, 24 Feb 2026 11:39:05 -0500 [thread overview]
Message-ID: <20260224163908.44060-1-cel@kernel.org> (raw)
From: Chuck Lever <chuck.lever@oracle.com>
When an NFS server exports a filesystem and clients hold NFSv4 state
(opens, locks, delegations), unmounting the underlying filesystem
fails with EBUSY. The /proc/fs/nfsd/unlock_fs interface exists for
administrators to manually revoke state before retrying the unmount,
but this approach has significant operational drawbacks.
Manual intervention breaks automation workflows. Containerized NFS
servers, orchestration systems, and unattended maintenance scripts
cannot reliably unmount exported filesystems without implementing
custom logic to detect the failure and invoke unlock_fs. System
administrators managing many exports face tedious, error-prone
procedures when decommissioning storage.
This series enables the NFS server to detect filesystem unmount
events and automatically revoke associated state. The mechanism
registers with a new SRCU notifier chain in VFS that fires during
mount teardown, after processing stuck children but before
fsnotify_vfsmount_delete(), while SB_ACTIVE is still set. When a
filesystem is unmounted, all NFSv4 opens, locks, and delegations
referencing it are revoked, async COPY operations are cancelled
with NFS4ERR_ADMIN_REVOKED sent to clients, NLM locks are released,
and cached file handles are closed.
With automatic revocation, unmount operations complete without
administrator intervention once the brief state cleanup finishes.
Clients receive immediate notification of state loss through
standard NFSv4 error codes, allowing applications to handle the
situation appropriately rather than encountering silent failures.
Based on v7.0-rc1
---
Changes since v2:
- Replace fs_pin with an SRCU umount notifier chain in VFS
- Merge the pending COPY cancellation patch
- Replace xa_cmpxchg() with xa_insert()
- Use cancel_work_sync() instead of flush_workqueue()
- Remove rcu_barrier()
- Correct misleading claims in kdoc comments and commit messages
Changes since v1:
- Explain why drop_client() is being renamed
- Finish implementing revocation on umount
- Rename pin_insert_group
- Clarified log output and code comments
- Hold nfsd_mutex while closing nfsd_files
Chuck Lever (3):
fs: add umount notifier chain for filesystem unmount notification
nfsd: revoke NFSv4 state when filesystem is unmounted
nfsd: close cached files on filesystem unmount
fs/namespace.c | 69 ++++++++++
fs/nfsd/Makefile | 2 +-
fs/nfsd/filecache.c | 45 +++++++
fs/nfsd/filecache.h | 1 +
fs/nfsd/netns.h | 5 +
fs/nfsd/nfs4state.c | 29 +++++
fs/nfsd/nfsctl.c | 10 +-
fs/nfsd/sb_watch.c | 283 ++++++++++++++++++++++++++++++++++++++++++
fs/nfsd/state.h | 7 ++
include/linux/mount.h | 4 +
10 files changed, 452 insertions(+), 3 deletions(-)
create mode 100644 fs/nfsd/sb_watch.c
--
2.53.0
next reply other threads:[~2026-02-24 16:39 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-24 16:39 Chuck Lever [this message]
2026-02-24 16:39 ` [PATCH v3 1/3] fs: add umount notifier chain for filesystem unmount notification Chuck Lever
2026-02-26 8:48 ` Christian Brauner
2026-02-26 10:52 ` Amir Goldstein
2026-02-26 13:27 ` Chuck Lever
2026-02-26 13:32 ` Jan Kara
2026-02-27 15:10 ` Chuck Lever
2026-03-01 14:37 ` Amir Goldstein
2026-03-01 17:20 ` Chuck Lever
2026-03-01 18:09 ` Amir Goldstein
2026-03-01 18:19 ` Chuck Lever
2026-03-02 4:09 ` NeilBrown
2026-03-02 13:57 ` Chuck Lever
2026-03-02 15:26 ` Jan Kara
2026-03-02 17:10 ` Jeff Layton
2026-03-02 17:37 ` Jan Kara
2026-03-02 17:53 ` Jeff Layton
2026-03-04 13:17 ` Christian Brauner
2026-03-04 15:15 ` Chuck Lever
2026-03-02 20:46 ` NeilBrown
2026-03-02 17:01 ` Chuck Lever
2026-03-02 20:36 ` NeilBrown
2026-03-03 20:02 ` Chuck Lever
2026-03-03 21:23 ` NeilBrown
2026-03-03 22:50 ` Chuck Lever
2026-03-04 1:01 ` NeilBrown
2026-03-04 13:05 ` Christian Brauner
2026-02-24 16:39 ` [PATCH v3 2/3] nfsd: revoke NFSv4 state when filesystem is unmounted Chuck Lever
2026-02-24 16:39 ` [PATCH v3 3/3] nfsd: close cached files on filesystem unmount Chuck Lever
2026-02-24 17:14 ` [PATCH v3 0/3] Automatic NFSv4 state revocation " Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260224163908.44060-1-cel@kernel.org \
--to=cel@kernel.org \
--cc=chuck.lever@oracle.com \
--cc=dai.ngo@oracle.com \
--cc=jlayton@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=neilb@ownmail.net \
--cc=okorniev@redhat.com \
--cc=tom@talpey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox