From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f182.google.com (mail-yw1-f182.google.com [209.85.128.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C898F426D18 for ; Thu, 26 Feb 2026 16:09:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772122172; cv=none; b=jyN/Hv6C6FPOdlG6vQjLqJu5oZtteS7Cn4e1uFn1VLRlNGhqz2zREov9j9HRpp6jU2Narg7+ze4zxzhHbeiTGzDdYYOWqdM3pGeYqBMDHn4OD+5eCvKBSJHVCjvMizcaftm7nSA8zEWM90ogAtarHcVvzsk2/fl41FC14quMAhI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772122172; c=relaxed/simple; bh=mGwXJxQ8B9+61F8/VPcfgs6XYDIXRha1M1Q+adyZkxw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ZfpoKEliWx0K324++UwK77B1+aeMUlllNt9WAu+XmdYHeXskqB6T8BorR+5DiQXhHUvRV10vQyZXIzQtmLoujK2mRmNAMkMbb+141K5VV3KKmntTjGWy6474jY+RJkBtR0ygcZt4khCRv/PZjdPN9CfhRV+Gmw5zuwyFi1AHicQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ZkKW0TcO; arc=none smtp.client-ip=209.85.128.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZkKW0TcO" Received: by mail-yw1-f182.google.com with SMTP id 00721157ae682-7986fb839f5so8960107b3.0 for ; Thu, 26 Feb 2026 08:09:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772122166; x=1772726966; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=OtssGMmgpsS0GlJdNGMxqurgMvcq6MJjd3dPtJY3SVc=; b=ZkKW0TcOoLZUPtOuXL19MBosyrwtx4L34DQfFdD5C7q5TXDyK6C7+6XBWMjR8Qx86e kfnTWsblnqP9PvI8cFL8GGdzTZfmTGPCGtheXsgac7wFIdnjSY5cpf9H8H5fvg2z4Uea h4tWyHKZyw5rl//4PEm+0H01LqRb4gTKEJqSyPOOcMnHrbEcw26UTStgYDCapS38GZ8b ni7W61YMVGoZftbs8l9o9q2UREPyFacfCIDgABVlRnvuYLdOSTuDwM1Dh4rsP2ffeyD3 CCbGvzSoOCD8INuWeo/AOy+hewL6azcj+0E+zsAO3amX60gjjtAQ3tbY5D2DwGVMEJUT qWfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772122166; x=1772726966; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=OtssGMmgpsS0GlJdNGMxqurgMvcq6MJjd3dPtJY3SVc=; b=F0vllCkeipuLtH9ps/CxF7f2uFMkTRaD4w/9rvX90HkxlXnC7oCS7YzBiOt14uc0yA 7vjFMxCVRgChgsGpP+inxJ98/mk7f7jPIP5Qokpj/Zpt/bzcdoA93OhivIcRTdIfkfWL cQeRMPNqR7GW84kPb0SC4sI8iG5EIemmS7El9QLh9p/A8o5qLqntQ1zzuYoG8guYY+W0 Ax8hvG+sF9cuuKqnCaNc2xiLvP4NLRnkciIayEp3oY8m/tomFwWv10dPph8kfAu5FSu4 fzwEfKu8YY36X9MgFrgbDbiPAuVaMR1/XPrkh1aA2Dxer61qzb8yqz4Fpv3pEtL5Dr4v pEIA== X-Gm-Message-State: AOJu0YxhSaDC/L6jX//434vTSJVkcpfUCmQDu2GTHzmo9RqG69omYrag 75xuinMZzgu1/tq1fZU77kq8PLEowFfHmZoQxRSuZsfngnJzxQMWWk7tGNjAsC6x/uU= X-Gm-Gg: ATEYQzyw9CZRzM9w2kFSB33TP4/EBSTB1LvL5nRslaqNlUkBW+Q8NVa1bId1SHwgOq8 IOHK9O7DZ1tuZYwv3SfnceWn7c2emomYBhcoy/bQTe/p8/Pi0+x4jH9scuN0WVKOXtAtbKOR97+ UQQ0s68aPIJQJmaEa9INY3gqAiJIg3QMcMqHaHEY7bHUdbNJBM5RvcNF/2jCwn2MinjwNyzfHRY zjeVyRQG+o2C0sOhbPQxZVQUEEpqwWfZlk5JZeqfs5k6cquJbNoFYrLeomVNyZve86jebmhsNh5 0OpePfzscpgWVqp3Vwwf/VC6rCApnfQfAVr2gxq01hLPzt20koFK5uVPMWn6Kxo0CztQheoxxdW +OX8kyWj36aG41ndng6vZ209/AQ3QNiyAB7Vldq+NrtjLA/4zOZ3oXCFYjNRAgVOEFr5TO3NXG/ stO+Qx6udBMSKuB1AidVxJnWEz7ud9HI7RKcBE/q5tBuhEY7hzML3Z17PvxiclPcaIseVdeMGTX ZqZiW2WX1jFBKLj/S9342ZL X-Received: by 2002:a05:690c:d8a:b0:797:ddf2:7cac with SMTP id 00721157ae682-798291548e2mr177249357b3.63.1772122166458; Thu, 26 Feb 2026 08:09:26 -0800 (PST) Received: from tux ([2601:7c0:c37c:4c00::5c0b]) by smtp.gmail.com with ESMTPSA id 00721157ae682-79876cb9f19sm10225967b3.53.2026.02.26.08.09.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Feb 2026 08:09:26 -0800 (PST) From: Ethan Tidmore To: linkinjeon@kernel.org, hyc.lee@gmail.com Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Ethan Tidmore Subject: [PATCH 2/3] ntfs: Add missing error code Date: Thu, 26 Feb 2026 10:09:05 -0600 Message-ID: <20260226160906.7175-3-ethantidmore06@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260226160906.7175-1-ethantidmore06@gmail.com> References: <20260226160906.7175-1-ethantidmore06@gmail.com> Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit If ntfs_attr_iget() fails no error code is assigned to be returned. Detected by Smatch: fs/ntfs/attrib.c:2665 ntfs_attr_add() warn: missing error code 'err' Signed-off-by: Ethan Tidmore --- fs/ntfs/attrib.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/ntfs/attrib.c b/fs/ntfs/attrib.c index e260540eb7c5..71ad870eceac 100644 --- a/fs/ntfs/attrib.c +++ b/fs/ntfs/attrib.c @@ -2661,6 +2661,7 @@ int ntfs_attr_add(struct ntfs_inode *ni, __le32 type, /* Open new attribute and resize it. */ attr_vi = ntfs_attr_iget(VFS_I(ni), type, name, name_len); if (IS_ERR(attr_vi)) { + err = PTR_ERR(attr_vi); ntfs_error(sb, "Failed to open just added attribute"); goto rm_attr_err_out; } -- 2.53.0