Linux filesystem development
 help / color / mirror / Atom feed
From: Al Viro <viro@zeniv.linux.org.uk>
To: "J. R. Okajima" <hooanon05g@gmail.com>
Cc: linux-fsdevel@vger.kernel.org
Subject: Re: v7.0-rc1, name_to_handle_at(..., AT_EMPTY_PATH)
Date: Fri, 27 Feb 2026 15:22:11 +0000	[thread overview]
Message-ID: <20260227152211.GB3836593@ZenIV> (raw)
In-Reply-To: <14544.1772189098@jrotkm2>

On Fri, Feb 27, 2026 at 07:44:58PM +0900, J. R. Okajima wrote:
> Hello Al Viro,
> 
> By the commit in v7.0-rc1,
> 	154ef7dce6a4d 2026-01-16 name_to_handle_at(): use CLASS(filename_uflags)
> name_to_handle_at(2) stopped handling AT_EMPTY_PATH, and an application
> which issues
> 	name_to_handle_at(fd, "", handle, &mnt_id, AT_EMPTY_PATH);
> started failing.
> 
> It is due to the commit dropped setting LOOKUP_EMPTY to lookup_flags in
> name_to_handle_at(2).

Huh?
	CLASS(filename_uflags, filename)(name, flag);
*does* accept empty path if flag & AT_EMPTY_PATH is non-zero.

So if you are really observing such failures, something else must've gone
wrong.  Details, please.

This
struct filename *getname_uflags(const char __user *filename, int uflags)
{
        int flags = (uflags & AT_EMPTY_PATH) ? LOOKUP_EMPTY : 0;

	return getname_flags(filename, flags);
}
is where AT_EMPTY_PATH is handled; could you check the arguuments it's getting
in your reproducer and argument passed to getname_flags()?

  reply	other threads:[~2026-02-27 15:19 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-27 10:44 v7.0-rc1, name_to_handle_at(..., AT_EMPTY_PATH) J. R. Okajima
2026-02-27 15:22 ` Al Viro [this message]
2026-02-27 15:41   ` hooanon05g
2026-02-27 18:48     ` Al Viro
2026-02-27 20:07       ` Al Viro
2026-02-27 22:35       ` hooanon05g

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260227152211.GB3836593@ZenIV \
    --to=viro@zeniv.linux.org.uk \
    --cc=hooanon05g@gmail.com \
    --cc=linux-fsdevel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox