From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 448C23451CC; Fri, 27 Feb 2026 21:16:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772227003; cv=none; b=RgiCHrHzQDNETxQSFVutaAneWqOJt60S3dSOX3GLTUQHEgO3Gc8GXWN9s5gmgGASkPtsKS/tFcjhIYQEmaVzBSvEpvVAf/az9do/eSWJ08AV9073Obxw5mVjLSTrCXUk9ucboYLKTFo8NYnrJ9mzcLSPYuoCFFEhHQcKup/eWvU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772227003; c=relaxed/simple; bh=IYVWg1WHxAiTLvaxqvVywcr6KglLqSKrG5o1wA/srJs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Z6csCnDIqn6tyzrgyTCNU9mHUK4jRNB1Y1RPeNb4CPlA78kNJRJ63vvzJPlIKDQ1Hnc6DnenrdIuRTMWd0S8q4uYP47M8CIXZ/SmDI/bnkccdXIDmeJ9zRr2XuPBakyapkxjOQbgXOCOtIagWMgSE4t7s41QrPRTITs9soTvMIA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=n9Y/HrUW; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="n9Y/HrUW" Received: by smtp.kernel.org (Postfix) with ESMTPSA id F4098C116C6; Fri, 27 Feb 2026 21:16:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772227002; bh=IYVWg1WHxAiTLvaxqvVywcr6KglLqSKrG5o1wA/srJs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=n9Y/HrUWuZUg8+lNeTyzL6gTo253Vmxl1ioHnAfR/Aw49uUiAtNG2CfzgiUzkQPnv i5wHzU2ZHD3Itr0lRNfzL2rLy5lO4IAwdYXDiLa1avnHMcu5omFm/imvcMJTEbprOA 65ZHdkbBbAdcqTPhW5d0hEmXXfLDwogzOWPs1j1DOIbIfzXmKLD1iMbzOj6DPgQWRj rokEjrjD8NyzHqZEf5OuPk7Q304WhRVSDKrP/ARW4BrDkqJA1RMQvdyQARjpohDELu zp7/mVlTgNARTjjmcQHQqvohZsVLz6Jq8iLNo4HPMcWhjMjRDViVvw8N3gWX2YYMam Us/UIEQtE2HHA== Date: Fri, 27 Feb 2026 13:16:39 -0800 From: Eric Biggers To: Christoph Hellwig Cc: "Theodore Y. Ts'o" , Jaegeuk Kim , Andreas Dilger , Chao Yu , Christian Brauner , "Darrick J. Wong" , linux-fscrypt@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 01/14] ext4: initialize the write hint in io_submit_init_bio Message-ID: <20260227211639.GA2659@quark> References: <20260226144954.142278-1-hch@lst.de> <20260226144954.142278-2-hch@lst.de> Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260226144954.142278-2-hch@lst.de> On Thu, Feb 26, 2026 at 06:49:21AM -0800, Christoph Hellwig wrote: > Make io_submit_init_bio complete by also initializing the write hint. > > Signed-off-by: Christoph Hellwig > --- > fs/ext4/page-io.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/fs/ext4/page-io.c b/fs/ext4/page-io.c > index a8c95eee91b7..a3644d6cb65f 100644 > --- a/fs/ext4/page-io.c > +++ b/fs/ext4/page-io.c > @@ -416,6 +416,7 @@ void ext4_io_submit_init(struct ext4_io_submit *io, > } > > static void io_submit_init_bio(struct ext4_io_submit *io, > + struct inode *inode, > struct buffer_head *bh) > { > struct bio *bio; > @@ -430,6 +431,7 @@ static void io_submit_init_bio(struct ext4_io_submit *io, > bio->bi_end_io = ext4_end_bio; > bio->bi_private = ext4_get_io_end(io->io_end); > io->io_bio = bio; > + io->io_bio->bi_write_hint = inode->i_write_hint; > io->io_next_block = bh->b_blocknr; > wbc_init_bio(io->io_wbc, bio); > } Maybe make this consistent with the other initializations by moving it up a line and doing: bio->bi_write_hint = inode->i_write_hint; - Eric