From: Christoph Hellwig <hch@lst.de>
To: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>
Cc: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
Christian Brauner <brauner@kernel.org>,
"Darrick J. Wong" <djwong@kernel.org>,
Carlos Maiolino <cem@kernel.org>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Anuj Gupta <anuj20.g@samsung.com>,
Kanchan Joshi <joshi.k@samsung.com>,
ntfs3@lists.linux.dev, linux-block@vger.kernel.org,
nvdimm@lists.linux.dev, linux-fsdevel@vger.kernel.org,
linux-xfs@vger.kernel.org
Subject: Re: [PATCH 12/16] ntfs3: remove copy and pasted iomap code
Date: Tue, 3 Mar 2026 16:21:41 +0100 [thread overview]
Message-ID: <20260303152141.GB5281@lst.de> (raw)
In-Reply-To: <449fd474-0b61-42ff-afbe-56b728d69262@paragon-software.com>
On Fri, Feb 27, 2026 at 02:46:08PM +0100, Konstantin Komarov wrote:
>
> Thanks for the note. The iomap helper was copied because
> `iomap_bio_read_folio_range` is defined `static` in iomap/bio.c and thus
> not available for reuse; that prevented using the exported helpers in this
> tree.
Please talk to maintainers and authors before copy and pasting their
code. There's usually a better way.
next prev parent reply other threads:[~2026-03-03 15:21 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-23 13:20 support file system generated / verified integrity information v4 Christoph Hellwig
2026-02-23 13:20 ` [PATCH 01/16] block: factor out a bio_integrity_action helper Christoph Hellwig
2026-02-23 13:20 ` [PATCH 02/16] block: factor out a bio_integrity_setup_default helper Christoph Hellwig
2026-02-23 13:20 ` [PATCH 03/16] block: add a bdev_has_integrity_csum helper Christoph Hellwig
2026-02-23 13:20 ` [PATCH 04/16] block: prepare generation / verification helpers for fs usage Christoph Hellwig
2026-02-23 13:20 ` [PATCH 05/16] block: make max_integrity_io_size public Christoph Hellwig
2026-02-23 13:20 ` [PATCH 06/16] block: add fs_bio_integrity helpers Christoph Hellwig
2026-02-23 13:20 ` [PATCH 07/16] block: pass a maxlen argument to bio_iov_iter_bounce Christoph Hellwig
2026-02-23 13:20 ` [PATCH 08/16] iomap: refactor iomap_bio_read_folio_range Christoph Hellwig
2026-02-23 13:20 ` [PATCH 09/16] iomap: pass the iomap_iter to ->submit_read Christoph Hellwig
2026-02-23 13:20 ` [PATCH 10/16] iomap: only call into ->submit_read when there is a read_ctx Christoph Hellwig
2026-02-23 13:20 ` [PATCH 11/16] iomap: allow file systems to hook into buffered read bio submission Christoph Hellwig
2026-02-23 13:20 ` [PATCH 12/16] ntfs3: remove copy and pasted iomap code Christoph Hellwig
2026-02-23 16:27 ` Darrick J. Wong
2026-02-27 13:46 ` Konstantin Komarov
2026-03-03 15:21 ` Christoph Hellwig [this message]
2026-03-04 9:57 ` Konstantin Komarov
2026-02-23 13:20 ` [PATCH 13/16] iomap: add a bioset pointer to iomap_read_folio_ops Christoph Hellwig
2026-02-23 13:20 ` [PATCH 14/16] iomap: support ioends for buffered reads Christoph Hellwig
2026-02-23 13:20 ` [PATCH 15/16] iomap: support T10 protection information Christoph Hellwig
2026-02-23 13:20 ` [PATCH 16/16] xfs: " Christoph Hellwig
2026-03-02 10:11 ` support file system generated / verified integrity information v4 Christian Brauner
2026-03-02 13:48 ` Christoph Hellwig
2026-03-04 12:55 ` Christian Brauner
2026-03-09 14:52 ` (subset) " Jens Axboe
2026-03-10 10:16 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260303152141.GB5281@lst.de \
--to=hch@lst.de \
--cc=almaz.alexandrovich@paragon-software.com \
--cc=anuj20.g@samsung.com \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=cem@kernel.org \
--cc=djwong@kernel.org \
--cc=joshi.k@samsung.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=ntfs3@lists.linux.dev \
--cc=nvdimm@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox