Re: [GIT PULL] libfuse: run fuse servers as a contained service

["Darrick J. Wong" <djwong@kernel.org>]

On Wed, Mar 04, 2026 at 02:36:03PM +0100, Bernd Schubert wrote:
> 
> 
> On 3/4/26 01:11, Darrick J. Wong wrote:
> > Hi Bernd,
> > 
> > Please pull this branch with changes for libfuse.
> > 
> > As usual, I did a test-merge with the main upstream branch as of a few
> > minutes ago, and didn't see any conflicts.  Please let me know if you
> > encounter any problems.
> 
> Hi Darrick,
> 
> quite some problems actually ;)
> 
> https://github.com/libfuse/libfuse/pull/1444
> 
> Basically everything fails.  Build test with

Doh :(

> ../../../home/runner/work/libfuse/libfuse/lib/fuse_service.c:24:10:
> fatal error: 'systemd/sd-daemon.h' file not found
>    24 | #include <systemd/sd-daemon.h>
> 
> 
> Two issues here:
> a) meson is not testing for sd-daemon.h?

Hrm.  meson.build *should* have this clause to detect systemd:

# Check for systemd support
systemd_system_unit_dir = get_option('systemdsystemunitdir')
if systemd_system_unit_dir == ''
  systemd = dependency('systemd', required: false)
  if systemd.found()
     systemd_system_unit_dir = systemd.get_variable(pkgconfig: 'systemd_system_unit_dir')
  endif
endif

if systemd_system_unit_dir == ''
  warning('could not determine systemdsystemunitdir, systemd stuff will not be installed')
else
  private_cfg.set_quoted('SYSTEMD_SYSTEM_UNIT_DIR', systemd_system_unit_dir)
  private_cfg.set('HAVE_SYSTEMD', true)
endif

# Check for libc SCM_RIGHTS support (aka Linux)
code = '''
#include <sys/socket.h>
int main(void) {
    int moo = SCM_RIGHTS;
    return moo;
}'''
if cc.links(code, name: 'libc SCM_RIGHTS support')
  private_cfg.set('HAVE_SCM_RIGHTS', true)
endif

if private_cfg.get('HAVE_SCM_RIGHTS', false) and private_cfg.get('HAVE_SYSTEMD', false)
  private_cfg.set('HAVE_SERVICEMOUNT', true)
endif


But apparently it built fuse_service.c anyway?  I'll have to look deeper
into what github ci did, since the pkgconfig fil... oh crikey.

systemd-dev contains the systemd.pc file, so the systemd.get_variable
call succeeds and returns a path, thereby enabling the build.  However,
the header files are in libsystemd-dev, and neither package depends on
the other.

So I clearly need to test for the presence of sd-daemon.h in that first
clause that determines if HAVE_SYSTEMD gets set.

> a.1) If not available needs to disable that service? Because I don't
> think BSD has support for systemd.

<nod>

> b) .github/workflow/*.yml files need to be adjusted to add in the new
> dependency.

Oh, ok.  The 'apt install' lines should probably add in systemd-dev.

> Please also have a look at checkpatch (which is a plain linux copy) and
> the spelling test failures.

Ok, will do.

--D

> 
> 
> Thanks,
> Bernd
> 
>