Re: [PATCH v2 4/5] xfs: steer allocation using write stream

[kernel test robot <lkp@intel.com>]

Hi Kanchan,

kernel test robot noticed the following build errors:

[auto build test ERROR on 11439c4635edd669ae435eec308f4ab8a0804808]

url:    https://github.com/intel-lab-lkp/linux/commits/Kanchan-Joshi/fs-add-generic-write-stream-management-ioctl/20260309-133736
base:   11439c4635edd669ae435eec308f4ab8a0804808
patch link:    https://lore.kernel.org/r/20260309052944.156054-5-joshi.k%40samsung.com
patch subject: [PATCH v2 4/5] xfs: steer allocation using write stream
config: i386-randconfig-011-20260309 (https://download.01.org/0day-ci/archive/20260309/202603092015.hrOdrSYV-lkp@intel.com/config)
compiler: gcc-14 (Debian 14.2.0-19) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260309/202603092015.hrOdrSYV-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202603092015.hrOdrSYV-lkp@intel.com/

All errors (new ones prefixed by >>):

   ld: fs/xfs/xfs_inode.o: in function `xfs_inode_write_stream_to_ag':
>> fs/xfs/xfs_inode.c:126:(.text+0x9ed): undefined reference to `__umoddi3'


vim +126 fs/xfs/xfs_inode.c

    95	
    96	xfs_agnumber_t
    97	xfs_inode_write_stream_to_ag(
    98		struct xfs_inode	*ip)
    99	{
   100		struct xfs_mount	*mp = ip->i_mount;
   101		uint8_t			stream_id = ip->i_write_stream;
   102		uint32_t		max_streams = xfs_inode_max_write_streams(ip);
   103		uint32_t		nr_ags;
   104		xfs_agnumber_t		start_ag, ags_per_stream;
   105	
   106		if (XFS_IS_REALTIME_INODE(ip) || !max_streams)
   107			return NULLAGNUMBER;
   108	
   109		stream_id -= 1; /* for 0-based math, stream-ids are 1-based */
   110	
   111		nr_ags = mp->m_sb.sb_agcount;
   112		ags_per_stream = nr_ags / max_streams;
   113	
   114		/* for the case when we have fewer AGs than streams */
   115		if (ags_per_stream == 0) {
   116			start_ag = stream_id % nr_ags;
   117			ags_per_stream = 1;
   118		} else {
   119			/* otherwise AGs are partitioned into N streams */
   120			start_ag = stream_id * ags_per_stream;
   121			/* uneven distribution case: last stream may contain extra */
   122			if (stream_id == max_streams-1)
   123				ags_per_stream = nr_ags - start_ag;
   124		}
   125		/* intra-stream concurrency: hash inode to choose AG within partition */
 > 126		return start_ag + (ip->i_ino % ags_per_stream);
   127	}
   128	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki