public inbox for linux-fsdevel@vger.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Miklos Szeredi <mszeredi@redhat.com>, linux-fsdevel@vger.kernel.org
Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev,
	Bernd Schubert <bernd@bsbernd.com>
Subject: Re: [PATCH v2 6/6] fuse: support FSCONFIG_SET_FD for "fd" option
Date: Sun, 15 Mar 2026 01:22:35 +0800	[thread overview]
Message-ID: <202603150134.fG997K63-lkp@intel.com> (raw)
In-Reply-To: <20260312194019.3077902-7-mszeredi@redhat.com>

Hi Miklos,

kernel test robot noticed the following build errors:

[auto build test ERROR on mszeredi-fuse/for-next]
[also build test ERROR on linus/master v7.0-rc3 next-20260311]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Miklos-Szeredi/fuse-create-fuse_dev-on-dev-fuse-open-instead-of-mount/20260313-153922
base:   https://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/fuse.git for-next
patch link:    https://lore.kernel.org/r/20260312194019.3077902-7-mszeredi%40redhat.com
patch subject: [PATCH v2 6/6] fuse: support FSCONFIG_SET_FD for "fd" option
config: riscv-allyesconfig (https://download.01.org/0day-ci/archive/20260315/202603150134.fG997K63-lkp@intel.com/config)
compiler: clang version 16.0.6 (https://github.com/llvm/llvm-project 7cbf1a2591520c2491aa35339f227775f4d3adf6)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260315/202603150134.fG997K63-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202603150134.fG997K63-lkp@intel.com/

All errors (new ones prefixed by >>):

>> fs/fuse/inode.c:916:2: error: cannot jump from switch statement to this case label
           default:
           ^
   fs/fuse/inode.c:864:16: note: jump bypasses initialization of variable with __attribute__((cleanup))
                   struct file *file __free(fput) = fget(result.uint_32);
                                ^
   fs/fuse/inode.c:910:2: error: cannot jump from switch statement to this case label
           case OPT_BLKSIZE:
           ^
   fs/fuse/inode.c:864:16: note: jump bypasses initialization of variable with __attribute__((cleanup))
                   struct file *file __free(fput) = fget(result.uint_32);
                                ^
   fs/fuse/inode.c:906:2: error: cannot jump from switch statement to this case label
           case OPT_MAX_READ:
           ^
   fs/fuse/inode.c:864:16: note: jump bypasses initialization of variable with __attribute__((cleanup))
                   struct file *file __free(fput) = fget(result.uint_32);
                                ^
   fs/fuse/inode.c:902:2: error: cannot jump from switch statement to this case label
           case OPT_ALLOW_OTHER:
           ^
   fs/fuse/inode.c:864:16: note: jump bypasses initialization of variable with __attribute__((cleanup))
                   struct file *file __free(fput) = fget(result.uint_32);
                                ^
   fs/fuse/inode.c:898:2: error: cannot jump from switch statement to this case label
           case OPT_DEFAULT_PERMISSIONS:
           ^
   fs/fuse/inode.c:864:16: note: jump bypasses initialization of variable with __attribute__((cleanup))
                   struct file *file __free(fput) = fget(result.uint_32);
                                ^
   fs/fuse/inode.c:886:2: error: cannot jump from switch statement to this case label
           case OPT_GROUP_ID:
           ^
   fs/fuse/inode.c:864:16: note: jump bypasses initialization of variable with __attribute__((cleanup))
                   struct file *file __free(fput) = fget(result.uint_32);
                                ^
   fs/fuse/inode.c:874:2: error: cannot jump from switch statement to this case label
           case OPT_USER_ID:
           ^
   fs/fuse/inode.c:864:16: note: jump bypasses initialization of variable with __attribute__((cleanup))
                   struct file *file __free(fput) = fget(result.uint_32);
                                ^
   fs/fuse/inode.c:867:2: error: cannot jump from switch statement to this case label
           case OPT_ROOTMODE:
           ^
   fs/fuse/inode.c:864:16: note: jump bypasses initialization of variable with __attribute__((cleanup))
                   struct file *file __free(fput) = fget(result.uint_32);
                                ^
   8 errors generated.


vim +916 fs/fuse/inode.c

510714a1f72bd3 Miklos Szeredi 2026-03-12  821  
84c215075b5723 Miklos Szeredi 2021-08-04  822  static int fuse_parse_param(struct fs_context *fsc, struct fs_parameter *param)
d8a5ba45457e4a Miklos Szeredi 2005-09-09  823  {
c30da2e981a703 David Howells  2019-03-25  824  	struct fs_parse_result result;
84c215075b5723 Miklos Szeredi 2021-08-04  825  	struct fuse_fs_context *ctx = fsc->fs_private;
c30da2e981a703 David Howells  2019-03-25  826  	int opt;
525bd65aa759ec Eric Sandeen   2024-07-02  827  	kuid_t kuid;
525bd65aa759ec Eric Sandeen   2024-07-02  828  	kgid_t kgid;
c30da2e981a703 David Howells  2019-03-25  829  
84c215075b5723 Miklos Szeredi 2021-08-04  830  	if (fsc->purpose == FS_CONTEXT_FOR_RECONFIGURE) {
e8b20a474cf2c4 Miklos Szeredi 2020-07-14  831  		/*
e8b20a474cf2c4 Miklos Szeredi 2020-07-14  832  		 * Ignore options coming from mount(MS_REMOUNT) for backward
e8b20a474cf2c4 Miklos Szeredi 2020-07-14  833  		 * compatibility.
e8b20a474cf2c4 Miklos Szeredi 2020-07-14  834  		 */
84c215075b5723 Miklos Szeredi 2021-08-04  835  		if (fsc->oldapi)
e8b20a474cf2c4 Miklos Szeredi 2020-07-14  836  			return 0;
e8b20a474cf2c4 Miklos Szeredi 2020-07-14  837  
84c215075b5723 Miklos Szeredi 2021-08-04  838  		return invalfc(fsc, "No changes allowed in reconfigure");
b330966f79fb4f Miklos Szeredi 2020-07-14  839  	}
b330966f79fb4f Miklos Szeredi 2020-07-14  840  
84c215075b5723 Miklos Szeredi 2021-08-04  841  	opt = fs_parse(fsc, fuse_fs_parameters, param, &result);
c30da2e981a703 David Howells  2019-03-25  842  	if (opt < 0)
c30da2e981a703 David Howells  2019-03-25  843  		return opt;
c30da2e981a703 David Howells  2019-03-25  844  
c30da2e981a703 David Howells  2019-03-25  845  	switch (opt) {
c30da2e981a703 David Howells  2019-03-25  846  	case OPT_SOURCE:
84c215075b5723 Miklos Szeredi 2021-08-04  847  		if (fsc->source)
84c215075b5723 Miklos Szeredi 2021-08-04  848  			return invalfc(fsc, "Multiple sources specified");
84c215075b5723 Miklos Szeredi 2021-08-04  849  		fsc->source = param->string;
c30da2e981a703 David Howells  2019-03-25  850  		param->string = NULL;
c30da2e981a703 David Howells  2019-03-25  851  		break;
c30da2e981a703 David Howells  2019-03-25  852  
c30da2e981a703 David Howells  2019-03-25  853  	case OPT_SUBTYPE:
c30da2e981a703 David Howells  2019-03-25  854  		if (ctx->subtype)
84c215075b5723 Miklos Szeredi 2021-08-04  855  			return invalfc(fsc, "Multiple subtypes specified");
c30da2e981a703 David Howells  2019-03-25  856  		ctx->subtype = param->string;
c30da2e981a703 David Howells  2019-03-25  857  		param->string = NULL;
d8a5ba45457e4a Miklos Szeredi 2005-09-09  858  		return 0;
c30da2e981a703 David Howells  2019-03-25  859  
c30da2e981a703 David Howells  2019-03-25  860  	case OPT_FD:
6ad877148e563a Miklos Szeredi 2026-03-12  861  		if (param->type == fs_value_is_file)
6ad877148e563a Miklos Szeredi 2026-03-12  862  			return fuse_opt_fd(fsc, param->file);
6ad877148e563a Miklos Szeredi 2026-03-12  863  
6ad877148e563a Miklos Szeredi 2026-03-12  864  		struct file *file __free(fput) = fget(result.uint_32);
6ad877148e563a Miklos Szeredi 2026-03-12  865  		return fuse_opt_fd(fsc, file);
d8a5ba45457e4a Miklos Szeredi 2005-09-09  866  
d8a5ba45457e4a Miklos Szeredi 2005-09-09  867  	case OPT_ROOTMODE:
c30da2e981a703 David Howells  2019-03-25  868  		if (!fuse_valid_type(result.uint_32))
84c215075b5723 Miklos Szeredi 2021-08-04  869  			return invalfc(fsc, "Invalid rootmode");
c30da2e981a703 David Howells  2019-03-25  870  		ctx->rootmode = result.uint_32;
cabdb4fa2f666f zhengbin       2020-01-14  871  		ctx->rootmode_present = true;
d8a5ba45457e4a Miklos Szeredi 2005-09-09  872  		break;
d8a5ba45457e4a Miklos Szeredi 2005-09-09  873  
d8a5ba45457e4a Miklos Szeredi 2005-09-09  874  	case OPT_USER_ID:
eea6a8322efd39 Eric Sandeen   2024-07-02  875  		kuid = result.uid;
525bd65aa759ec Eric Sandeen   2024-07-02  876  		/*
525bd65aa759ec Eric Sandeen   2024-07-02  877  		 * The requested uid must be representable in the
525bd65aa759ec Eric Sandeen   2024-07-02  878  		 * filesystem's idmapping.
525bd65aa759ec Eric Sandeen   2024-07-02  879  		 */
525bd65aa759ec Eric Sandeen   2024-07-02  880  		if (!kuid_has_mapping(fsc->user_ns, kuid))
525bd65aa759ec Eric Sandeen   2024-07-02  881  			return invalfc(fsc, "Invalid user_id");
525bd65aa759ec Eric Sandeen   2024-07-02  882  		ctx->user_id = kuid;
cabdb4fa2f666f zhengbin       2020-01-14  883  		ctx->user_id_present = true;
d8a5ba45457e4a Miklos Szeredi 2005-09-09  884  		break;
d8a5ba45457e4a Miklos Szeredi 2005-09-09  885  
87729a5514e855 Miklos Szeredi 2005-09-09  886  	case OPT_GROUP_ID:
eea6a8322efd39 Eric Sandeen   2024-07-02  887  		kgid = result.gid;
525bd65aa759ec Eric Sandeen   2024-07-02  888  		/*
525bd65aa759ec Eric Sandeen   2024-07-02  889  		 * The requested gid must be representable in the
525bd65aa759ec Eric Sandeen   2024-07-02  890  		 * filesystem's idmapping.
525bd65aa759ec Eric Sandeen   2024-07-02  891  		 */
525bd65aa759ec Eric Sandeen   2024-07-02  892  		if (!kgid_has_mapping(fsc->user_ns, kgid))
84c215075b5723 Miklos Szeredi 2021-08-04  893  			return invalfc(fsc, "Invalid group_id");
525bd65aa759ec Eric Sandeen   2024-07-02  894  		ctx->group_id = kgid;
cabdb4fa2f666f zhengbin       2020-01-14  895  		ctx->group_id_present = true;
87729a5514e855 Miklos Szeredi 2005-09-09  896  		break;
87729a5514e855 Miklos Szeredi 2005-09-09  897  
1e9a4ed9396e9c Miklos Szeredi 2005-09-09  898  	case OPT_DEFAULT_PERMISSIONS:
cabdb4fa2f666f zhengbin       2020-01-14  899  		ctx->default_permissions = true;
1e9a4ed9396e9c Miklos Szeredi 2005-09-09  900  		break;
1e9a4ed9396e9c Miklos Szeredi 2005-09-09  901  
1e9a4ed9396e9c Miklos Szeredi 2005-09-09  902  	case OPT_ALLOW_OTHER:
cabdb4fa2f666f zhengbin       2020-01-14  903  		ctx->allow_other = true;
1e9a4ed9396e9c Miklos Szeredi 2005-09-09  904  		break;
1e9a4ed9396e9c Miklos Szeredi 2005-09-09  905  
db50b96c0f28a2 Miklos Szeredi 2005-09-09  906  	case OPT_MAX_READ:
c30da2e981a703 David Howells  2019-03-25  907  		ctx->max_read = result.uint_32;
db50b96c0f28a2 Miklos Szeredi 2005-09-09  908  		break;
db50b96c0f28a2 Miklos Szeredi 2005-09-09  909  
d809161402e9f9 Miklos Szeredi 2006-12-06  910  	case OPT_BLKSIZE:
c30da2e981a703 David Howells  2019-03-25  911  		if (!ctx->is_bdev)
84c215075b5723 Miklos Szeredi 2021-08-04  912  			return invalfc(fsc, "blksize only supported for fuseblk");
c30da2e981a703 David Howells  2019-03-25  913  		ctx->blksize = result.uint_32;
d809161402e9f9 Miklos Szeredi 2006-12-06  914  		break;
d809161402e9f9 Miklos Szeredi 2006-12-06  915  
d8a5ba45457e4a Miklos Szeredi 2005-09-09 @916  	default:
c30da2e981a703 David Howells  2019-03-25  917  		return -EINVAL;
d8a5ba45457e4a Miklos Szeredi 2005-09-09  918  	}
5a53368277efa2 Miklos Szeredi 2005-09-09  919  
d8a5ba45457e4a Miklos Szeredi 2005-09-09  920  	return 0;
c30da2e981a703 David Howells  2019-03-25  921  }
d8a5ba45457e4a Miklos Szeredi 2005-09-09  922  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

  parent reply	other threads:[~2026-03-14 17:22 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-12 19:39 [PATCH v2 0/6] fuse: fix hang with sync init Miklos Szeredi
2026-03-12 19:39 ` [PATCH v2 1/6] fuse: create fuse_dev on /dev/fuse open instead of mount Miklos Szeredi
2026-03-13 22:05   ` Darrick J. Wong
2026-03-16 10:04     ` Miklos Szeredi
2026-03-19 23:36   ` Mark Brown
2026-03-12 19:40 ` [PATCH v2 2/6] fuse: add refcount to fuse_dev Miklos Szeredi
2026-03-13 22:28   ` Darrick J. Wong
2026-03-16 10:50     ` Miklos Szeredi
2026-03-12 19:40 ` [PATCH v2 3/6] fuse: don't require /dev/fuse fd to be kept open during mount Miklos Szeredi
2026-03-13 23:09   ` Darrick J. Wong
2026-03-16 11:29     ` Miklos Szeredi
2026-03-17 23:39       ` Darrick J. Wong
2026-03-17 23:49         ` Joanne Koong
2026-03-18 22:15           ` Bernd Schubert
2026-03-18 23:18             ` Joanne Koong
2026-03-12 19:40 ` [PATCH v2 4/6] fuse: clean up device cloning Miklos Szeredi
2026-03-13 23:59   ` Darrick J. Wong
2026-03-16 11:40     ` Miklos Szeredi
2026-03-12 19:40 ` [PATCH v2 5/6] fuse: alloc pqueue before installing fc Miklos Szeredi
2026-03-12 19:40 ` [PATCH v2 6/6] fuse: support FSCONFIG_SET_FD for "fd" option Miklos Szeredi
2026-03-13 12:03   ` kernel test robot
2026-03-14  0:10   ` Darrick J. Wong
2026-03-14 17:22   ` kernel test robot [this message]
2026-03-12 23:04 ` [PATCH v2 0/6] fuse: fix hang with sync init Bernd Schubert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202603150134.fG997K63-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=bernd@bsbernd.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=llvm@lists.linux.dev \
    --cc=mszeredi@redhat.com \
    --cc=oe-kbuild-all@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox