From: Christian Brauner <brauner@kernel.org>
To: Emanuele Rocca <emanuele.rocca@arm.com>,
Jann Horn <jannh@google.com>, Oleg Nesterov <oleg@redhat.com>
Cc: linux-kernel@vger.kernel.org,
Alexander Viro <viro@zeniv.linux.org.uk>,
Jan Kara <jack@suse.cz>,
linux-fsdevel@vger.kernel.org, Mark Brown <broonie@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] coredump: add core_pattern specifier for si_code
Date: Thu, 19 Mar 2026 11:31:40 +0100 [thread overview]
Message-ID: <20260319-detektiv-antrag-52ba733ccd8f@brauner> (raw)
In-Reply-To: <abql6_yzm1E_-PKR@NH27D9T0LF>
On Wed, Mar 18, 2026 at 02:17:31PM +0100, Emanuele Rocca wrote:
> Hi Christian,
>
> On 2026-03-18 10:45, Christian Brauner wrote:
> > Request %F which installs pidfd for the coredumping process into the
> > coredump helper then use the pidfd info ioctl in you binary with
> > PIDFD_INFO_EXIT | PIDFD_INFO_COREDUMP and you can retrieve the exit
> > status including the signal that was sent to the process.
>
> Correct me if I'm wrong, but PIDFD_INFO_COREDUMP seems to be setting
> coredump_signal, which is siginfo->si_signo? That information is already
> available by using the %s core_pattern specifier anyways.
>
> What I am looking for is si_code instead. Perhaps a field could be added
> to struct pidfs_attr and set in fs/pidfs.c similarly to what is currently
> done for si_signo?
I see. I don't have a problem with doing that. Let's rope in @Jann and
@Oleg to see whether they have any info-leak/security concerns around
this.
prev parent reply other threads:[~2026-03-19 10:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-17 15:00 [PATCH] coredump: add core_pattern specifier for si_code Emanuele Rocca
2026-03-18 9:45 ` Christian Brauner
2026-03-18 13:17 ` Emanuele Rocca
2026-03-19 10:31 ` Christian Brauner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260319-detektiv-antrag-52ba733ccd8f@brauner \
--to=brauner@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=broonie@kernel.org \
--cc=emanuele.rocca@arm.com \
--cc=jack@suse.cz \
--cc=jannh@google.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox