From: NeilBrown <neilb@ownmail.net>
To: "Theodore Ts'o" <tytso@mit.edu>,
Andreas Dilger <adilger.kernel@dilger.ca>,
Jan Kara <jack@suse.cz>,
Harshad Shirwadkar <harshadshirwadkar@gmail.com>
Cc: linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject:
Date: Fri, 20 Mar 2026 11:03:15 +1100 [thread overview]
Message-ID: <20260320000838.3797494-1-neilb@ownmail.net> (raw)
This new version
- includes some reviewed-bys
- adds an explanation to second patch of why ext4_fc_eligible() was
placed where it was in one case
- modifies the last patch (but keeps the Reviews - hope that is OK)
to keep the changes to ->i_nlink in __ext4_link
https://sashiko.dev/#/patchset/20260317224638.3809014-1-neilb%40ownmail.net
points out that removing it for the replay path might not be correct,
and I cannot now see any reason to move those changes (ext4_inc_count()
and drop_nlink())
From previous email:
My particular interest in changing ext4 is to remove the use of
d_alloc(). I will want to deprecate d_alloc() as it doesn't fit the new
model well.
The use of d_alloc() in ext4 is incidental to the actual task at hand.
The code really wants to pass around a parent directory and a name, and
only uses the dentry because that seems convenient. As these patches
show the code actually becomes simpler when we avoid the dentry.
NeilBrown
[PATCH v2 1/3] ext4: split __ext4_add_entry() out of ext4_add_entry()
[PATCH v2 2/3] ext4: add ext4_fc_eligible()
[PATCH v2 3/3] ext4: move dcache manipulation out of __ext4_link()
next reply other threads:[~2026-03-20 0:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-20 0:03 NeilBrown [this message]
2026-03-20 0:03 ` [PATCH v2 1/3] ext4: split __ext4_add_entry() out of ext4_add_entry() NeilBrown
2026-03-20 0:03 ` [PATCH v2 2/3] ext4: add ext4_fc_eligible() NeilBrown
2026-03-20 0:03 ` [PATCH v2 3/3] ext4: move dcache manipulation out of __ext4_link() NeilBrown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260320000838.3797494-1-neilb@ownmail.net \
--to=neilb@ownmail.net \
--cc=adilger.kernel@dilger.ca \
--cc=harshadshirwadkar@gmail.com \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=neil@brown.name \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox