Re: [PATCH] fs/namespace: fix double hlist_del_init of mnt_mp_list in get_detached_copy()

[Christian Brauner <brauner@kernel.org>]

On Sat, Mar 21, 2026 at 11:54:12AM +0530, Deepanshu Kartikey wrote:
> get_detached_copy() builds a new anonymous mount namespace for
> open_tree(OPEN_TREE_CLONE) by iterating all mounts in the cloned tree
> and calling mnt_add_to_ns() for each. However, child mounts in the
> cloned tree have their mnt_mp_list linked into the original mountpoint's
> m_list via mnt_set_mountpoint(). mnt_add_to_ns() only updates the
> namespace RB tree and never removes mnt_mp_list from that list.
> 
> When both the original and new anonymous namespaces are torn down on
> process exit, put_mnt_ns() -> umount_tree() -> __umount_mnt() calls
> hlist_del_init() on mnt_mp_list for each mount. Since the same mount
> belongs to two namespaces, hlist_del_init() is called twice on the same
> node, corrupting the list and causing a general protection fault.
> 
> Fix this by calling hlist_del_init() on mnt_mp_list and clearing mnt_mp
> for each mount inside the loop in get_detached_copy(). This detaches
> them from the original mountpoint's m_list. Clearing mnt_mp also
> prevents __umount_mnt() from passing a stale pointer to
> maybe_free_mountpoint() during teardown.
> 
> Reported-by: syzbot+e4470cc28308f2081ec8@syzkaller.appspotmail.com
> Closes: https://syzkaller.appspot.com/bug?extid=e4470cc28308f2081ec8
> Tested-by: syzbot+e4470cc28308f2081ec8@syzkaller.appspotmail.com
> Fixes: 2eea9ce4310d ("mounts: keep list of mounts in an rbtree")
> Signed-off-by: Deepanshu kartikey <Kartikey406@gmail.com>
> ---

Both the analysis and the fix are unfortunately very wrong.
The original cuplrit is how we create partial mount namespace copies.
I have a fix for that ready to go later.