From: Christian Brauner <brauner@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
David Disseldorp <ddiss@suse.de>, Petr Mladek <pmladek@suse.com>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Al Viro <viro@zeniv.linux.org.uk>, Jan Kara <jack@suse.cz>,
Steven Rostedt <rostedt@goodmis.org>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Sergey Senozhatsky <senozhatsky@chromium.org>
Subject: Re: [PATCH v3 0/6] initramfs: test and improve cpio hex header validation
Date: Tue, 24 Mar 2026 09:38:13 +0100 [thread overview]
Message-ID: <20260324-konsolidieren-zwanzig-63f3a987e0b7@brauner> (raw)
In-Reply-To: <20260323150753.1937b34b80772602d634d180@linux-foundation.org>
On Mon, Mar 23, 2026 at 03:07:53PM -0700, Andrew Morton wrote:
> On Mon, 23 Mar 2026 15:54:16 +0100 Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
>
> > The series that introduced simple_strntoul() had passed into kernel
> > without proper review and hence reinvented a wheel that's not needed.
> > Here is the refactoring to show that. It can go via PRINTK or VFS
> > tree.
> >
> > I have tested this on x86, but I believe the same result will be
> > on big-endian CPUs (I deduced that from how strtox() works).
>
> AI review asked a few questions:
>
> https://sashiko.dev/#/patchset/20260323150054.3587083-1-andriy.shevchenko@linux.intel.com
That review is mostly garbage. The VFS layer has it's own AI review
integration in its CI and it is filtered. We don't need to point
reviewers to 10 other AI tools. If there's relevant finds by AI it'll be
pointed out on list.
prev parent reply other threads:[~2026-03-24 8:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-23 14:54 [PATCH v3 0/6] initramfs: test and improve cpio hex header validation Andy Shevchenko
2026-03-23 14:54 ` [PATCH v3 1/6] initramfs_test: add fill_cpio() format parameter Andy Shevchenko
2026-03-23 14:54 ` [PATCH v3 2/6] initramfs_test: test header fields with 0x hex prefix Andy Shevchenko
2026-03-23 14:54 ` [PATCH v3 3/6] initramfs: Sort headers alphabetically Andy Shevchenko
2026-03-23 22:38 ` David Disseldorp
2026-03-23 14:54 ` [PATCH v3 4/6] initramfs: Refactor to use hex2bin() instead of custom approach Andy Shevchenko
2026-03-23 14:54 ` [PATCH v3 5/6] vsprintf: Revert "add simple_strntoul" Andy Shevchenko
2026-03-23 22:38 ` David Disseldorp
2026-03-23 14:54 ` [PATCH v3 6/6] kstrtox: Drop extern keyword in the simple_strtox() declarations Andy Shevchenko
2026-03-23 22:38 ` David Disseldorp
2026-03-23 22:07 ` [PATCH v3 0/6] initramfs: test and improve cpio hex header validation Andrew Morton
2026-03-23 23:07 ` David Disseldorp
2026-03-24 8:38 ` Christian Brauner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260324-konsolidieren-zwanzig-63f3a987e0b7@brauner \
--to=brauner@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=ddiss@suse.de \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=senozhatsky@chromium.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox