From: Christoph Hellwig <hch@lst.de>
To: Al Viro <viro@zeniv.linux.org.uk>,
Christian Brauner <brauner@kernel.org>,
David Sterba <dsterba@suse.com>,
Viacheslav Dubeyko <slava@dubeyko.com>,
John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>,
Yangtao Li <frank.li@vivo.com>
Cc: Jan Kara <jack@suse.cz>, linux-fsdevel@vger.kernel.org
Subject: [PATCH 2/5] adfs: rename adfs_notify_change to adfs_setattr
Date: Wed, 25 Mar 2026 07:36:49 +0100 [thread overview]
Message-ID: <20260325063711.3298685-3-hch@lst.de> (raw)
In-Reply-To: <20260325063711.3298685-1-hch@lst.de>
Make the function name match the method that it implements.
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
fs/adfs/adfs.h | 4 ++--
fs/adfs/dir.c | 2 +-
fs/adfs/file.c | 2 +-
fs/adfs/inode.c | 6 ++----
4 files changed, 6 insertions(+), 8 deletions(-)
diff --git a/fs/adfs/adfs.h b/fs/adfs/adfs.h
index 223f0283d20f..0d32b7cd99b4 100644
--- a/fs/adfs/adfs.h
+++ b/fs/adfs/adfs.h
@@ -144,8 +144,8 @@ struct adfs_discmap {
/* Inode stuff */
struct inode *adfs_iget(struct super_block *sb, struct object_info *obj);
int adfs_write_inode(struct inode *inode, struct writeback_control *wbc);
-int adfs_notify_change(struct mnt_idmap *idmap, struct dentry *dentry,
- struct iattr *attr);
+int adfs_setattr(struct mnt_idmap *idmap, struct dentry *dentry,
+ struct iattr *attr);
/* map.c */
int adfs_map_lookup(struct super_block *sb, u32 frag_id, unsigned int offset);
diff --git a/fs/adfs/dir.c b/fs/adfs/dir.c
index 493500f37cb9..309c0a88cabb 100644
--- a/fs/adfs/dir.c
+++ b/fs/adfs/dir.c
@@ -454,5 +454,5 @@ adfs_lookup(struct inode *dir, struct dentry *dentry, unsigned int flags)
*/
const struct inode_operations adfs_dir_inode_operations = {
.lookup = adfs_lookup,
- .setattr = adfs_notify_change,
+ .setattr = adfs_setattr,
};
diff --git a/fs/adfs/file.c b/fs/adfs/file.c
index cd13165fd904..73486667d6b4 100644
--- a/fs/adfs/file.c
+++ b/fs/adfs/file.c
@@ -32,5 +32,5 @@ const struct file_operations adfs_file_operations = {
};
const struct inode_operations adfs_file_inode_operations = {
- .setattr = adfs_notify_change,
+ .setattr = adfs_setattr,
};
diff --git a/fs/adfs/inode.c b/fs/adfs/inode.c
index 6830f8bc8d4e..4ac442d0a8c0 100644
--- a/fs/adfs/inode.c
+++ b/fs/adfs/inode.c
@@ -299,8 +299,7 @@ adfs_iget(struct super_block *sb, struct object_info *obj)
* later.
*/
int
-adfs_notify_change(struct mnt_idmap *idmap, struct dentry *dentry,
- struct iattr *attr)
+adfs_setattr(struct mnt_idmap *idmap, struct dentry *dentry, struct iattr *attr)
{
struct inode *inode = d_inode(dentry);
struct super_block *sb = inode->i_sb;
@@ -355,8 +354,7 @@ adfs_notify_change(struct mnt_idmap *idmap, struct dentry *dentry,
/*
* write an existing inode back to the directory, and therefore the disk.
- * The adfs-specific inode data has already been updated by
- * adfs_notify_change()
+ * The adfs-specific inode data has already been updated by * adfs_setattr().
*/
int adfs_write_inode(struct inode *inode, struct writeback_control *wbc)
{
--
2.47.3
next prev parent reply other threads:[~2026-03-25 6:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-25 6:36 trivial ->setattr cleanups Christoph Hellwig
2026-03-25 6:36 ` [PATCH 1/5] hfs: update comments on hfs_inode_setattr Christoph Hellwig
2026-03-25 11:52 ` Jan Kara
2026-03-25 16:38 ` vdubeyko
2026-03-25 6:36 ` Christoph Hellwig [this message]
2026-03-25 11:53 ` [PATCH 2/5] adfs: rename adfs_notify_change to adfs_setattr Jan Kara
2026-03-25 6:36 ` [PATCH 3/5] affs: rename affs_notify_change to affs_setattr Christoph Hellwig
2026-03-25 11:54 ` Jan Kara
2026-03-25 6:36 ` [PATCH 4/5] proc: rename proc_setattr to proc_nochmod_setattr Christoph Hellwig
2026-03-25 11:56 ` Jan Kara
2026-03-25 6:36 ` [PATCH 5/5] proc: rename proc_notify_change to proc_setattr Christoph Hellwig
2026-03-25 12:12 ` Jan Kara
2026-03-26 14:18 ` trivial ->setattr cleanups Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260325063711.3298685-3-hch@lst.de \
--to=hch@lst.de \
--cc=brauner@kernel.org \
--cc=dsterba@suse.com \
--cc=frank.li@vivo.com \
--cc=glaubitz@physik.fu-berlin.de \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=slava@dubeyko.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox