From: Christoph Hellwig <hch@lst.de>
To: Al Viro <viro@zeniv.linux.org.uk>,
Christian Brauner <brauner@kernel.org>,
David Sterba <dsterba@suse.com>,
Viacheslav Dubeyko <slava@dubeyko.com>,
John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>,
Yangtao Li <frank.li@vivo.com>
Cc: Jan Kara <jack@suse.cz>, linux-fsdevel@vger.kernel.org
Subject: [PATCH 3/5] affs: rename affs_notify_change to affs_setattr
Date: Wed, 25 Mar 2026 07:36:50 +0100 [thread overview]
Message-ID: <20260325063711.3298685-4-hch@lst.de> (raw)
In-Reply-To: <20260325063711.3298685-1-hch@lst.de>
Make the function name match the method that it implements.
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
fs/affs/affs.h | 2 +-
fs/affs/dir.c | 2 +-
fs/affs/file.c | 2 +-
fs/affs/inode.c | 5 ++---
fs/affs/symlink.c | 2 +-
5 files changed, 6 insertions(+), 7 deletions(-)
diff --git a/fs/affs/affs.h b/fs/affs/affs.h
index ac4e9a02910b..43e20b02b449 100644
--- a/fs/affs/affs.h
+++ b/fs/affs/affs.h
@@ -184,7 +184,7 @@ extern int affs_rename2(struct mnt_idmap *idmap,
/* inode.c */
extern struct inode *affs_new_inode(struct inode *dir);
-extern int affs_notify_change(struct mnt_idmap *idmap,
+extern int affs_setattr(struct mnt_idmap *idmap,
struct dentry *dentry, struct iattr *attr);
extern void affs_evict_inode(struct inode *inode);
extern struct inode *affs_iget(struct super_block *sb,
diff --git a/fs/affs/dir.c b/fs/affs/dir.c
index 5c8d83387a39..c53b98f7c687 100644
--- a/fs/affs/dir.c
+++ b/fs/affs/dir.c
@@ -71,7 +71,7 @@ const struct inode_operations affs_dir_inode_operations = {
.mkdir = affs_mkdir,
.rmdir = affs_rmdir,
.rename = affs_rename2,
- .setattr = affs_notify_change,
+ .setattr = affs_setattr,
};
static int
diff --git a/fs/affs/file.c b/fs/affs/file.c
index 6c9258359ddb..cede4bb1134e 100644
--- a/fs/affs/file.c
+++ b/fs/affs/file.c
@@ -1013,5 +1013,5 @@ const struct file_operations affs_file_operations = {
};
const struct inode_operations affs_file_inode_operations = {
- .setattr = affs_notify_change,
+ .setattr = affs_setattr,
};
diff --git a/fs/affs/inode.c b/fs/affs/inode.c
index 0bfc7d151dcd..f660e76584b3 100644
--- a/fs/affs/inode.c
+++ b/fs/affs/inode.c
@@ -213,13 +213,12 @@ affs_write_inode(struct inode *inode, struct writeback_control *wbc)
}
int
-affs_notify_change(struct mnt_idmap *idmap, struct dentry *dentry,
- struct iattr *attr)
+affs_setattr(struct mnt_idmap *idmap, struct dentry *dentry, struct iattr *attr)
{
struct inode *inode = d_inode(dentry);
int error;
- pr_debug("notify_change(%lu,0x%x)\n", inode->i_ino, attr->ia_valid);
+ pr_debug("setattr(%lu,0x%x)\n", inode->i_ino, attr->ia_valid);
error = setattr_prepare(&nop_mnt_idmap, dentry, attr);
if (error)
diff --git a/fs/affs/symlink.c b/fs/affs/symlink.c
index 094aec8d17b8..af6147e1d975 100644
--- a/fs/affs/symlink.c
+++ b/fs/affs/symlink.c
@@ -71,5 +71,5 @@ const struct address_space_operations affs_symlink_aops = {
const struct inode_operations affs_symlink_inode_operations = {
.get_link = page_get_link,
- .setattr = affs_notify_change,
+ .setattr = affs_setattr,
};
--
2.47.3
next prev parent reply other threads:[~2026-03-25 6:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-25 6:36 trivial ->setattr cleanups Christoph Hellwig
2026-03-25 6:36 ` [PATCH 1/5] hfs: update comments on hfs_inode_setattr Christoph Hellwig
2026-03-25 11:52 ` Jan Kara
2026-03-25 16:38 ` vdubeyko
2026-03-25 6:36 ` [PATCH 2/5] adfs: rename adfs_notify_change to adfs_setattr Christoph Hellwig
2026-03-25 11:53 ` Jan Kara
2026-03-25 6:36 ` Christoph Hellwig [this message]
2026-03-25 11:54 ` [PATCH 3/5] affs: rename affs_notify_change to affs_setattr Jan Kara
2026-03-25 6:36 ` [PATCH 4/5] proc: rename proc_setattr to proc_nochmod_setattr Christoph Hellwig
2026-03-25 11:56 ` Jan Kara
2026-03-25 6:36 ` [PATCH 5/5] proc: rename proc_notify_change to proc_setattr Christoph Hellwig
2026-03-25 12:12 ` Jan Kara
2026-03-26 14:18 ` trivial ->setattr cleanups Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260325063711.3298685-4-hch@lst.de \
--to=hch@lst.de \
--cc=brauner@kernel.org \
--cc=dsterba@suse.com \
--cc=frank.li@vivo.com \
--cc=glaubitz@physik.fu-berlin.de \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=slava@dubeyko.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox