public inbox for linux-fsdevel@vger.kernel.org
 help / color / mirror / Atom feed
From: Christian Brauner <brauner@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Christian Brauner <brauner@kernel.org>, Jan Kara <jack@suse.cz>,
	linux-fsdevel@vger.kernel.org, Al Viro <viro@zeniv.linux.org.uk>,
	David Sterba <dsterba@suse.com>,
	Viacheslav Dubeyko <slava@dubeyko.com>,
	John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>,
	Yangtao Li <frank.li@vivo.com>
Subject: Re: trivial ->setattr cleanups
Date: Thu, 26 Mar 2026 15:18:09 +0100	[thread overview]
Message-ID: <20260326-vorfuhr-ehedrama-1007afa3e4ff@brauner> (raw)
In-Reply-To: <20260325063711.3298685-1-hch@lst.de>

On Wed, 25 Mar 2026 07:36:47 +0100, Christoph Hellwig wrote:
> I've been looking into changes to ->setattr and noticed that we still
> have a few instances where the method has the ages old notify_change
> name.  Fix this up and include dusting off outdated comments.
> 
> Diffstat:
>  adfs/adfs.h       |    4 ++--
>  adfs/dir.c        |    2 +-
>  adfs/file.c       |    2 +-
>  adfs/inode.c      |    6 ++----
>  affs/affs.h       |    2 +-
>  affs/dir.c        |    2 +-
>  affs/file.c       |    2 +-
>  affs/inode.c      |    5 ++---
>  affs/symlink.c    |    2 +-
>  hfs/inode.c       |   21 ++-------------------
>  proc/base.c       |   22 +++++++++++-----------
>  proc/fd.c         |    6 +++---
>  proc/generic.c    |    8 ++++----
>  proc/internal.h   |    4 ++--
>  proc/namespaces.c |    4 ++--
>  proc/proc_net.c   |    2 +-
>  16 files changed, 37 insertions(+), 57 deletions(-)
> 
> [...]

Applied to the vfs-7.1.misc branch of the vfs/vfs.git tree.
Patches in the vfs-7.1.misc branch should appear in linux-next soon.

Please report any outstanding bugs that were missed during review in a
new review to the original patch series allowing us to drop it.

It's encouraged to provide Acked-bys and Reviewed-bys even though the
patch has now been applied. If possible patch trailers will be updated.

Note that commit hashes shown below are subject to change due to rebase,
trailer updates or similar. If in doubt, please check the listed branch.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
branch: vfs-7.1.misc

[1/5] hfs: update comments on hfs_inode_setattr
      https://git.kernel.org/vfs/vfs/c/d1312979f155
[2/5] adfs: rename adfs_notify_change to adfs_setattr
      https://git.kernel.org/vfs/vfs/c/9c71de5f4ddc
[3/5] affs: rename affs_notify_change to affs_setattr
      https://git.kernel.org/vfs/vfs/c/d0fdc1c0d0f6
[4/5] proc: rename proc_setattr to proc_nochmod_setattr
      https://git.kernel.org/vfs/vfs/c/690005b0b1e6
[5/5] proc: rename proc_notify_change to proc_setattr
      https://git.kernel.org/vfs/vfs/c/2ecd46d161fa

      parent reply	other threads:[~2026-03-26 14:18 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-25  6:36 trivial ->setattr cleanups Christoph Hellwig
2026-03-25  6:36 ` [PATCH 1/5] hfs: update comments on hfs_inode_setattr Christoph Hellwig
2026-03-25 11:52   ` Jan Kara
2026-03-25 16:38   ` vdubeyko
2026-03-25  6:36 ` [PATCH 2/5] adfs: rename adfs_notify_change to adfs_setattr Christoph Hellwig
2026-03-25 11:53   ` Jan Kara
2026-03-25  6:36 ` [PATCH 3/5] affs: rename affs_notify_change to affs_setattr Christoph Hellwig
2026-03-25 11:54   ` Jan Kara
2026-03-25  6:36 ` [PATCH 4/5] proc: rename proc_setattr to proc_nochmod_setattr Christoph Hellwig
2026-03-25 11:56   ` Jan Kara
2026-03-25  6:36 ` [PATCH 5/5] proc: rename proc_notify_change to proc_setattr Christoph Hellwig
2026-03-25 12:12   ` Jan Kara
2026-03-26 14:18 ` Christian Brauner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260326-vorfuhr-ehedrama-1007afa3e4ff@brauner \
    --to=brauner@kernel.org \
    --cc=dsterba@suse.com \
    --cc=frank.li@vivo.com \
    --cc=glaubitz@physik.fu-berlin.de \
    --cc=hch@lst.de \
    --cc=jack@suse.cz \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=slava@dubeyko.com \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox