Re: [PATCH v4 1/6] initramfs_test: add fill_cpio() inject_ox parameter

Andy Shevchenko
2026-03-30T09:49:35Z

On Sun, Mar 29, 2026 at 09:30:23PM +1100, David Disseldorp wrote:
> fill_cpio() uses sprintf() to write out the in-memory cpio archive from
> an array of struct initramfs_test_cpio. This change allows callers to
> modify the cpio sprintf() format string so that future tests can
> intentionally corrupt the header with "0x" and "0X" prefixed fields.

Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

...

> +/*
> + * bogus newc header with "0x" prefixes on the uid, gid and namesize values.

Perhaps Oxford comma?

> + * parse_header()/simple_str[n]toul() accept this.

Also see a comment in patch 4.

> + */

--
With Best Regards,
Andy Shevchenko